From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#14983: 24.3.50; url-http-end-of-document-sentinel does not work with https Date: Mon, 20 May 2019 14:56:03 -0400 Message-ID: <87r28t9cqk.fsf@gmail.com> References: <87bo5kixuj.wl%egh@e6h.org> <20130730141910.2167122AC01@mailgate.ucop.edu> <87egea1brs.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="63481"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 14983@debbugs.gnu.org, Andreas Schwab , Erik Hetzner To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 20 20:57:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSnTG-000GOu-09 for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 May 2019 20:57:14 +0200 Original-Received: from localhost ([127.0.0.1]:40500 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSnTF-0003Wy-1i for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 May 2019 14:57:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSnT6-0003Vk-E8 for bug-gnu-emacs@gnu.org; Mon, 20 May 2019 14:57:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSnT4-0002CF-VX for bug-gnu-emacs@gnu.org; Mon, 20 May 2019 14:57:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52573) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSnT4-0002Bn-QD for bug-gnu-emacs@gnu.org; Mon, 20 May 2019 14:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hSnT4-0004V5-E9 for bug-gnu-emacs@gnu.org; Mon, 20 May 2019 14:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 May 2019 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14983 X-GNU-PR-Package: emacs Original-Received: via spool by 14983-submit@debbugs.gnu.org id=B14983.155837857317232 (code B ref 14983); Mon, 20 May 2019 18:57:02 +0000 Original-Received: (at 14983) by debbugs.gnu.org; 20 May 2019 18:56:13 +0000 Original-Received: from localhost ([127.0.0.1]:37883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSnSH-0004Tr-3o for submit@debbugs.gnu.org; Mon, 20 May 2019 14:56:13 -0400 Original-Received: from mail-it1-f177.google.com ([209.85.166.177]:55818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSnSF-0004Td-2q for 14983@debbugs.gnu.org; Mon, 20 May 2019 14:56:11 -0400 Original-Received: by mail-it1-f177.google.com with SMTP id g24so736874iti.5 for <14983@debbugs.gnu.org>; Mon, 20 May 2019 11:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vNOAa3IXJr6vBLzWXuZLtciZcfstSZIcwYs6rlzE+sE=; b=Y+ikhXHwANuw5tIxwJmCX5qOxDDJ+7o3foOWm/Zvvx2ehEZK5ylQqkgZl+qRfCmX9I r80+ksVsfDcpYvBtpeNuUEGazGCyTlln3e2UOfTOfDiA89BxNtUiiZFMRuHTlebWm9zc TD4G8UUgsrkjtTyZuPbFDbGlB1b6E8sxrvyz+1hK4e+WLkDun+XPoPdG2wDSblNfFy+l Uf5oF2eFu2ogBGvKuZi7aQ0BVPzG5jB8brU1r/OUHwllU/wP+3G3ODBp/YD65sHJZIvq 2FLx56tpKuVcoBvFP899kVSZrpYzmfPt717FTOTv8jOGV9v7JiDcoYR6XApm8y161vAo eiag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=vNOAa3IXJr6vBLzWXuZLtciZcfstSZIcwYs6rlzE+sE=; b=JHpGKYdQiLMQ76H1AJtF6ech/FslWzd0ETKzMkd08eGqTaQgRlXve3/G5A4xl9Ozih lLkrMTJs8rr/0N6Hk2rqa46K4JoSXnwzW/71w2gVQ4rFqG41Ej6tN9VstayEXPQUbvCG sBZY2/gdyYG4t/VufCupzBfQ9OMbCP38S0kQsMctu/XCM1ZiylAqumtSY70DAXHouhGw XwGlY3SDlUpVh6eEXjsqulVRX+ORlKZuWqb1pLT5F+peQe1hcxO7rLO/ir7MwfVo1qWM x8eIWL5anG9G6Vaiu7LSPD0WMw6M9N8OtUEJY76gqt7tU0PjzJuxakkkgn5I37WKaG61 O9AQ== X-Gm-Message-State: APjAAAXADveQWUEOJyNcwNxvwY8DjDlXVLznHTTkkYcgXMYt4S+RfYre vGSkbOVvOzssiNE4T6QakC8= X-Google-Smtp-Source: APXvYqzGeFtdt83fFYl89Lu+SjJK5JCCD6NX/1fmuNROP/zajcgmdrGSkdl6LHwGIXWOiXfwYMJVZQ== X-Received: by 2002:a24:2bd3:: with SMTP id h202mr491638ita.115.1558378565094; Mon, 20 May 2019 11:56:05 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id d22sm5808897ioc.51.2019.05.20.11.56.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 11:56:04 -0700 (PDT) In-Reply-To: <87egea1brs.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 25 Dec 2015 22:03:35 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159586 Archived-At: Lars Ingebrigtsen writes: > Erik Hetzner writes: > >> This patch modifies url-https to support an optional retry-buffer >> argument, making this better approach possible. >> >> diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el >> index 7f21a38..868b6ff 100644 >> --- a/lisp/url/url-http.el >> +++ b/lisp/url/url-http.el >> @@ -895,8 +895,11 @@ should be shown to the user." >> (let ((url-request-method url-http-method) >> (url-request-extra-headers url-http-extra-headers) >> (url-request-data url-http-data)) >> - (url-http url-current-object url-callback-function >> - url-callback-arguments (current-buffer))))) >> + (if (string= "https" (url-type url-current-object)) >> + (url-https url-current-object url-callback-function >> + url-callback-arguments (current-buffer)) >> + (url-http url-current-object url-callback-function >> + url-callback-arguments (current-buffer)))))) >> ((url-http-parse-headers) >> (url-http-activate-callback)))))) >> >> @@ -1432,7 +1435,7 @@ p3p >> ,@(remove '&rest (remove '&optional args)))))) >> >> ;;;###autoload (autoload 'url-https "url-http") >> -(url-https-create-secure-wrapper nil (url callback cbargs)) >> +(url-https-create-secure-wrapper nil (url callback cbargs &optional retry-buffer)) > > I think this looks sensible, but the patch it two years old, so I wonder > whether there was a reason it wasn't applied back then? Or whether this > was fixed a different way? As far as I can tell, there's nothing wrong with the patch, and the problem wasn't fixed in some other way. Minor question on the copyright situation, it looks like Erik Hetzner is on the list, but the email is different and there are some other middle names. Is it the same person? (the patch is small enough to apply regardless though)