From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff Date: Fri, 14 Jun 2019 13:36:57 -0500 Message-ID: <87r27wqaie.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="95445"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.2.0; emacs 27.0.50 Cc: 36157@debbugs.gnu.org, Kaushal Modi To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 14 20:51:59 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbrIs-000Od6-LM for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Jun 2019 20:51:58 +0200 Original-Received: from localhost ([::1]:54306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbrIr-0000Cq-Kr for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Jun 2019 14:51:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56710) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbr5Z-0004so-QT for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2019 14:38:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbr5P-0000hj-Jm for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2019 14:38:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hbr5O-0000fR-3H for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2019 14:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hbr5N-0005uz-UH for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2019 14:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jun 2019 18:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36157 X-GNU-PR-Package: emacs Original-Received: via spool by 36157-submit@debbugs.gnu.org id=B36157.156053742722680 (code B ref 36157); Fri, 14 Jun 2019 18:38:01 +0000 Original-Received: (at 36157) by debbugs.gnu.org; 14 Jun 2019 18:37:07 +0000 Original-Received: from localhost ([127.0.0.1]:37786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbr4U-0005tk-RL for submit@debbugs.gnu.org; Fri, 14 Jun 2019 14:37:07 -0400 Original-Received: from mail-ot1-f47.google.com ([209.85.210.47]:43231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbr4S-0005tC-S9 for 36157@debbugs.gnu.org; Fri, 14 Jun 2019 14:37:05 -0400 Original-Received: by mail-ot1-f47.google.com with SMTP id i8so3538488oth.10 for <36157@debbugs.gnu.org>; Fri, 14 Jun 2019 11:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=bSBbrr/kdptUJOWgJkpTHvg1t5SKSRzQUfiPsZ1jazw=; b=H/1hvtgg/Ua8QCvwjp30ArjnYxjPPNngoLQJsVYIyr3pQ9r/adZlAPP1KXxI0oaR4I wW/2TvhKNSwyo/ZiGvuPzH/C+VElHQw9BB7j3LUwVojS3ABFiHKH7faU7/OhFDnqZmax iHDdi5V3OepfMKdO+f9z9N/NcZJwu8IAIiMuDjCFOxa8T/nAeJZFiCTR6YdzQOTLuFOy 7qOBxGFncDIL4jOx+rhTARK5V6sCOt/VIgP1591aElYHEoBn4AJjcZj44ItmO54UbARy sKOhA4xVnZWYkqbwsrYrR0uTbxX/Gup+Zq0Leq3wCg/gmLjGkYNCzdcv4veuxTO2VgzM ItKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=bSBbrr/kdptUJOWgJkpTHvg1t5SKSRzQUfiPsZ1jazw=; b=OZH8yfVk8Mwsf4IN1bhfuBkMbTq35Ebfhv2kKQpzEhjjhLNeUgxV2eYVoo7egeq+il WIWam7NmKkNr7Ao892MiDgILjOTL/t6vLe4o1uOewXkHx9K+re2UI6pj2OCMJPu8PdWy xzbH3c03ThKLwk9vqzPzXMpMl11ZrgYeSUxGR81YVIzn4dB7d8MGjB3NkNPHwi/qgQ3p 7SKm8uERx0n0kT5A91xdmAlk0tJ5EbqZr+aBkGBt54XiOFiHX/8SbD24cXnBwziFBirN 3Ft8h7TVbWSpjBFBV9e9BzHF7Q4HNaXI4rmFtIGZq+Wl5RqHQo3W4lETJyQNTeRnsiga qmow== X-Gm-Message-State: APjAAAX+lTiL+fQSP6TKahmKvc/S5JHYScUt88Rr5XO+nNJg1OlV2eoI vLgWimopE3PukZsk4Lpjphpiycty X-Google-Smtp-Source: APXvYqxSBN8casXs4jOwRK2o2YE9OGfHoW1qj0yp3hva0owhajufh/MLYPqz+hTyYgcj4Rgrmbs/XQ== X-Received: by 2002:a9d:5d10:: with SMTP id b16mr19187726oti.35.1560537418743; Fri, 14 Jun 2019 11:36:58 -0700 (PDT) Original-Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id d17sm1419133otl.52.2019.06.14.11.36.57 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 14 Jun 2019 11:36:57 -0700 (PDT) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160566 Archived-At: On Mon 10 Jun 2019 at 21:26, Richard Stallman wrote: > > If you look at the code of ediff-find-file, you will see the use of > > `symbol-value' everywhere. > > Which variables would this operate on? I'm not 100% sure what you're asking here, but ediff uses variables to store information and then passes those to functions. So in one function it'll do something like this: (setq file-A "/path/to/foo.el") (setq buff-A (get-buffer-create "foo.el")) (ediff-find-file file-A buff-A) And then ediff-find-file uses (symbol-value 'file-A) to get the string back. This breaks under lexical binding since the file-A argument shadows the file-A global value. I think it would be relatively easy to fix by just passing the values themselves, but that'll break backwards compatibility if people outside Emacs are relying on calling ediff functions this way. Hope that clears things up, Alex