From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#26328: 26.0.50; checkdoc action for join lines drops final " Date: Thu, 15 Aug 2019 20:11:19 -0400 Message-ID: <87r25motp4.fsf@gmail.com> References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> <877e7eowe2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="128581"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: Lars Ingebrigtsen , Marco Wahl , 26328@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 16 02:12:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyPql-000XKx-Qt for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 02:12:11 +0200 Original-Received: from localhost ([::1]:47968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyPqk-0001L0-5R for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Aug 2019 20:12:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48087) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyPqd-0001Kh-Jk for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 20:12:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyPqc-0003JS-8n for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 20:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43895) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyPqc-0003JI-3P for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 20:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hyPqb-00031N-Ub for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 20:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2019 00:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 26328-submit@debbugs.gnu.org id=B26328.156591428811565 (code B ref 26328); Fri, 16 Aug 2019 00:12:01 +0000 Original-Received: (at 26328) by debbugs.gnu.org; 16 Aug 2019 00:11:28 +0000 Original-Received: from localhost ([127.0.0.1]:52715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyPq3-00030T-N7 for submit@debbugs.gnu.org; Thu, 15 Aug 2019 20:11:27 -0400 Original-Received: from mail-io1-f44.google.com ([209.85.166.44]:43939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyPq2-00030D-Jk for 26328@debbugs.gnu.org; Thu, 15 Aug 2019 20:11:27 -0400 Original-Received: by mail-io1-f44.google.com with SMTP id 18so2824983ioe.10 for <26328@debbugs.gnu.org>; Thu, 15 Aug 2019 17:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sq+6bPUVVVvm55t40Vaxb9sawiT5nA/iPjtNh4OzHIQ=; b=chDr3bnDeQwoX0aSiXqh3G5hzz9dOT9LsdPjojLSn33T2rhEX5IPA5A5G0fnO+W2l0 PElnKSn+9GjDmj6qFSQpJJcCDttg//ZhALkf7H8ID8pgD9SLZJzYzippUUpR2U7XMaJ7 GMTmI6KKlxfKUOg8aQEV3lXGkvnw/3/O9x/O01s6Eg4vEp3N0MANXzDiJ9B1G8s8DACl 6VlI2/Q5527anXoJMKhpYp70GVR0IcX5cydw/85bP9Qal/ivYIxjqiwWfRG/VUVEcsqW OGjSAdV5XL5McAIj6bnes4cmKGAlwhQ1UDanJoT6hGeexcK3Ybj5KhryxmcoSDe8sCJ3 61AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=sq+6bPUVVVvm55t40Vaxb9sawiT5nA/iPjtNh4OzHIQ=; b=Ta3y1zKmsPpH5bA1a7vIj3nYBiNn0zWTCyES6C6pu3h1DkKlJa/H6H4C639jx0HdNX KU9Vw+cDivncvzKUPc4myfxLhcBp5ogWvt7XIMW9+MfDQ4kYLJs+Y6MspMzAWEeYSuHU 8w4kYVSp2bDJ327eVrcyWKdq1LZmKTJJCXjD08x2taqNF/JbpnHqDLM7c5SqoBzfxkTK oqmHnm6IrO/mYybqGY4w3lUdbw32lVy+3N2hVcfJKKE3tSRXpB6xTWGFJFVQhy+XcQUW nK6qdVp53tm1pM9uAoP+3w5+bLN618RmApfNBPFvHn39P2caCfpGSWK6uYRRbduTwv8Y ZufA== X-Gm-Message-State: APjAAAURF7ek7k/mOI2Fvyp+TSXaEqsBwMypardJBuTR7vG3UNtyY475 6ZVkLq9SWHN5a9pyqe+rOiX1acic X-Google-Smtp-Source: APXvYqx4M/GIVzYlyUQZLei2Th6D3gVC21WQMHEShGYJq9bFxF7XVoecsLRK5EtJ1DpHOqqNzYDNKQ== X-Received: by 2002:a5d:8411:: with SMTP id i17mr5055064ion.83.1565914281049; Thu, 15 Aug 2019 17:11:21 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id t2sm9917312iod.81.2019.08.15.17.11.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Aug 2019 17:11:20 -0700 (PDT) In-Reply-To: <877e7eowe2.fsf@gmail.com> (Alex Branham's message of "Thu, 15 Aug 2019 18:13:09 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165164 Archived-At: Alex Branham writes: > How about we just use delete-indentation along with the > already-calculate position p that we just asked the user about? Patch > attached. > + (when (checkdoc-autofix-ask-replace > + p (1+ p) > + "1st line not a complete sentence. Join these lines? " > + " " t) > + ;; They said yes. We have more fill work to do... > + (delete-indentation nil p (1+ p)) > + (setq msg nil))))) Note that the checkdoc-autofix-ask-replace is already replacing the newline with a space (which is kind of a strange behaviour, IMO, but that's how it is currently), so I'm not sure it makes much sense to call delete-indentation after.