From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37556: gpg "-unknown" version string Date: Mon, 30 Sep 2019 16:04:09 +0200 Message-ID: <87r23xdgo6.fsf@gnus.org> References: <87sgoel53e.fsf@gnus.org> <837e5qdzim.fsf@gnu.org> <83pnjicgso.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="28844"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37556@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 30 16:05:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEwIc-0007Mr-Tr for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Sep 2019 16:05:15 +0200 Original-Received: from localhost ([::1]:52912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEwIb-0007zU-Gh for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Sep 2019 10:05:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51012) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEwIR-0007xO-Vp for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 10:05:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEwIQ-0001PL-Q1 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 10:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51166) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEwIQ-0001PD-N8 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 10:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEwIQ-00053u-H3 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2019 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37556 X-GNU-PR-Package: emacs Original-Received: via spool by 37556-submit@debbugs.gnu.org id=B37556.156985225519365 (code B ref 37556); Mon, 30 Sep 2019 14:05:02 +0000 Original-Received: (at 37556) by debbugs.gnu.org; 30 Sep 2019 14:04:15 +0000 Original-Received: from localhost ([127.0.0.1]:59981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEwHe-00052H-QZ for submit@debbugs.gnu.org; Mon, 30 Sep 2019 10:04:15 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:53950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEwHd-000529-HV for 37556@debbugs.gnu.org; Mon, 30 Sep 2019 10:04:13 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEwHZ-0001w4-GK; Mon, 30 Sep 2019 16:04:12 +0200 In-Reply-To: (Juanma Barranquero's message of "Mon, 30 Sep 2019 11:32:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167883 Archived-At: Juanma Barranquero writes: > On Mon, Sep 30, 2019 at 10:46 AM Eli Zaretskii wrote: > >> You are saying that -unknown is in this case the same as -alpha. > > In fact, Lars gave it priority -4, so like a snapshot. > >> My problem is how to be sure this is the case everywhere where -unknown >> could be used. > > True, but if -unknown is really uncommon, we can deal with the problems as > they are reported (if ever). Looking at the code, just keeping this in epg* is really awkward, because we compare the version strings afterwards (in other contexts) with version<=, which will then fail. So I think this patch is needed to fix the epg problem. But I'm not confident that it won't change behaviour for other users of these version functions. On the other hand, we have been adding to this alist over the years without anything blowing up (that I know of), so perhaps it is safe-ish? If it turns out to be a problem, it's easy enough to back out (but then I don't really know how to fix the original epg problem in a sensible manner). diff --git a/lisp/subr.el b/lisp/subr.el index 45b99a82d2..efe530cd54 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -5285,6 +5285,8 @@ version-regexp-alist ("^[-._+]$" . -4) ;; treat "1.2.3-CVS" as snapshot release ("^[-._+ ]?\\(cvs\\|git\\|bzr\\|svn\\|hg\\|darcs\\)$" . -4) + ;; treat "-unknown" the same as snapshots. + ("^[-._+ ]?unknown$" . -4) ("^[-._+ ]?alpha$" . -3) ("^[-._+ ]?beta$" . -2) ("^[-._+ ]?\\(pre\\|rc\\)$" . -1)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no