From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22780: 25.1.50; wrong average width picked for bold face for 7x13 X11 font Date: Sun, 17 Nov 2019 07:55:04 +0100 Message-ID: <87r227dmbb.fsf@gnus.org> References: <1cnsT0-0000ii-Ph@gedanken.org.uk> <83wpbqa6rv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="181514"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 22780@debbugs.gnu.org, alex@khesin.com, "Andrew M. Bishop" To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 17 07:56:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iWETi-000l1b-Iw for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 07:56:10 +0100 Original-Received: from localhost ([::1]:52284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWETh-0001V6-Ga for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 01:56:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47213) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWETc-0001ST-9i for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 01:56:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWETa-0000Vd-31 for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 01:56:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59473) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWETZ-0000VS-Vo for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 01:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iWETZ-0000MO-S7 for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 01:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Nov 2019 06:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22780 X-GNU-PR-Package: emacs Original-Received: via spool by 22780-submit@debbugs.gnu.org id=B22780.15739737181326 (code B ref 22780); Sun, 17 Nov 2019 06:56:01 +0000 Original-Received: (at 22780) by debbugs.gnu.org; 17 Nov 2019 06:55:18 +0000 Original-Received: from localhost ([127.0.0.1]:40061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWESr-0000LK-Lc for submit@debbugs.gnu.org; Sun, 17 Nov 2019 01:55:17 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:43278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWESq-0000L2-HZ for 22780@debbugs.gnu.org; Sun, 17 Nov 2019 01:55:17 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWESf-0004Ds-93; Sun, 17 Nov 2019 07:55:08 +0100 In-Reply-To: <83wpbqa6rv.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Mar 2017 17:39:32 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171760 Archived-At: Eli Zaretskii writes: >> Using 'git bisect' I traced down the change that caused it and >> demonstrated that it can be fixed by this patch. >> >> -------------------- src/xfaces.c patch -------------------- >> diff --git a/src/xfaces.c b/src/xfaces.c >> index 5077cb2d94..c898b7886f 100644 >> --- a/src/xfaces.c >> +++ b/src/xfaces.c >> @@ -5485,7 +5485,7 @@ realize_x_face (struct face_cache *cache, Lisp_Object attrs[LFACE_VECTOR_SIZE]) >> } >> if (! FONT_OBJECT_P (attrs[LFACE_FONT_INDEX])) >> attrs[LFACE_FONT_INDEX] >> - = font_load_for_lface (f, attrs, Ffont_spec (0, NULL)); >> + = font_load_for_lface (f, attrs, attrs[LFACE_FONT_INDEX]); >> if (FONT_OBJECT_P (attrs[LFACE_FONT_INDEX])) >> { >> face->font = XFONT_OBJECT (attrs[LFACE_FONT_INDEX]); >> -------------------- src/xfaces.c patch -------------------- >> >> This reverts a patch that was made as part of bug #17973. The change >> in src/font.c that was also made in that bug report seems to not be >> relevant. >> >> This is clearly a regression from Emacs 24 but since this change was >> made to fix another bug it might be quite difficult to find a change >> that works for both. > > I'm CC'ing Handa-san who was involved in solving that bug. Reverting > the solution for that bug is clearly not TRT, but I hope Handa-san > will have comments about your particular problem. I tried the recipe with Emacs 27, and the problem still seems to be present there: "-misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1" "-misc-fixed-bold-r-normal--13-120-75-75-c-80-iso8859-1" The code in realize_gui_face hasn't changed since the bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no