unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Juri Linkov <juri@linkov.net>
Cc: schwab@linux-m68k.org, 38587@debbugs.gnu.org
Subject: bug#38587: base64-decode-region breaks encoding
Date: Tue, 24 Dec 2019 16:37:15 +0100	[thread overview]
Message-ID: <87r20tenv8.fsf@gnus.org> (raw)
In-Reply-To: <87o8w6zgz5.fsf@mail.linkov.net> (Juri Linkov's message of "Wed,  18 Dec 2019 01:10:06 +0200")

Juri Linkov <juri@linkov.net> writes:

> Thanks, I'm using this advice.
>
> (advice-add 'base64-decode-region :after
>             (lambda (beg end &optional _base64url)
>               (decode-coding-region beg end buffer-file-coding-system))
>             '((name . base64-decode-region-with-buffer-coding)))

I think in many cases this will work fine, but you probably will have
Emacs double-decode a lot of data, as the other code in Emacs will
normally call decode-coding-region (if you want to end up with text),
and you'll destroy the bits of your Emacs that decodes base64 data into
images and the like.

(If I read the advice correctly -- I'm not very familiar with advising
functions.)

> So I'm closing this.  Not sure what could be added to documentation.

Something equivalent to what the manual has to say about it would be
nice.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-12-24 15:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 23:55 bug#38587: base64-decode-region breaks encoding Juri Linkov
2019-12-13  2:52 ` Lars Ingebrigtsen
2019-12-13  7:12   ` Eli Zaretskii
2019-12-14 23:31   ` Juri Linkov
2019-12-15  8:56     ` Andreas Schwab
2019-12-15 22:40       ` Juri Linkov
2019-12-16 15:58         ` Eli Zaretskii
2019-12-16 21:51           ` Juri Linkov
2019-12-17 16:04             ` Eli Zaretskii
2019-12-17 23:10               ` Juri Linkov
2019-12-24 15:37                 ` Lars Ingebrigtsen [this message]
2019-12-24 16:13                   ` Lars Ingebrigtsen
2019-12-16 16:18         ` Andreas Schwab
2019-12-17 16:27         ` Lars Ingebrigtsen
2019-12-15 15:26     ` Eli Zaretskii
2019-12-15 22:41       ` Juri Linkov
2019-12-16  3:28         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r20tenv8.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=38587@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).