From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#39353: [PATCH] Use current-prefix-arg instead of prefix-arg Date: Thu, 30 Jan 2020 08:12:27 -0500 Message-ID: <87r1zhay10.fsf@gmail.com> References: <20200130033504.64697-1-khubert@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="114559"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 39353@debbugs.gnu.org To: Kyle Hubert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 30 14:13:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ix9dF-000Tbr-P4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jan 2020 14:13:17 +0100 Original-Received: from localhost ([::1]:60584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ix9dE-00022g-Qk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jan 2020 08:13:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41751) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ix9d6-00021K-90 for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 08:13:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ix9d1-0008Kn-Me for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 08:13:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57299) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ix9d0-0008Cx-G6 for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 08:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ix9d0-0003sI-CO for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 08:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jan 2020 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39353 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39353-submit@debbugs.gnu.org id=B39353.158038996114867 (code B ref 39353); Thu, 30 Jan 2020 13:13:02 +0000 Original-Received: (at 39353) by debbugs.gnu.org; 30 Jan 2020 13:12:41 +0000 Original-Received: from localhost ([127.0.0.1]:35039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix9ce-0003rj-T8 for submit@debbugs.gnu.org; Thu, 30 Jan 2020 08:12:41 -0500 Original-Received: from mail-qv1-f67.google.com ([209.85.219.67]:40668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix9cd-0003rX-8L for 39353@debbugs.gnu.org; Thu, 30 Jan 2020 08:12:40 -0500 Original-Received: by mail-qv1-f67.google.com with SMTP id dp13so1428589qvb.7 for <39353@debbugs.gnu.org>; Thu, 30 Jan 2020 05:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=09CsNyoEC93kqfre62xoJ8QdBOBzAfjQ/m388gljFYk=; b=OlVWStx8xYVC/t5a6gPzRqus6GDitEE+nLA/JN/Mlfw5B7522mDij1aBKD1/sMfuTb BDVqTMviAQ9JD5HKbZLieOYTecZrVYwiYkpjooyZoO5UdJ/rxU+/ufvpKZisnIfbh4oQ G8xizrcSVqube7Y/5VD698ByZtUpa4VYTmJYXyIg5J+JXBG7/xHYsHWHfOLaEmzlsfoY AAoeZV7h+QAKa0NSLCZnN1m6GbUR7Z32QXWd5a1Mc2HYHYzLL5cwFZWPQ0tgJb+Jt2OC +ZEa+Bv1hqJ8H17XKFcgTF1rpe/Yzkwhjt2uAW8OAwm8Cd2nDI9YDuEdbjGQ1t9EfyWa Flvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=09CsNyoEC93kqfre62xoJ8QdBOBzAfjQ/m388gljFYk=; b=j65GDXB87qbDHFsWQwwWA1MQgc+uMS0RL1Yuq5n8OaYUVxPWXxbAy4688tAdzIn135 RQqX9uSfxiRVpBHWHnIVoI69ZwsDNkjnQEW6spZks/E8fghbvP+S+LEicLcU3nSyJsOQ 0iSUMKxXXgu3MA3xO+0P4nm8wcmzG5mCinfuP/p9QXtgZ3hwYtff5m26pU9vJ2SprqUK sCgcseJpnGNxYn9dUIYioBNkba1Q0CE5/Xn0s/esgRJcdRnMiAO3IxCQqe9WEP20ITgc xuR/07UOLL2RdjwF23sNEhXgl62ErG3nFYKEjQS3XnxyzKQUUS6keMNq1naYlz0tsYBH 6uKg== X-Gm-Message-State: APjAAAUmErZ6YPLBMsB1SvtkvvGjXyXhGofMSM0R1dhM/SH++Aey7/Uw bnpDU4cGSJj24h5M3RWAmS4jaSlT X-Google-Smtp-Source: APXvYqzHAj2thF/6DQpxzCAiUqXA7btozv+/JHGAqQ1XNtwuhHqscnhp7Dtblr9U6mM9YL17GmeUIg== X-Received: by 2002:ad4:4aaa:: with SMTP id i10mr4471731qvx.27.1580389953595; Thu, 30 Jan 2020 05:12:33 -0800 (PST) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id r10sm2654226qkm.23.2020.01.30.05.12.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Jan 2020 05:12:33 -0800 (PST) In-Reply-To: (Kyle Hubert's message of "Wed, 29 Jan 2020 22:53:58 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175435 Archived-At: Kyle Hubert writes: > I have a hard time testing the change to simple.el, as I don't understand > execute-extended-command. Can anyone help here? I'm worried since it isn't > using (interactive "P") that this is incorrect. I admit I'm deeper in the > guts of emacs than typical. The simple.el let-binding is around command-execute, not execute-extended-command. command-execute does specifically read prefix-arg, so I think that part of your patch should be dropped (I haven't looked in detail at the ediff part, but it sounds right). >> --- a/lisp/simple.el >> +++ b/lisp/simple.el >> @@ -1888,7 +1888,7 @@ invoking, give a prefix argument to >> `execute-extended-command'." >> ;; `function' and not `execute-extended-command'. The difference is >> ;; visible in cases such as M-x RET and then C-x z (bug#11506). >> (setq real-this-command function) >> - (let ((prefix-arg prefixarg)) >> + (let ((current-prefix-arg prefixarg)) >> (command-execute function 'record))