From: Noam Postavsky <npostavs@gmail.com>
To: Kyle Hubert <khubert@gmail.com>
Cc: 39353@debbugs.gnu.org
Subject: bug#39353: [PATCH] Use current-prefix-arg instead of prefix-arg
Date: Thu, 30 Jan 2020 08:12:27 -0500 [thread overview]
Message-ID: <87r1zhay10.fsf@gmail.com> (raw)
In-Reply-To: <CAJoZ4U2hi46eUqQnbtndf3AWXpGa0YXwRYthFWaadhmUMwgfDg@mail.gmail.com> (Kyle Hubert's message of "Wed, 29 Jan 2020 22:53:58 -0500")
Kyle Hubert <khubert@gmail.com> writes:
> I have a hard time testing the change to simple.el, as I don't understand
> execute-extended-command. Can anyone help here? I'm worried since it isn't
> using (interactive "P") that this is incorrect. I admit I'm deeper in the
> guts of emacs than typical.
The simple.el let-binding is around command-execute, not
execute-extended-command. command-execute does specifically read
prefix-arg, so I think that part of your patch should be dropped (I
haven't looked in detail at the ediff part, but it sounds right).
>> --- a/lisp/simple.el
>> +++ b/lisp/simple.el
>> @@ -1888,7 +1888,7 @@ invoking, give a prefix argument to
>> `execute-extended-command'."
>> ;; `function' and not `execute-extended-command'. The difference is
>> ;; visible in cases such as M-x <cmd> RET and then C-x z (bug#11506).
>> (setq real-this-command function)
>> - (let ((prefix-arg prefixarg))
>> + (let ((current-prefix-arg prefixarg))
>> (command-execute function 'record))
next prev parent reply other threads:[~2020-01-30 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 3:35 bug#39353: [PATCH] Use current-prefix-arg instead of prefix-arg Kyle Hubert
2020-01-30 3:53 ` Kyle Hubert
2020-01-30 13:12 ` Noam Postavsky [this message]
2020-01-30 16:35 ` Kyle Hubert
2020-01-30 18:39 ` Eli Zaretskii
2020-01-31 14:29 ` bug#39353: [PATCH] Ediff fix for ediff-scroll-horizontally Kyle Hubert
2020-02-08 10:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1zhay10.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=39353@debbugs.gnu.org \
--cc=khubert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).