From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#35546: 27.0.50; setf return value for new alist entries is wrong Date: Mon, 13 Apr 2020 03:01:53 +0200 Message-ID: <87r1wstczi.fsf@web.de> References: <87lfznzm08.fsf@gnu.org> <87ftpqmrz9.fsf@web.de> <878svimlbz.fsf@web.de> <85zhnyxqey.fsf@gmail.com> <8736lqmf5p.fsf@web.de> <85woj2xl7l.fsf@gmail.com> <87blnwdh4j.fsf@gmail.com> <875ze451dl.fsf@gmail.com> <877dykdg6b.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="96362"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 35546@debbugs.gnu.org, Noam Postavsky , Tassilo Horn To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 13 03:03:04 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNnVA-000OzQ-5p for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Apr 2020 03:03:04 +0200 Original-Received: from localhost ([::1]:39230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNnV8-0000m7-Ji for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 21:03:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33994) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNnUD-0000lf-2l for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 21:02:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNnUB-00006Y-2b for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 21:02:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNnU9-00005K-Tb for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 21:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNnU9-0000Gj-Qd for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 21:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Apr 2020 01:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35546 X-GNU-PR-Package: emacs Original-Received: via spool by 35546-submit@debbugs.gnu.org id=B35546.15867397211030 (code B ref 35546); Mon, 13 Apr 2020 01:02:01 +0000 Original-Received: (at 35546) by debbugs.gnu.org; 13 Apr 2020 01:02:01 +0000 Original-Received: from localhost ([127.0.0.1]:59039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNnU9-0000GV-17 for submit@debbugs.gnu.org; Sun, 12 Apr 2020 21:02:01 -0400 Original-Received: from mout.web.de ([217.72.192.78]:56215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNnU7-0000GF-HU for 35546@debbugs.gnu.org; Sun, 12 Apr 2020 21:02:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1586739712; bh=qh0qmIZBFysKQc98Xno5DueEpd6Kik4iRlv7HqdLbuE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=dkdRMx21EDVlwgbkbEBbLjgmtqYHVzbsZYEtUpTtgljdsG8L3bR5YpVEbSShhTPUE xT0V1aUCJ56L4b54RnHn8uxeJUZSlrLV9bYXn7SsMr3JgkQhT3GMT4tCzSAgtgXYou MNcqRb45uH6KaBjkCN7YPgtuVAvODri5L+GTcXnw= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([188.98.99.7]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MbhNZ-1jgICg38oX-00J134; Mon, 13 Apr 2020 03:01:51 +0200 In-Reply-To: <877dykdg6b.fsf@gmail.com> ("=?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?="'s message of "Sun, 12 Apr 2020 14:47:24 +0200") X-Provags-ID: V03:K1:bNGU2eDvuz8IC1O/PQ7TJz6GyPa8fhT1UP86kiq9565GGgSN77D 63pAoNeeqro6A1THfmvXOoid8AYot5SPyYbObpMfWQAw+Iy8u7KsaqILcopMLepbloZco1f +WKYQPClKgioOSEgHpFqkMipeBAdvQKturwh1g6ldaO4tO6Tnxgl47fTBatsZdS6rBvtoe1 AxSO5MdDvhhtsEJSqwNdw== X-UI-Out-Filterresults: notjunk:1;V03:K0:RGL0AqkOWCg=:fZRVF4+OheRATa9okbrEPY T24llP0ukVf7a4pHPfV0AbTGf+GOA112J6lh1PRxZ76WKCL6ZKpkQ6BiNsRsBElmaZBU/jYeb GYq0e9fTFrQ92rXN0YMmSFNH74L9OgTbGLCj6N0mvoimwftnpVdxMtGB1cGk254kuz4WMA784 Pddbjdt2ujoZbcQifh8P6pIJZchDlkhYipJZCIn+lQbA/ZUCuQFGOitNZhOBZFjGd4AVpgQGO G/a1eJwQ00vFnPyJMUNvcb92MrX7KMI9yi8J68hg0O8UH2FzRnsz1soz7vl1OjQnpgQvTlc9t iD/4w2ICd3HpPPe/1OuNgPhJo0pA4E6rxT+TZHk7RefSGXqPkXgMUivG+sBmgV+vprW0wBB09 wGfiUKQv9jS4tsJ+nNi8fxVRrWeA84siZWfM5lDdwUxsRTiw1PfIUO0QMPu/GKfT/9ZLrVa6m 9908L5HliNc6bWOJkoruWFgIRtYJTblmBOLcwccqGls+6a5N8pR7Ah/E/2SJOz9MEMKDjgM7c 6vumuvat1Pq/zZyhq40ju0kqCNa8uRxBer2bgHuPALGKLThxzhhlYgJC6F5lCudEo0WYrAj/s uJq7zlT9SV/nsdToSXTsOxTWiedxtZdD3TTkteok7Y5U7B00IFMj+MrRVmqfErUg0FVSdNAzh LchISoMIkvrCiNY9lrv/4FaYscbOXKvj0JEjHcS+c4wkW61d/6NqHpUySAJwPPVV9uucGXg49 6/VjOPB5/14T7bhDFPDjE+tQ6arjbg/Bl3F18Cg+sjEYWWKpEORVR670R13JBNUSUfEvOsWn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178284 Archived-At: =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec writes: > >> (lambda (v) > >> + (macroexp-let2 nil v v > > > > Binding v to the value of v seems needlessly confusing. How about > > renaming the lambda parameter to valexp or somthing like that? > > I kind of agree, although really, I wish that would be the most > confusing part about gv.el. :-] > > I did it like that because 1. this practice seems pretty common in Emacs > sources already, 2. it makes for the minimal change here. It's a matter of taste. I read it like that `macroexp-let2' arranges that the expression v refers to is evaluated only once, but not anything else (if used correctly), so keeping the name is not more confusing than torturing the reader with one more variable to remember in that already not so easy to read code. Apart from that debatable point the change looks reasonable to me. Thanks, Michael.