From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#40951: Weird highlighting Date: Fri, 01 May 2020 20:44:13 +0200 Message-ID: <87r1w3o5qa.fsf@gmail.com> References: <87imhj6rl6.8.fsf@jidanni.org> <87tv12ohvr.fsf@gmail.com> <87368m6v1a.8.fsf@jidanni.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="30248"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40951@debbugs.gnu.org To: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 01 20:46:00 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUafg-0007l3-9O for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 May 2020 20:46:00 +0200 Original-Received: from localhost ([::1]:48300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUaff-000407-BS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 May 2020 14:45:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUael-0003Js-Hl for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 14:45:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUaek-0003hf-Tw for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 14:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39095) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUaek-0003g4-Fb for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 14:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jUaek-0001L2-Bz; Fri, 01 May 2020 14:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 01 May 2020 18:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40951 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 40951-submit@debbugs.gnu.org id=B40951.15883586645080 (code B ref 40951); Fri, 01 May 2020 18:45:02 +0000 Original-Received: (at 40951) by debbugs.gnu.org; 1 May 2020 18:44:24 +0000 Original-Received: from localhost ([127.0.0.1]:50640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUae7-0001Js-Qa for submit@debbugs.gnu.org; Fri, 01 May 2020 14:44:24 -0400 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:51591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUae5-0001JZ-G7 for 40951@debbugs.gnu.org; Fri, 01 May 2020 14:44:22 -0400 Original-Received: by mail-wm1-f47.google.com with SMTP id x4so608836wmj.1 for <40951@debbugs.gnu.org>; Fri, 01 May 2020 11:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=jyEHbTu/EGLuHbcfT1U46MhUD6sM7iIotvmIJKXevaM=; b=pUCb/mrNuH3NDc0tVJ8XzZublS5HT6W8R1bzzBNCPbqClXM7jrGhI+F+WCC/Cxmk27 aYJNEvHbeFbnmuxmhs2OUA5vsr29oZixIKxehH+qKAF3VIxezlEvHzCxE10tZW+aQq60 gt5oxaS4rB5kJg286pOSIwisGGCWKxL0ayYTPJ0j/nW8O7Sfp5LiSo+vcmdr81GIxqi9 Zi7O8aDt3T4DO8SPTOjrT0X+GRs5iloF+iGY1MWuPgoMeD6pn6fXZktggvWIrBo8eYy4 PRk4zAeoR5050sPjSQEdhG5+CZH9t6hjQD45gk2blP4gI7Y3SMf2M62gsEbB/IlijvRP H+SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=jyEHbTu/EGLuHbcfT1U46MhUD6sM7iIotvmIJKXevaM=; b=f6p5VmQOKGy5x9sajJcDT0i+bTW5juXlXwiftdLgP+b6SPFv1OrdUexfWfOKa/qNtx fi1buB8zPmE0SW+kW16Nxa7LxtmAuKM1rhQWllK8P+OxGLcqE7XsK15OXEKu7qjLuFPF /o27HqLf2l/cQxSIRI0wpOVz/ejDIYpJl5un6ViQSnhugNPIlqHsO8lGmJdtB62DxsQV hzSyFYDdaX0hkM46NV/rN5TPtes89gjq1wJaHvehNvTPGbyrrsn9gOol5KhTo8RCG8rn vaMKtYJtiPz4eyRgxJPNz6CWuMHMSayXuOYpPGuQBcUELk6+bEKUcx2lqfoFT4RvZqAn n0bQ== X-Gm-Message-State: AGi0PuaM7xoIzVuk86Ny51Px7JibypWkx1AHESnARBzlDVF7gHal/WEL R/qFCVpvi3OVshZtEIB0dwkzc3XTTcc= X-Google-Smtp-Source: APiQypI6gnFegJFkCb6uaAgnqObtbUkm1bflppeMRLfW10xARpLdfV7B2BBP3OQjUi5WiSHrd++gTA== X-Received: by 2002:a1c:ac44:: with SMTP id v65mr830739wme.33.1588358655105; Fri, 01 May 2020 11:44:15 -0700 (PDT) Original-Received: from my-little-tumbleweed (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id j17sm5839686wrb.46.2020.05.01.11.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2020 11:44:14 -0700 (PDT) In-Reply-To: <87368m6v1a.8.fsf@jidanni.org> ("=?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson"'s message of "Thu, 30 Apr 2020 01:50:25 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179452 Archived-At: =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson writes: >>>>>> "KLG" =3D=3D K=C3=A9vin Le Gouguec write= s: > KLG> =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson write= s: > > KLG> on the other hand I don't see how Gnus could distinguish between a > KLG> verb added deliberately by the article author, and the same verb > KLG> added automatically as part of the mail client's citation > KLG> boilerplate. > > Hmmm, well don't boilerplates have some @ and/or < and > etc. in them? If we focus solely on Gnus's message.el, message-insert-citation-line can be relied on to use whatever was in the "From" header. From what I gather from RFC 5322, that should at least include an "@" sign. That only covers Gnus's "writes:" though. Spelunking in lisp/gnus for other verbs featured in gnus-cite-attribution-suffix, I get the impression that other MUAs tend to follow suit, but that might be wishful thinking. Assuming false negatives (failing to highlight) on articles from "non-conforming" MUAs are less annoying than false positives (highlighting part of a line that's not introducing a citation) on "conforming" ones, I'm still not sure where the right "fix" would belong. gnus-cite-attribution-suffix's job is to match just the final verb before the citation, so I think it's fine the way it is. There's probably a way to teach gnus-article-highlight-citation that it shouldn't apply gnus-cite-attribution-face to the whole line, but I'm not familiar enough with the code to see how to go about it.