From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#40351: Flymake error count Date: Tue, 12 May 2020 19:30:14 +0100 Message-ID: <87r1vpatvt.fsf@gmail.com> References: <2ICKUTXGCUO0W.3GVX8GSQ0BRIC@handheld.hackware.cl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="66987"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: 40351@debbugs.gnu.org To: sir@hacktivista.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 12 20:34:03 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYZj8-000HJ5-AM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 May 2020 20:34:02 +0200 Original-Received: from localhost ([::1]:53114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYZj7-0000pl-4k for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 May 2020 14:34:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYZgE-0006ra-Au for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 14:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44956) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYZgD-0000Ct-TF for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 14:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYZgD-0003fD-OE for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 14:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 May 2020 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40351 X-GNU-PR-Package: emacs Original-Received: via spool by 40351-submit@debbugs.gnu.org id=B40351.158930822714024 (code B ref 40351); Tue, 12 May 2020 18:31:01 +0000 Original-Received: (at 40351) by debbugs.gnu.org; 12 May 2020 18:30:27 +0000 Original-Received: from localhost ([127.0.0.1]:56502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYZfe-0003e8-RX for submit@debbugs.gnu.org; Tue, 12 May 2020 14:30:27 -0400 Original-Received: from mail-wr1-f51.google.com ([209.85.221.51]:43159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYZfb-0003dq-KM for 40351@debbugs.gnu.org; Tue, 12 May 2020 14:30:25 -0400 Original-Received: by mail-wr1-f51.google.com with SMTP id i15so16866272wrx.10 for <40351@debbugs.gnu.org>; Tue, 12 May 2020 11:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=E0UymDNuCmaCoIcjZ6Nw5cZ7R4l4IHdYZPOyGA2eHX4=; b=ZUOiqwg/bjirr6kvkcJl9v+YiJ50PWRhE9leAN8wLsV2B4KPHZGKEejc6BzhBtdsWj tswz5UIKprORZGo/GsTQFSSMris8cBfRdGVIkpFjDJKn0ld/F6fPOcuqxT4eR4LpyADz odUE5DMOvsK5N6eGTho9UKw+GOvYulchBsS44is3K8K6Lq+zW76YvPbBULd5b6Ar79bM m3vwp6Mnk8oicDtomQMTYJdvJnplMLSGcaPITq+AJRVMfY9rLS+gNvVRPEw/uB+XDwGO clIEI3yCCgMkEPGhkBPDLgujeTKxULp7LjdlEx4D1h7XMfBmaQODCMRQvlRFo9SgwLlD cWmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=E0UymDNuCmaCoIcjZ6Nw5cZ7R4l4IHdYZPOyGA2eHX4=; b=SixnDImf3UmkA/t6N4hM8wT9uqoUXm82W84X9L0xG0BeWSPHktwcqBt9VUpq5sadoD bJFr0BLZNiX9Qrh5i+rhh6/i9IFG/mkWRk0pXEoQle6kBWuvNiVMHJVOZgSWmljH+u9O Gqd3m7lP9XgJz/rqe9pNFEWZFb/GcoiLadN1/mIZ1VUPTtEih1SCeQSp+TQxAsEFeaoH d2K4SP5MCPVFkody2KTV+/O+KDQX8jf1AnbJwtEB8Bxl+jHDDBWqZ0frQcv4qxTRbYPX LYubt5JYuOFmj//t86jqWTNWDq4PQPt6X0h481DwfzLrhJK1QZ74rtRurKLInbE/qLMd C5cQ== X-Gm-Message-State: AGi0PuadLx3b2YA/HYQkEjTcM6roPisR3CclgcO4ya/8tPNHCkuou4RI 36lUrg9ltdD6zzGjDrEOrQiNTDnG+Nw= X-Google-Smtp-Source: APiQypJ8Lst6vjge9E7s0um7Pss5HYj3pc+D4pMj9wgb+AwbL5lMut1VgL97ofJrHmyZlk1hETa8Pw== X-Received: by 2002:a5d:54c4:: with SMTP id x4mr28040474wrv.73.1589308217289; Tue, 12 May 2020 11:30:17 -0700 (PDT) Original-Received: from krug ([2001:818:d820:9500:824a:171:15a:2213]) by smtp.gmail.com with ESMTPSA id w15sm22922815wrl.73.2020.05.12.11.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 11:30:16 -0700 (PDT) In-Reply-To: <2ICKUTXGCUO0W.3GVX8GSQ0BRIC@handheld.hackware.cl> (sir@hacktivista.com's message of "Tue, 31 Mar 2020 07:21:54 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180116 Archived-At: Hello, sir@hacktivista.com: I'm sorry for the very long delay in answering this. Next time you report a bug for flymake, make sure you also forward me the message that the bug reporting system sends back to you. (yes I know you had written me separately). Anyway, to your problem: > for (beg . end) =3D (flymake-diag-region source ln= um) > for type =3D (make-symbol (match-string 3)) ^^^^^^^^^^^ I think the problem you experience is found here. TYPE cannot be a different symbol for each error you find, otherwise Flymake will think that each error has its unique type. If `(match-string 3)` is indeed often enough the same string, you can try `intern` instead. Let's say (match-string 3) can only return "oops", "warn" or "info" I would= write that line like for type =3D (intern (format "flymake-phpcs--%s" (match-string 3))) Then separately I would write in a top-level-form (put 'flymake-phpcs--oops 'flymake-category 'flymake-error) (put 'flymake-phpcs--warn 'flymake-category 'flymake-warning) (put 'flymake-phpcs--info 'flymake-category 'flymake-note) Then the errors would be merged with the errors from Eglot, I think. See the manual section 2.1 Customizing Flymake error types I see the the docstring for `flymake-make-diagnostic` could see some improvement. In particular, the phrase "TYPE is a key to symbol" doesnt' make much sense. Jo=C3=A3o