From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 39502@debbugs.gnu.org, Wolfgang.Scherer@gmx.de
Subject: bug#39502: [PATCH] Use one src status -a call for vc-src-dir-status-files
Date: Sun, 09 Aug 2020 21:50:22 +0200 [thread overview]
Message-ID: <87r1sfa9a9.fsf@gnus.org> (raw)
In-Reply-To: <a18d3a29-c810-2136-1753-273b5947854d@yandex.ru> (Dmitry Gutov's message of "Sun, 9 Aug 2020 20:42:37 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 09.08.2020 17:13, Eli Zaretskii wrote:
>> I tried, but couldn't (for boring reasons unrelated to the patch). I
>> don't want to block the changes, so it's okay to install them,
>> provided that Dmitry agrees.
>
> Now that I've read the code more in-depth, this part looks somewhat
> objectionable:
>
> + ;; Ignore all errors.
> + (condition-case nil
>
> But since the patch only affects SRC (and I don't know why would
> anybody use it), I'm happy to leave the decision to others.
Well, it's a bit unfortunate to apply a patch that we haven't tested,
but I've now done so anyway. I did make some white space and stylistic
changes before applying it, though -- Wolfgang, can you check whether I
messed something up there?
But I've pushed the change to Emacs 28.1 (i.e., the Emacs trunk).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-08-09 19:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 22:52 bug#39502: [PATCH] Use one src status -a call for vc-src-dir-status-files Wolfgang Scherer
[not found] ` <handler.39502.B.158111597418374.ack@debbugs.gnu.org>
2020-02-08 5:35 ` bug#39502: Acknowledgement ([PATCH] Use one src status -a call for vc-src-dir-status-files) Wolfgang Scherer
2020-02-08 9:39 ` bug#39502: [PATCH] Use one src status -a call for vc-src-dir-status-files Dmitry Gutov
2020-02-10 0:47 ` Wolfgang Scherer
2020-02-10 4:29 ` Dmitry Gutov
2020-02-11 2:54 ` Wolfgang Scherer
2020-02-11 7:46 ` Dmitry Gutov
2020-02-14 10:05 ` Eli Zaretskii
2020-02-15 2:44 ` Wolfgang Scherer
2020-08-09 11:31 ` Lars Ingebrigtsen
2020-08-09 14:13 ` Eli Zaretskii
2020-08-09 17:42 ` Dmitry Gutov
2020-08-09 19:50 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1sfa9a9.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=39502@debbugs.gnu.org \
--cc=Wolfgang.Scherer@gmx.de \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).