From: Lars Ingebrigtsen <larsi@gnus.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: 32243@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#32243: 26.1; eldoc takes priority over flymake-diagnostics
Date: Sat, 22 Aug 2020 17:03:05 +0200 [thread overview]
Message-ID: <87r1ryk9jq.fsf@gnus.org> (raw)
In-Reply-To: <CALDnm50Pzo7HROUt+nN=x34-7F+jwRQZjp40pnctYnyH7QWF3g@mail.gmail.com> ("João Távora"'s message of "Sun, 19 Aug 2018 19:48:22 +0100")
João Távora <joaotavora@gmail.com> writes:
> A naive fix for this could be
[...]
> which imitates what help-at-pt-maybe-display-does.
>
> It seems to work more or less well in my testing, but not always. Obviously
> I haven't studied the full impact of this.
>
> Dmitry, do you have any thoughts on this?
This was two years ago. I've respun the patch; included below.
Is this something that should be applied or not?
diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el
index 4825b5c5e6..0bcd04f84a 100644
--- a/lisp/emacs-lisp/eldoc.el
+++ b/lisp/emacs-lisp/eldoc.el
@@ -300,7 +300,9 @@ eldoc-minibuffer-message
(when (stringp format-string)
(apply #'format-message format-string args)))
(force-mode-line-update)))
- (apply #'message format-string args)))
+ (unless (and (current-message)
+ (not (string= (current-message) "Quit")))
+ (apply #'message format-string args))))
(make-obsolete
'eldoc-message "use `eldoc-documentation-functions' instead." "eldoc-1.1.0")
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-22 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 19:22 bug#32243: 26.1; eldoc takes priority over flymake-diagnostics James Nguyen
2018-08-19 18:48 ` João Távora
2020-08-22 15:03 ` Lars Ingebrigtsen [this message]
2020-08-22 16:05 ` João Távora
2020-08-22 16:20 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1ryk9jq.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=32243@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).