unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Kangas <stefan@marxist.se>, 39898@debbugs.gnu.org
Subject: bug#39898: 28.0.50; The off-by-one bug in `flyspell-check-previous-highlighted-word'
Date: Fri, 28 Aug 2020 16:02:59 +0900	[thread overview]
Message-ID: <87r1rrqml8.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <831rjr1fg9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Aug 2020 08:56:22 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Stefan Kangas <stefan@marxist.se>
>> Date: Thu, 27 Aug 2020 12:37:45 -0700
>> Cc: 39898@debbugs.gnu.org
>> 
>> Indeed, this just looks like an OBOE to me.
>
> Does it?  The doc string of flyspell-check-previous-highlighted-word
> says:
>
>   Correct the closest previous word that is highlighted as misspelled.
>   This function scans for a word which starts before point that has been
> 			    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   highlighted by Flyspell as misspelled.
>
> The test case, AFAIU, creates a situation where the misspelled word
> starts _after_ point (remember that point is a place between 2
> characters, and its value is the character following point).  So I
> don't see a bug here.  Am I missing something?

(with-temp-buffer
  (select-window (display-buffer (current-buffer)))
  (insert "appl")
  (insert "   ")
  (flyspell-buffer)
  (flyspell-check-previous-highlighted-word))

Then, this point is before, and should work? This also calls
(error "No word...").

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>





  reply	other threads:[~2020-08-28  7:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 10:07 bug#39898: 28.0.50; The off-by-one bug in `flyspell-check-previous-highlighted-word' OGAWA Hirofumi
2020-08-27 19:37 ` Stefan Kangas
2020-08-28  5:56   ` Eli Zaretskii
2020-08-28  7:02     ` OGAWA Hirofumi [this message]
2020-08-28 10:49       ` Eli Zaretskii
2020-08-28 11:27         ` Stefan Kangas
2020-08-28 11:30           ` Eli Zaretskii
2020-09-02 15:40             ` Stefan Kangas
2020-08-28  9:52     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1rrqml8.fsf@mail.parknet.co.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=39898@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).