From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#23590: 25.0.94; Errors in default lgrep command Date: Fri, 04 Sep 2020 16:09:52 +0200 Message-ID: <87r1rh8wgf.fsf@gnus.org> References: <87futcp8wp.fsf@gmail.com> <83fur0x0ft.fsf@gnu.org> <87fur0clhm.fsf@gmail.com> <83a8h8utdm.fsf@gnu.org> <838twsuskk.fsf@gnu.org> <87twfg0zrs.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24377"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: john.b.mastro@gmail.com, 23590@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 04 16:11:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kECQn-0006DP-Dz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 16:11:09 +0200 Original-Received: from localhost ([::1]:46182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kECQm-0006K2-GL for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 10:11:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kECQg-0006JX-4o for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 10:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kECQf-0001V3-S8 for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 10:11:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kECQf-000382-Lf for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 10:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Sep 2020 14:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23590 X-GNU-PR-Package: emacs Original-Received: via spool by 23590-submit@debbugs.gnu.org id=B23590.159922860511940 (code B ref 23590); Fri, 04 Sep 2020 14:11:01 +0000 Original-Received: (at 23590) by debbugs.gnu.org; 4 Sep 2020 14:10:05 +0000 Original-Received: from localhost ([127.0.0.1]:40238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kECPl-00036V-1R for submit@debbugs.gnu.org; Fri, 04 Sep 2020 10:10:05 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:49618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kECPi-00035w-V4 for 23590@debbugs.gnu.org; Fri, 04 Sep 2020 10:10:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OxWgCAEqa+XrgCfHaVHehfOkaB0c5CUq5WhQjhocO2Q=; b=qqSRiEnY9xKrvj1UwQ6AiLzSUg R5Ha1JeLCetAmLg75M36oQjH3CggiTTQrXti6lPltzeH66raZQFOKdn3rudSmkzdEXPKWHzISpXzt BC4HuBnbpRYXd5fz6eVySLDhdeTIWyWqT7fkB1P4b88/hCyLoduT37tGYZnZEyb8zOos=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kECPa-0001EC-6e; Fri, 04 Sep 2020 16:09:56 +0200 X-Now-Playing: Various's _1-8 Split Series_: "Ad Vanz, Gescom - Viral" In-Reply-To: <87twfg0zrs.fsf@gmail.com> (Alex's message of "Sat, 23 Jul 2016 16:12:55 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187142 Archived-At: Alex writes: >> Actually, I see that "Is a directory" also caused exit code of 2. So >> I guess patches are welcome to add --directory=skip to the Grep >> command when a preliminary test reveals that Grep supports it. > > Is the following patch acceptable? There was discussion here before the patch was posted, but then no follow-up. I've respun the patch for Emacs 28 -- does anybody have any comments? diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el index c71a90344f..17f0422ac7 100644 --- a/lisp/progmodes/grep.el +++ b/lisp/progmodes/grep.el @@ -696,10 +696,15 @@ grep-compute-defaults (let ((grep-options (concat (if grep-use-null-device "-n" "-nH") (if grep-use-null-filename-separator " --null") - (if (grep-probe grep-program - `(nil nil nil "-e" "foo" ,null-device) - nil 1) - " -e")))) + (when (grep-probe grep-program + `(nil nil nil "--directories=skip" "foo" + ,null-device) + nil 1) + " --directories=skip") + (when (grep-probe grep-program + `(nil nil nil "-e" "foo" ,null-device) + nil 1) + " -e")))) (unless grep-command (setq grep-command (format "%s %s %s " grep-program -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no