From: Lars Ingebrigtsen <larsi@gnus.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 43307@debbugs.gnu.org
Subject: bug#43307: 28.0.50; `diff-no-select': no documentation for BUF argument
Date: Thu, 10 Sep 2020 23:04:14 +0200 [thread overview]
Message-ID: <87r1r94a41.fsf@gnus.org> (raw)
In-Reply-To: <wvr48sdhpx62.fsf@phst-desktop.muc.corp.google.com> (Philipp Stephani's message of "Thu, 10 Sep 2020 15:40:37 +0200")
Philipp Stephani <p.stephani2@gmail.com> writes:
> The signature for `diff-no-select' is:
>
> (diff-no-select OLD NEW &optional SWITCHES NO-ASYNC BUF)
>
> Its docstring refers to `diff' for the meaning of the arguments, but
> `diff' doesn't take an argument, so BUF is undocumented.
>
> Probably `diff-no-select' should also document that the return value is
> BUF if BUF is non-nil.
I've now amended the doc string of the function on Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-09-10 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 13:40 bug#43307: 28.0.50; `diff-no-select': no documentation for BUF argument Philipp Stephani
2020-09-10 21:04 ` Lars Ingebrigtsen [this message]
2020-09-11 6:07 ` Eli Zaretskii
2020-09-11 12:27 ` Lars Ingebrigtsen
2020-09-11 12:37 ` Eli Zaretskii
2020-09-11 12:40 ` Lars Ingebrigtsen
2020-09-11 12:48 ` Eli Zaretskii
2020-09-12 11:09 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1r94a41.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=43307@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).