unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 20742@debbugs.gnu.org, 20560@debbugs.gnu.org,
	Tommi Komulainen <tommi.komulainen@iki.fi>
Subject: bug#20560: bug#20742: 24.5; [PATCH] python.el: fix close paren indentation to match pep8
Date: Thu, 17 Sep 2020 20:59:01 +0200	[thread overview]
Message-ID: <87r1r0kz62.fsf@gnus.org> (raw)
In-Reply-To: <87sguctn78.fsf@gmail.com> (Noam Postavsky's message of "Sat, 20 Apr 2019 16:51:23 -0400")

Noam Postavsky <npostavs@gmail.com> writes:

> I managed to get this applied; I've replaced the python-test.el
> modifications, partly because they're written as updates to the existing
> tests which makes them a bit harder to follow, and partly to make more
> clear that the patch is below the 15 line copyright limit.
>
> I'll push to master in a week or so if there are no further comments.

Looks like this was done, so I'm closing this bug report.

commit 3fc1d77a43818666542740fc34167c1faee30d5f
Author:     Tommi Komulainen <tommi.komulainen@iki.fi>
AuthorDate: Fri Jun 19 18:53:52 2015 +0200
Commit:     Noam Postavsky <npostavs@gmail.com>
CommitDate: Sun Apr 28 16:45:13 2019 -0400

    python.el: Fix close paren indentation to match pep8 (Bug#20742)
    
    * lisp/progmodes/python.el (python-indent--calculate-indentation):
    When opening paren is followed by newline the closing paren should
    follow the current indentation.  Otherwise the closing paren should be
    aligned with the opening paren.  This fixes the latter case.


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2020-09-17 18:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  7:58 bug#20742: 24.5; python mode indentation fails pep8 Tommi Komulainen
2015-06-05 20:16 ` Glenn Morris
2015-06-05 20:25   ` Tommi Komulainen
2015-06-08 16:28 ` Andreas Röhler
2015-06-19 17:04 ` bug#20742: Testcase for #20742 Tommi Komulainen
2015-06-20 10:56 ` bug#20742: 24.5; [PATCH] python.el: fix close paren indentation to match pep8 Tommi Komulainen
2017-03-02  2:47   ` npostavs
2019-04-20 20:51     ` Noam Postavsky
2019-04-28 20:47       ` Noam Postavsky
2020-09-17 18:59       ` Lars Ingebrigtsen [this message]
2020-09-17 19:22         ` bug#20560: " Noam Postavsky
2020-09-18 11:11           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1r0kz62.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=20560@debbugs.gnu.org \
    --cc=20742@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    --cc=tommi.komulainen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).