From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43645: 26.3; emacsclient -c does not open to correct window Date: Mon, 28 Sep 2020 15:16:16 +0200 Message-ID: <87r1qmujmn.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5582"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43645@debbugs.gnu.org To: Blue track Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 28 15:29:08 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMtDI-0001Jr-9e for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Sep 2020 15:29:08 +0200 Original-Received: from localhost ([::1]:48840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMtDH-0002t6-9J for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Sep 2020 09:29:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMt1a-0005Fg-Fa for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 09:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40351) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMt1Z-0002Xz-Sl for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 09:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kMt1Z-0003F5-Nv for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 09:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Sep 2020 13:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43645 X-GNU-PR-Package: emacs Original-Received: via spool by 43645-submit@debbugs.gnu.org id=B43645.160129899912434 (code B ref 43645); Mon, 28 Sep 2020 13:17:01 +0000 Original-Received: (at 43645) by debbugs.gnu.org; 28 Sep 2020 13:16:39 +0000 Original-Received: from localhost ([127.0.0.1]:51897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMt1D-0003EU-14 for submit@debbugs.gnu.org; Mon, 28 Sep 2020 09:16:39 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:49424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMt1B-0003EH-9C for 43645@debbugs.gnu.org; Mon, 28 Sep 2020 09:16:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BK01KKsFFWSjElfYvp+WQND3B5hi/lcG7p8/98IoKk0=; b=mjFyxFnMj6bMxhUsX5mcYKlvco Rz8zMcDXJjd2IcBLQ1KlBfxjolVx9KZT0750bqx3YdWf7jRxDlIbB6FnDrwR8abR7sIgds5vf2+Zu z+D6ujIGhpC5+iBlIAK9muyMIVUd1TbxaoeEweXLUXLJOaxXJt3LURkvPQgmQ3bpTjpw=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMt0s-0007QC-6Z; Mon, 28 Sep 2020 15:16:30 +0200 X-Now-Playing: Neneh Cherry & The Thing's _The Cherry Thing_: "Too Tough To Die" In-Reply-To: (Blue track's message of "Sun, 27 Sep 2020 16:41:31 +1000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189196 Archived-At: This patch fixes the problem, but I'm hesitating to apply it even if it looks kinda-sorta "obviously correct": It changes the logic to only check whether the buffer is displayed in the current frame, which makes emacsclient -c work. But why was the all-frame argument added? It's been there since at least the 90s... I can't see any adverse affects on emacsclient -t either. Anybody with any insight here? diff --git a/lisp/server.el b/lisp/server.el index 436a6ca0c7..f24f8d2b7c 100644 --- a/lisp/server.el +++ b/lisp/server.el @@ -1602,7 +1602,7 @@ server-switch-buffer ;; OK, we know next-buffer is live, let's display and select it. (if (functionp server-window) (funcall server-window next-buffer) - (let ((win (get-buffer-window next-buffer 0))) + (let ((win (get-buffer-window next-buffer))) (if (and win (not server-window)) ;; The buffer is already displayed: just reuse the ;; window. If FILEPOS is non-nil, use it to replace the -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no