From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43891: 26.3; Wrong background-mode on gnome-terminal 3.38 Date: Thu, 15 Oct 2020 17:27:55 +0200 Message-ID: <87r1pzv79g.fsf@gnus.org> References: <875z7j9jfr.fsf@p50> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12836"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43891@debbugs.gnu.org, Noam Postavsky To: semente Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 15 17:35:05 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kT5HV-0003Bo-DJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Oct 2020 17:35:05 +0200 Original-Received: from localhost ([::1]:39572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kT5HU-00044E-E6 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Oct 2020 11:35:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kT5Be-0006g2-Ec for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 11:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kT5Bd-0006nN-M5 for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 11:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kT5Bd-0007AT-JB for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 11:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Oct 2020 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43891 X-GNU-PR-Package: emacs Original-Received: via spool by 43891-submit@debbugs.gnu.org id=B43891.160277569727490 (code B ref 43891); Thu, 15 Oct 2020 15:29:01 +0000 Original-Received: (at 43891) by debbugs.gnu.org; 15 Oct 2020 15:28:17 +0000 Original-Received: from localhost ([127.0.0.1]:56242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT5Au-00079J-J3 for submit@debbugs.gnu.org; Thu, 15 Oct 2020 11:28:17 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:44370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT5As-000795-Jd for 43891@debbugs.gnu.org; Thu, 15 Oct 2020 11:28:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oWyNPgY+r2tUAUteiG8e3qNSihkn98g34op2h2sJGIk=; b=N4K0NP01WdHL1y/y5hEKNaQ3Od dV5s20UFbHlQBvQz+KoqGknZ50QOBgAoLxHiZdtBmSOhVuYz6yyRv08snhU0gpcGqnE0lVhhvzl/m X+WOkPpjpr1ARxgSeD160qEGeisvxf+OkH4OlXqr5Fmonwbbx2UB4sdP9Kx4HKAvHlnI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kT5Ab-0005lL-Kr; Thu, 15 Oct 2020 17:28:08 +0200 X-Now-Playing: Oval's _Popp_: "lo" In-Reply-To: <875z7j9jfr.fsf@p50> (semente@riseup.net's message of "Fri, 09 Oct 2020 18:30:00 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190600 Archived-At: semente writes: > This is the same bug reported in #29716[1], which was fixed for > gnome-terminal 3.22. A solution made by Noam Postavsky is found on > #29716 as well. Perhaps there is a way to fix this definetely for > gnome-terminal, I believe it affects many users. In gnome-terminal 3.38, the version string in xterm--version-handler is: "65;6200;1" So, just hacking blindly without any clue what this is, the following patch fixes the issue for me. Does anybody know whether this makes sense or not? diff --git a/lisp/term/xterm.el b/lisp/term/xterm.el index 1a727e3933..6f5fa7518b 100644 --- a/lisp/term/xterm.el +++ b/lisp/term/xterm.el @@ -710,15 +710,18 @@ xterm--version-handler (while (and (setq chr (xterm--read-event-for-query)) (not (equal chr ?c))) (setq str (concat str (string chr)))) ;; Since xterm-280, the terminal type (NUMBER1) is now 41 instead of 0. - (when (string-match "\\([0-9]+\\);\\([0-9]+\\);0" str) + (when (string-match "\\([0-9]+\\);\\([0-9]+\\);[01]" str) (let ((version (string-to-number (match-string 2 str)))) - (when (and (> version 2000) (equal (match-string 1 str) "1")) + (when (and (> version 2000) + (or (equal (match-string 1 str) "1") + (equal (match-string 1 str) "65"))) ;; Hack attack! bug#16988: gnome-terminal reports "1;NNNN;0" ;; with a large NNNN but is based on a rather old xterm code. ;; Gnome terminal 2.32.1 reports 1;2802;0 ;; Gnome terminal 3.6.1 reports 1;3406;0 ;; Gnome terminal 3.22.2 reports 1;4601;0 and *does* support ;; background color querying (Bug#29716). + ;; Gnome terminal 3.38.0 reports 65;6200;1. (when (> version 4000) (xterm--query "\e]11;?\e\\" '(("\e]11;" . xterm--report-background-handler)))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no