From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#44068: 28.0.50; Faulty uses of tabulated-list-format Date: Mon, 02 Nov 2020 00:07:34 +0100 Message-ID: <87r1pcu155.fsf@rub.de> References: <87imb7e242.fsf@gmx.net> <83zh4ipbli.fsf@gnu.org> <877drm13j3.fsf@gmx.net> <831rhuoy36.fsf@gnu.org> <87y2k2yqqb.fsf@gmx.net> <87h7qori97.fsf@gmx.net> <874kmcfy2h.fsf@rub.de> <875z6rmlrj.fsf@rub.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28687"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44068@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 02 00:08:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZMSH-0007MZ-L2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 00:08:09 +0100 Original-Received: from localhost ([::1]:39274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZMSG-0002OM-My for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 18:08:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZMSA-0002Nv-OT for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 18:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZMSA-0003dx-Fk for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 18:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZMSA-0000ns-Ad for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 18:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 23:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44068 X-GNU-PR-Package: emacs Original-Received: via spool by 44068-submit@debbugs.gnu.org id=B44068.16042720693070 (code B ref 44068); Sun, 01 Nov 2020 23:08:02 +0000 Original-Received: (at 44068) by debbugs.gnu.org; 1 Nov 2020 23:07:49 +0000 Original-Received: from localhost ([127.0.0.1]:38937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZMRx-0000nO-46 for submit@debbugs.gnu.org; Sun, 01 Nov 2020 18:07:49 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:58087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZMRv-0000nB-Ff for 44068@debbugs.gnu.org; Sun, 01 Nov 2020 18:07:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1604272060; bh=XypZLqxfHuX57uLDVsQwPrcG015QOahDjQAh6tIkQMM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=KPpGV+CKSMNKEMqeNaW0hbGu0y/E8UrBKVi2qTszsGu/EmDzMqfYv52IQ1GZVClhS O+6y8pFw9yIQSdfDKoODn7Toz9ytxuJedJV7Jd2RVgiz2WgZJ9/N+pBTKrhdomvoz3 GYGSB9Q6R0l5DB0NoZZwHH6hhqN7OuwVcQuF5wEc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-jhalfs ([188.109.202.128]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTiTt-1kwCmH1K8r-00U5Wk; Mon, 02 Nov 2020 00:07:40 +0100 In-Reply-To: (Stefan Kangas's message of "Fri, 30 Oct 2020 23:51:21 +0000") X-Provags-ID: V03:K1:+QEqC09aS73uRKGworyRvvELEIB0681oucWXlyPU6qe0OqyFDqr knTE0snBkqBEJAqKqk8gciUissSaZk7ANut64EwmMQ7JoSGYdfC/m67E49KX2VcBE4gNhQl HhOugbJroxso30aPTcYi8LlbfcVM54khh/oXsWGzqxllYFsXxI9y4aovkZDgZNKOPdQ7JJ8 MDa0rh335IWY8AShBOvRg== X-UI-Out-Filterresults: notjunk:1;V03:K0:nXGlxAlXsro=:qXp6qUSQYrHefM3BiZbRHq NLTaQwvXR4FT/q2it/sARfzj4v8VL7pw5K9PC7C01gLSvCT5aufAp0NM7pf9fDwGOSMOJ1fJ5 KBrCOEK12D85n6SmgintTZD4mP9QW9FP2vXhGOYSSqxVzrFFa3xyTXYNWKsGviFNbFNgv1QDG ua+nNcbrRqOjsQ2T5ZIURoB1dlNxCFjunbO+CCHVc9yIA1vF+13LF44MEiDJYip5b6w/uIkeY R09Sy1U16Cq68dJLUQp8IltV/h2QEUCt79bPjrW7DOca6Z94qXC3xiG8AYQaWX6ht+MmFKecL Cvip1/7aocJPdUdgVmgsY3PD+0mcmI3sSwr3ZlUhzesO8qRynt0Z+oeVCC7Si9xNpCaejLvKg PV835MT5JsfRuNnn/TAGXZg2aGfXZUdMqh9k9U6p48ko/I7DrH9BzolmSOHOyYLt8w5UYv8XO HIDWSljshVTEItFZXJ3iPsiFvuW6vns+aOvOpTNV3YKQE5SHREPOwAZFBMMFOyl+C5D0/T/go x2umgFPqlyGXnKXLCJtfh5LUf3s1t9yIkNRnA7WlDovK7w7/m4VdBwpDc0UQIsMbcH6RNgs8S L1AyDlzfo//zng4HcdRknI0y/QAdzQICZz5J6gsWez63fGf3qH3dbro/nXS6HTA33Vp6HL/DX bXeFalUXdfazGjFR/QkjtFIOTSTb0tMpS25B35wvgxFYCxgo6gGShwt69ubs4oZrSYPwFkwvm 7hcoG/Mq86//cP6PHilJN1RAEogp1hQq3gCkHCHNN9yJhb0Ztvqqp28Y9U7UEsvERGXB84jA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192487 Archived-At: On Fri, 30 Oct 2020 23:51:21 +0000 Stefan Kangas wrote: > Stephen Berman writes: > >> It seems to. I did experiment a bit with the width when I made the >> patch just for the selected column and thought the length I used there >> gave the best results, but maybe that was too cautious. Does this patch >> give better results (it differs from the previous one only in the >> lengths checked and used for truncating): > > I think this looks very good, yes. It works fully as I would expect, at > least: it seems to always correctly show the sorting indicator and the > ellipsis. > > (I tested using list-buffers, list-bookmarks, list-packages, > list-processes, list-dynamic-libraries, org-lint and > flymake-diagnostics-buffer-mode.) Thanks for testing. > Perhaps we could just go over the list above as you did in your first > patch and make sure that there is enough space for all of these to show > a sorting indicator without it touching the next column label. I'll try to do that soon, but feel free to beat me to it ;-) As an aside, do you think that use of the :right-align :pad-right properties in timer-list-mode in my first patch is a good change? >> It might be better to take more width parameters into account, as >> tabulated-list-print-col does, but that seems rather more complicated >> and I currently don't have time to pursue it. > > I imagine we can come back to and improve on this later. Sure. >> I wish I had more time for it but at the moment I don't. > > What you have here is already a big improvement, thank you. > > I would recommend to push this to master. Thanks. Eli, is that ok with you? Steve Berman