From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#44885: 28.0.50; [PATCH] ElDoc buffer mode and separator Date: Sun, 29 Nov 2020 13:02:25 +0000 Message-ID: <87r1ocl3j2.fsf@tcd.ie> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13850"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44885@debbugs.gnu.org, joaotavora@gmail.com To: Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 29 14:03:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjMML-0003Ub-NR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 14:03:21 +0100 Original-Received: from localhost ([::1]:34046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjMMK-0006Yh-Hc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 08:03:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjMM2-0006Lf-MX for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 08:03:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjMM2-00022X-En for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 08:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kjMM2-0007c6-C5 for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 08:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Nov 2020 13:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44885 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44885-submit@debbugs.gnu.org id=B44885.160665495529203 (code B ref 44885); Sun, 29 Nov 2020 13:03:02 +0000 Original-Received: (at 44885) by debbugs.gnu.org; 29 Nov 2020 13:02:35 +0000 Original-Received: from localhost ([127.0.0.1]:49991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjMLb-0007aw-5Y for submit@debbugs.gnu.org; Sun, 29 Nov 2020 08:02:35 -0500 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:40551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjMLZ-0007ak-UN for 44885@debbugs.gnu.org; Sun, 29 Nov 2020 08:02:34 -0500 Original-Received: by mail-wm1-f42.google.com with SMTP id a3so16953928wmb.5 for <44885@debbugs.gnu.org>; Sun, 29 Nov 2020 05:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uaSmQxhEGQaomVcff2KudU5jJwxmXXutYCL6O2V4b2w=; b=EH4H1zJlAP5F5XPMdw0eicW1AUh4luR+9ManbR4w+oQ1h7/RhQIly/fhsR7E+PF+hL hbfxObidj4+/mPQS3ToL6tg0ICJLXWmeeM+d0DYBwFLWhsWd7ZfVUoEcik3SLqCDdRBu AsluTgy4kAAikEQPrZkr8QOt43/WdfaOehQgfiby9ANcT8tDjaXIsYuIb3zzkWg7vf1H 9T2X3zvIhWU4U85W61etrp/Rd+v55M9McXtw3Tor2P4FVR1sZXnd81INSbg+AphN1FLl qgLOoaloyb0lVtUepyeBfs1dgVBJE014llVYzvpaaIA+Bg2C2MpITBpQ9SuG+e57f2F5 PG0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uaSmQxhEGQaomVcff2KudU5jJwxmXXutYCL6O2V4b2w=; b=MtlUaWTjwTUFj88wDmgHudeWgMHEBBTfxSXIfBrVhYDEcUoHjPqjdLNeo8h/qYwhF3 6/mUI10WrYTDhs3oZIyf+x1rqzJjHz7qb7VgemW5HRFYalPNj2WEGUKtgdIxDW+ESrvl 92Z+KA+JPpqhHj7jFaaKAMzN8HpMXdrOhuD1QKaXXfAYRqkNletUtQC6NVe2BeY5iMIK tKeQOWSb3npeugRs7Y0pBQWPMUk0hJLOMyPqi/wbD+dNqHG0boZNbgNriN4fYJGjpTjP N47A1PdXWNlBdW1wtsJp/7SMsAuZy823QZmFhasSVXpP2FTpD/2Njgm9WOMBH/RpqG3r 9/hQ== X-Gm-Message-State: AOAM532GNeZebIyiEbE1hTuFQTchPKacWYdjGMsqVatG8jRLH0Huss3Z bTkwy+SHzcQ4rnW3YcZVTtJdzg== X-Google-Smtp-Source: ABdhPJw9CogqgV+WoanhHBvYFKJGaX74zjEjzeBKKrOO1/TLZ1TWeSGxrzX8E9XkwrKqQ80TAa6FCQ== X-Received: by 2002:a1c:1f54:: with SMTP id f81mr15505333wmf.44.1606654948140; Sun, 29 Nov 2020 05:02:28 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id c81sm4450719wmd.6.2020.11.29.05.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Nov 2020 05:02:27 -0800 (PST) In-Reply-To: (Andrii Kolomoiets's message of "Thu, 26 Nov 2020 14:42:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194553 Archived-At: Andrii Kolomoiets writes: > * lisp/emacs-lisp/eldoc.el (eldoc-doc-buffer-separator): New option. Does this need calling out in etc/NEWS? > + (define-key map [?\S-\ ] 'scroll-down-command) Nit: please prefer '\s' over '\ '. > +(define-derived-mode eldoc-doc-mode fundamental-mode "ElDoc doc" > + "Major mode for ElDoc documentation buffer." If it's the major mode for the ElDoc buffer, why not call it eldoc-buffer-mode so as to avoid the repetition/ambiguity of "doc"? > + (setq buffer-read-only t)) > + > (defun eldoc--format-doc-buffer (docs) > "Ensure DOCS are displayed in an *eldoc* buffer." > (interactive (list t)) > @@ -472,12 +495,13 @@ eldoc--format-doc-buffer > eldoc--doc-buffer > (setq eldoc--doc-buffer > (get-buffer-create " *eldoc*"))) > + (unless (eq major-mode 'eldoc-doc-mode) Why not derived-mode-p? Thanks, -- Basil