From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45035: 28.0.50; Command completion annotations show minibuffer keybindings Date: Wed, 16 Dec 2020 23:27:48 +0200 Organization: LINKOV.NET Message-ID: <87r1nph25n.fsf@mail.linkov.net> References: <87k0ty2xnw.fsf@matem.unam.mx> <875z5gdkky.fsf@mail.linkov.net> <86pn3mpbxf.fsf@matem.unam.mx> <87wnxiqezv.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13077"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 45035@debbugs.gnu.org To: Omar =?UTF-8?Q?Antol=C3=ADn?= Camarena Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 16 22:29:33 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpeMX-0003Hu-74 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Dec 2020 22:29:33 +0100 Original-Received: from localhost ([::1]:59108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpeMW-0007PT-AE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Dec 2020 16:29:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpeM5-0007MV-RD for bug-gnu-emacs@gnu.org; Wed, 16 Dec 2020 16:29:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpeM1-0000gz-U6 for bug-gnu-emacs@gnu.org; Wed, 16 Dec 2020 16:29:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kpeM1-0004i4-RH for bug-gnu-emacs@gnu.org; Wed, 16 Dec 2020 16:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Dec 2020 21:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45035 X-GNU-PR-Package: emacs Original-Received: via spool by 45035-submit@debbugs.gnu.org id=B45035.160815413518084 (code B ref 45035); Wed, 16 Dec 2020 21:29:01 +0000 Original-Received: (at 45035) by debbugs.gnu.org; 16 Dec 2020 21:28:55 +0000 Original-Received: from localhost ([127.0.0.1]:34056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpeLv-0004hb-JB for submit@debbugs.gnu.org; Wed, 16 Dec 2020 16:28:55 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:55095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpeLp-0004gu-Nu; Wed, 16 Dec 2020 16:28:50 -0500 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 072EF240003; Wed, 16 Dec 2020 21:28:41 +0000 (UTC) In-Reply-To: <87wnxiqezv.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 16 Dec 2020 11:15:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196226 Archived-At: tags 45035 fixed close 45035 28.0.50 thanks >>> Thanks, I think your idea is correct. But I'm not sure if >>> minibuffer-completion-help is the right place for wrapping in >>> with-minibuffer-selected-window. This means that all calls of >>> annotation-function will be in the original buffer, whereas >>> only read-extended-command--annotation needs such wrapping. >> >> Oh, that's a very good point. Probably it would be best to leave >> minibuffer-completion-help as is, and change only >> read-extended-command--annotation. >> >>> Or do you care that such wrapping will be called for every command >>> in read-extended-command--annotation? Then instead of annotation-function >>> you could try to use a new function affixation-function that is called >>> only once, so you could add wrapping to it. >> >> My Emacs doesn't have affixation-function yet, so I don't really know >> anything about it. > > I'm sorry that your version of Emacs is not updated too often. > So here I created a patch based on current master, and after > pushing it, sometimes it will arrive to your updated version. Now pushed to master, and closed.