From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "James N. V. Cash" Newsgroups: gmane.emacs.bugs Subject: bug#45879: 28.0.50; [PATCH] missing defvar for keymap-name-history Date: Thu, 14 Jan 2021 19:32:14 -0500 Message-ID: <87r1mn6nw1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13307"; mail-complaints-to="usenet@ciao.gmane.io" To: 45879@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 15 01:33:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0D37-0003LQ-7g for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 01:33:09 +0100 Original-Received: from localhost ([::1]:38996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0D36-0007qd-4H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Jan 2021 19:33:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0D30-0007pM-4i for bug-gnu-emacs@gnu.org; Thu, 14 Jan 2021 19:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56344) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0D2z-00080g-TZ for bug-gnu-emacs@gnu.org; Thu, 14 Jan 2021 19:33:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0D2z-0003QB-Pu for bug-gnu-emacs@gnu.org; Thu, 14 Jan 2021 19:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "James N. V. Cash" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jan 2021 00:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45879 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161067074113102 (code B ref -1); Fri, 15 Jan 2021 00:33:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Jan 2021 00:32:21 +0000 Original-Received: from localhost ([127.0.0.1]:39657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0D2K-0003PG-S9 for submit@debbugs.gnu.org; Thu, 14 Jan 2021 19:32:21 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:59754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0D2J-0003P9-8r for submit@debbugs.gnu.org; Thu, 14 Jan 2021 19:32:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0D2J-00079w-25 for bug-gnu-emacs@gnu.org; Thu, 14 Jan 2021 19:32:19 -0500 Original-Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]:41920) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0D2H-0007m2-Lc for bug-gnu-emacs@gnu.org; Thu, 14 Jan 2021 19:32:18 -0500 Original-Received: by mail-qk1-x72a.google.com with SMTP id 19so10215619qkm.8 for ; Thu, 14 Jan 2021 16:32:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version; bh=0Rmh2WS14H2gdK6i/HQysPpZV/w867VGB4pWQCFgrDo=; b=tmeMH+Roig+DrSRRxNKnheRKMPnlJvoLka18DmEf8n0MPOu4ObwSIkMEQ4s3Luc2fA U2ENOP5UJBIwvkiLdoTY7yQ+wJYfu3mSmhf/xBjohePWuuY2AFHe80hQC1SbG/IDqKHm I4SDeQs+sFcLTFQkoxjSv31x5ynE1mhi7IkN+ihI4eP2g83Mi1iSdEuDG5j22JrKiu34 Pox+dRH9AYOGH9+Nm3ktCsFJNJBORLFg4Te8oEq0FNmawS2IC0Z0hMg68CYOJkSNLDmp +yhmjq9sGGSNNMWPM2fE7rlSe4aTY0VjnZfuhYN8MimfAF48JitzZw+Tm8i6bcJqhi6A yHNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=0Rmh2WS14H2gdK6i/HQysPpZV/w867VGB4pWQCFgrDo=; b=Ulb4ERRM14EseezaoAa6jboFldRPqLCb5qsrpJwYb9UnPUWqkIgoRFqdFHlMsogrTd yGawGoU6IKjfDgf1ZJlBjnxJGUkvfAebkEG1zhS7+w+UP9dbK//jcKu/fmVzR4mqNJ5k ZdN4e788ddr4hGo9rDwc1msXFOSBm4XLoKVkNlWCGJShu9hylsuVWJ+WHBxgX0yAnOqh v82VvjUxtK8g3mSZDNfGTZiLKEO+Bnb06sGxt6ifCMPJ4M+vPNO6I7cUL+I6h5h20JCS HkHvHzGJZaukJKehWo37pyRYhQ56cmKempPDDNdHclQoBAeN9/RhAc0YNvbDzu+yA2l5 ynaA== X-Gm-Message-State: AOAM533YsdNwyyRhVugx4Ii2J1d/axoD/js7gz1qmM6jpaGO9/w3dBNL 7BEZlEQgaKsdffO0QANK7bEbjU8d1qvPag== X-Google-Smtp-Source: ABdhPJyUnNDmDRK9jfIaiZGe7NswDxV9s9FGDKl0MUfsES1LFDaYtda+K14jvXKaXdZxSYJzDl0yfA== X-Received: by 2002:a05:620a:2009:: with SMTP id c9mr9997656qka.159.1610670736205; Thu, 14 Jan 2021 16:32:16 -0800 (PST) Original-Received: from gonk ([2607:fea8:10e1:3200:28:2c9f:70fc:81e1]) by smtp.gmail.com with ESMTPSA id x47sm3929595qtb.86.2021.01.14.16.32.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 16:32:15 -0800 (PST) Received-SPF: pass client-ip=2607:f8b0:4864:20::72a; envelope-from=james.nvc@gmail.com; helo=mail-qk1-x72a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197968 Archived-At: It seems that the new describe-keymaps function in help-fns.el is missing a defvar for keymap-name-history. This results in an error when using, e.g. Helm as the completing-read function. The attached patch adds the defvar to help-fns.el. --- lisp/help-fns.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/help-fns.el b/lisp/help-fns.el index d559221a82..7be2826361 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -76,6 +76,9 @@ help-definition-prefixes ;; costly, really). "Radix-tree representation replacing `definition-prefixes'.") +(defvar keymap-name-history nil + "History for input to `describe-keymap'.") + (defun help-definition-prefixes () "Return the up-to-date radix-tree form of `definition-prefixes'." (when (> (hash-table-count definition-prefixes) 0) -- 2.25.1