From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47414: 26.1; [PATCH] compilation-goto-locus does not handle right display-buffer Date: Sun, 28 Mar 2021 15:19:34 +0200 Message-ID: <87r1jz5sbd.fsf@gnus.org> References: <87im5d26pm.fsf@host.localdomain> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23172"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47414@debbugs.gnu.org To: pillule Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 28 15:20:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQVKq-0005uX-Sb for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 15:20:08 +0200 Original-Received: from localhost ([::1]:40934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQVKp-0003nt-Tu for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 09:20:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQVKk-0003nj-8c for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 09:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34006) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQVKk-0007X7-0r for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 09:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQVKj-0004Nt-RI for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 09:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Mar 2021 13:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47414 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47414-submit@debbugs.gnu.org id=B47414.161693758816818 (code B ref 47414); Sun, 28 Mar 2021 13:20:01 +0000 Original-Received: (at 47414) by debbugs.gnu.org; 28 Mar 2021 13:19:48 +0000 Original-Received: from localhost ([127.0.0.1]:45551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQVKV-0004MP-Un for submit@debbugs.gnu.org; Sun, 28 Mar 2021 09:19:48 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQVKU-0004M5-5G for 47414@debbugs.gnu.org; Sun, 28 Mar 2021 09:19:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JqVEUw/pdeDwPf9GSsZgTetGr2N6E5Jk+JTQXf8zsbg=; b=oiXEEqVP/gqtvCpbl4JMk3ueEm jrPOSHX29Bc4jl8aPSlPSOaBijoBQmVIs8J/Up39N+O6GxRB3yYv8HEeWFgFPvdjwicsceCrp5/G2 Ni6M9lZ/t08TBoQVm+PMHQfIA0r/2IHM2YCHRQgw/PzRvVX7vI+Rnlh/0mwvXuDpcBPs=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQVKJ-0002BB-6V; Sun, 28 Mar 2021 15:19:40 +0200 X-Now-Playing: Bobbie Gentry's _The Girl From Chickasaw County (5): Touch 'Em With Love_: "Supper Time" In-Reply-To: <87im5d26pm.fsf@host.localdomain> (pillule@riseup.net's message of "Fri, 26 Mar 2021 16:57:41 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203160 Archived-At: pillule writes: > This patch is a trivial check aknowledge if we are in the compilation > window before choosing what display function to use, so users can > customize the behavior of compilation windows via display-buffer-alist > without breaking the error navigation functionnalities. Thanks; applied to Emacs 28. I'm not 100% confident here, though, since the logic here is slightly convoluted, but if I read the code correctly, then this shouldn't introduce any regressions, at least. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no