From: "J.P." <jp@neverwas.me>
To: Amin Bandali <bandali@gnu.org>
Cc: 47788-done@debbugs.gnu.org, emacs-erc@gnu.org
Subject: bug#47788: Add support for TLS client certificates to 'erc-tls'
Date: Fri, 23 Apr 2021 05:31:46 -0700 [thread overview]
Message-ID: <87r1j1chcd.fsf__28981.5146637679$1619181212$gmane$org@neverwas.me> (raw)
In-Reply-To: <871rb1zv4m.fsf@gnu.org> (Amin Bandali's message of "Thu, 22 Apr 2021 20:45:29 -0400")
Hey, guess we both missed this:
@@ -505,18 +512,23 @@ erc-server-process-alive
(memq (process-status erc-server-process) '(run open)))))
;;;; Connecting to a server
-(defun erc-open-network-stream (name buffer host service)
- "As `open-network-stream', but does non-blocking IO"
- (make-network-process :name name :buffer buffer
- :host host :service service :nowait t))
+(defun erc-open-network-stream (name buffer host service &rest parameters)
+ "Like `open-network-stream', but does non-blocking IO."
+ (let ((p (plist-put parameters :nowait t)))
+ (open-network-stream name buffer host service p)))
;; ^~~~~~~~ Need an apply #' here because ~~~~~~^
-(defun erc-server-connect (server port buffer)
+(defun erc-server-connect (server port buffer &optional client-certificate)
Turns out my silly tests for one of those unofficial #erc bugs (the
azur12 one) caught it by failing (which means your patch magically fixed
the issue!).
Anyway, no rush; I doubt this really impacts anyone.
next prev parent reply other threads:[~2021-04-23 12:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 4:16 bug#47788: Add support for TLS client certificates to 'erc-tls' Amin Bandali
2021-04-15 12:44 ` J.P.
2021-04-18 19:23 ` Amin Bandali
[not found] ` <87h7k3mm6x.fsf@gnu.org>
2021-04-20 13:49 ` J.P.
2021-04-23 0:45 ` Amin Bandali
[not found] ` <871rb1zv4m.fsf@gnu.org>
2021-04-23 12:31 ` J.P. [this message]
[not found] ` <87r1j1chcd.fsf@neverwas.me>
2021-04-23 22:52 ` Amin Bandali
2021-04-16 7:38 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87r1j1chcd.fsf__28981.5146637679$1619181212$gmane$org@neverwas.me' \
--to=jp@neverwas.me \
--cc=47788-done@debbugs.gnu.org \
--cc=bandali@gnu.org \
--cc=emacs-erc@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).