From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#48456: Revert Dired after copy/rename Date: Fri, 21 May 2021 21:08:33 +0100 Message-ID: <87r1hz3l4u.fsf@tcd.ie> References: <87v97j1xih.fsf@mail.linkov.net> <87v97en1tm.fsf@mail.linkov.net> <87cztkuede.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35596"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48456@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 21 22:09:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lkBSQ-0008z7-8z for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 May 2021 22:09:18 +0200 Original-Received: from localhost ([::1]:35312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkBSP-0001IL-BO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 May 2021 16:09:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkBSA-0001Gn-Ip for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 16:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54312) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lkBSA-00009R-B6 for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 16:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lkBSA-00089F-4O for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 16:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 May 2021 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48456 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 48456-submit@debbugs.gnu.org id=B48456.162162772331288 (code B ref 48456); Fri, 21 May 2021 20:09:02 +0000 Original-Received: (at 48456) by debbugs.gnu.org; 21 May 2021 20:08:43 +0000 Original-Received: from localhost ([127.0.0.1]:37624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkBRr-00088a-Cr for submit@debbugs.gnu.org; Fri, 21 May 2021 16:08:43 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:36760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkBRo-00088K-Sw for 48456@debbugs.gnu.org; Fri, 21 May 2021 16:08:42 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id c14so20393130wrx.3 for <48456@debbugs.gnu.org>; Fri, 21 May 2021 13:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=VP+4V2upSAPhX54h1oMlkT/tUBlSIg9yPLfyR4XrRPo=; b=c+6x7b4iCW3gg/nl/brLqSFaWJQsMdk2F7qNzLP9FiVen2RPmOcjXrnd7yFy9zsZfu Ssfbz+Vrc2ad/jFnERtn18aDvl/5U0BURXWWDDZEdC4/OCmA8koBZnaKdHcqlXNvT7b0 s72mWo4xWgwwjc62e8Ag8rmLG5nedmtNr/K+lWEC1rJyTMfH/ERCBhmpsEG/Mm0lzZhk n0JIKuoCGBXmKtX539T9q8yfxMNmHLde3eSPPJ0apxLKCswPNjlAACaiQiz0b53vEGb0 83TVjPSEVbmqvB2A6R4aRP6JZgLdMMmBzs4zcH+T+xpCj9zMhJ6gHTFhzb1CK2h+Rjk+ JmEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=VP+4V2upSAPhX54h1oMlkT/tUBlSIg9yPLfyR4XrRPo=; b=LZKY/s7yyP6ASOVlVMfDm2zNURYwwWwlQ+vIo+b5c+VmsQgotIzgi/XPMvA22+EpH4 +wGow3wmzZ0XroNKzTbb711KeTkTx7Sm5Si9YqDQdnkdnUJnSqxq4SpVS5YWFgQX3hLT YZBZ83lUJX4fbgUlo6ERAGdBDTRNGYR1fbMPk4y3WLCgw46UvX3Q2AFh+KYJg2RZyMTq r1n3kB/EZCViEp1IyASQ1YhthW3voI9sDny2fCOZ58uozYJllT5asKM3prsMkcC0dOSz g5GdatS+R5b4eGDSEIU/19TBmCXw1ipmwoSkWbo3hiqrgT6vgLMgoEDM2fss10S3M6aN V9Cg== X-Gm-Message-State: AOAM531DCDGWVAxeaD9tSmINin9aAukUG+n3FnKxuhFcIp0DKMh2r1Ip WVtYKRx0YX6RZqMHYlYf2TaMVWxiXdYefw== X-Google-Smtp-Source: ABdhPJyKq4xE34+nVpTCRfURL+rk/xgCA2QDDkJN0PnY5W2znn6ffmwwbNTD4y7nalL0RVn2F/QLrw== X-Received: by 2002:adf:f211:: with SMTP id p17mr11125988wro.169.1621627714770; Fri, 21 May 2021 13:08:34 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id y2sm3180585wrl.92.2021.05.21.13.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 13:08:34 -0700 (PDT) In-Reply-To: <87cztkuede.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 21 May 2021 21:32:29 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207001 Archived-At: Juri Linkov writes: >> It seems better to create a new option: >> >> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el >> index eb43ab187d..5df4d6b206 100644 >> --- a/lisp/dired-aux.el >> +++ b/lisp/dired-aux.el >> @@ -2065,6 +2065,24 @@ dired-create-files >> +(defcustom dired-do-revert-buffer nil > > Now pushed to master and closed. Thanks, but I now see: Test dired-test-bug30624 condition: (ert-test-failed ((should (dired-do-create-files 'copy 'dired-copy-file "Copy" nil)) :form (dired-do-create-files copy dired-copy-file "Copy" nil) :value nil)) Should the 'should' be removed? AFAICT the return value of dired-do-create-files is unspecified (and unused). -- Basil