From: Lars Ingebrigtsen <larsi@gnus.org>
To: Matthew Carter <m@ahungry.com>
Cc: 48824@debbugs.gnu.org, Ben Bacarisse <ben@bsb.me.uk>
Subject: bug#48824: 27.1; Symbol’s function definition is void: gnus-info-set-read
Date: Fri, 04 Jun 2021 11:55:46 +0200 [thread overview]
Message-ID: <87r1hiymvx.fsf@gnus.org> (raw)
In-Reply-To: <8735typ895.fsf@ahungry.com> (Matthew Carter's message of "Fri, 04 Jun 2021 00:24:22 -0400")
Matthew Carter <m@ahungry.com> writes:
> Ben Bacarisse <ben@bsb.me.uk> writes:
>
>> After upgrading to 27.1 my Gnus home-grown backend fails with
>>
>> Symbol’s function definition is void: gnus-info-set-read
>>
>> If I comment out the one use of this function I can start Gnus but, of
>> course, the maintenance of the read messages no longer works.
>>
>> The associated "getter" function (gnus-info-read) works, as does the
>> related "setter" function gnus-into-set-marks.
>
> Looks like this changed towards end of 2019 to swap from macros to
> inlined functions, and you can now use setf directly, vs a setter:
>
> https://git.savannah.gnu.org/cgit/emacs.git/tree/ChangeLog.3#n9403
Yes, the accessor macros should have been retained for backwards
compatibility (but marked as obsolete) to avoid breaking out-of-tree
code.
But that sail has shipped (since Emacs 27.1 was released without those
macros), so unfortunately all external code has to be adjusted to use
the new syntax. Fortunately, that shouldn't be difficult -- just
rewrite calls like
(gnus-info-set-read info range)
to
(setf (gnus-info-read info) range)
There isn't going to be any further Emacs 27 releases, so we can't
reintroduce the removed setter macros, either, so I'm closing this bug
report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-06-04 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 0:49 bug#48824: 27.1; Symbol’s function definition is void: gnus-info-set-read Ben Bacarisse
2021-06-04 4:24 ` Matthew Carter
2021-06-04 9:55 ` Lars Ingebrigtsen [this message]
2021-06-04 12:09 ` Ben Bacarisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1hiymvx.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=48824@debbugs.gnu.org \
--cc=ben@bsb.me.uk \
--cc=m@ahungry.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).