From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: pillule Newsgroups: gmane.emacs.bugs Subject: bug#48916: 28.0.50; allow windmove to select windows with the 'no-other-window parameter Date: Tue, 08 Jun 2021 16:26:51 +0200 Message-ID: <87r1hcxw5q.fsf@riseup.net> References: <878s3kzm66.fsf@riseup.net> <83czswfunl.fsf@gnu.org> <87wnr4xxok.fsf@riseup.net> <83wnr4e970.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39395"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pillule , 48916@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 08 16:35:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqcox-000A0o-KU for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Jun 2021 16:35:11 +0200 Original-Received: from localhost ([::1]:58840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqcov-0007GN-IK for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Jun 2021 10:35:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqcoo-0007GD-Sn for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 10:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47887) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqcoo-0005kQ-L9 for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 10:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqcoo-0000oM-Gx for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 10:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: pillule Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Jun 2021 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48916 X-GNU-PR-Package: emacs Original-Received: via spool by 48916-submit@debbugs.gnu.org id=B48916.16231628823082 (code B ref 48916); Tue, 08 Jun 2021 14:35:02 +0000 Original-Received: (at 48916) by debbugs.gnu.org; 8 Jun 2021 14:34:42 +0000 Original-Received: from localhost ([127.0.0.1]:59433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqcoU-0000nc-EB for submit@debbugs.gnu.org; Tue, 08 Jun 2021 10:34:42 -0400 Original-Received: from mx1.riseup.net ([198.252.153.129]:55658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqcoQ-0000nM-Ql for 48916@debbugs.gnu.org; Tue, 08 Jun 2021 10:34:40 -0400 Original-Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4Fzt6d0r4SzDqN6; Tue, 8 Jun 2021 07:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1623162873; bh=bWBZ/hHnx/HWizcnwaPXHyYl9kIjOFIkaxwdVTtn8KU=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=Ly/OER+0lG3vH1jkg6mG+nURPxlGmlCrroODB7aS9qcRCIz3V60zYuJ3AcCWEEHet YK1PKIS/sCra1JW3IeqZH0+d+s+P0Kaud9sHYQSrDyfSk0zn7UWDn0sy3DkU/hNAuq +o4UfGx5Uwfrp0uSh31ezedOW+/ap+GfSTZM0NkE= X-Riseup-User-ID: DFA5C39062A03477DF1153227652A202FD39A233BF208FC3F672A661F0526C0E Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4Fzt6b4CSDz5w50; Tue, 8 Jun 2021 07:34:31 -0700 (PDT) In-reply-to: <83wnr4e970.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208245 Archived-At: --=-=-= Content-Type: text/plain; format=flowed Eli Zaretskii writes: >> got them. the last one may be a little bit confusing for the >> reader that is not aware of it because all others defcustoms of >> window.el applies a :group tag. Do you want that I remove the >> others unnecessary ones ? > > Fine with me if you remove them. > > (The patch you sent was the old one, right?) >> [...] > > If that's the case, I suggest to send the patch as an > attachment. My bad the bug was me ;) --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0004-User-option-to-select-no-other-window-with-windmove.patch Content-Description: minor nits >From dff7eedd24f5ff85b075b3616fca6c0fa090ff90 Mon Sep 17 00:00:00 2001 From: Trust me I am a doctor Date: Tue, 8 Jun 2021 11:51:55 +0200 Subject: [PATCH] User option to select 'no-other-window with windmove * lisp/windmove.el (windmove-ignore-no-other-window): Add new user option, remove superfluous :group tag. (windmove-find-other-window): Use windmove-ignore-no-other-window to choose whether windmove can access to the window with the 'no-other-window property. (windmove-wrap-around): Remove superfluous :group tag. (windmove-create-window): Remove superfluous :group tag. (windmove-window-distance-delta): Remove superfluous :group tag. (windmove-display-no-select): Remove superfluous :group tag. (windmove-default-keybindings): Remove superfluous :group tag. (windmove-display-default-keybindings): Remove superfluous :group tag. (windmove-delete-default-keybindings): Remove superfluous :group tag. (windmove-swap-states-default-keybindings): Remove superfluous :group tag. --- lisp/windmove.el | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/lisp/windmove.el b/lisp/windmove.el index f558903681..b883824413 100644 --- a/lisp/windmove.el +++ b/lisp/windmove.el @@ -138,8 +138,7 @@ windmove-wrap-around a frame will find the rightmost one, and similarly for the other directions. The minibuffer is skipped over in up/down movements if it is inactive." - :type 'boolean - :group 'windmove) + :type 'boolean) (defcustom windmove-create-window nil "Whether movement off the edge of the frame creates a new window. @@ -147,7 +146,6 @@ windmove-create-window a frame will create a new window on the left, and similarly for the other directions." :type 'boolean - :group 'windmove :version "27.1") ;; If your Emacs sometimes places an empty column between two adjacent @@ -157,11 +155,18 @@ windmove-window-distance-delta Measured in characters either horizontally or vertically; setting this to a value larger than 1 may be useful in getting around window- placement bugs in old versions of Emacs." - :type 'number - :group 'windmove) + :type 'number) (make-obsolete-variable 'windmove-window-distance-delta "no longer used." "27.1") +(defcustom windmove-move-in-all-windows nil + "Whether the windmove commands are allowed to target all type of windows. +If this variable is set to non-nil, `windmove-find-other-window--side' and +subsequently all interactive windmove commands will ignore the +no-other-window parameter applied with `display-buffer-alist'." + :type 'boolean + :version "28.0.50") + ;; Note: ;; @@ -342,7 +347,8 @@ windmove-find-other-window Optional ARG, if negative, means to use the right or bottom edge of WINDOW as reference position, instead of `window-point'; if positive, use the left or top edge of WINDOW as reference point." - (window-in-direction dir window nil arg windmove-wrap-around t)) + (window-in-direction dir window windmove-move-in-all-windows + arg windmove-wrap-around t)) ;; Selects the window that's hopefully at the location returned by ;; `windmove-find-other-window', or screams if there's no window there. @@ -480,7 +486,6 @@ windmove-default-keybindings (defcustom windmove-display-no-select nil "Whether the window should be selected after displaying the buffer in it." :type 'boolean - :group 'windmove :version "27.1") (defun windmove-display-in-direction (dir &optional arg) @@ -761,8 +766,7 @@ windmove-default-keybindings (null val)) (set-default sym val)) :type windmove--default-keybindings-type - :version "28.1" - :group 'windmove) + :version "28.1") (defcustom windmove-display-default-keybindings nil "Default keybindings for windmove directional buffer display commands. @@ -780,8 +784,7 @@ windmove-display-default-keybindings (null val)) (set-default sym val)) :type windmove--default-keybindings-type - :version "28.1" - :group 'windmove) + :version "28.1") (defcustom windmove-delete-default-keybindings nil "Default keybindings for windmove directional window deletion commands. @@ -796,8 +799,7 @@ windmove-delete-default-keybindings (null val)) (set-default sym val)) :type windmove--default-keybindings-type - :version "28.1" - :group 'windmove) + :version "28.1") (defcustom windmove-swap-states-default-keybindings nil "Default keybindings for windmove's directional window swap-state commands. @@ -812,8 +814,7 @@ windmove-swap-states-default-keybindings (null val)) (set-default sym val)) :type windmove--default-keybindings-type - :version "28.1" - :group 'windmove) + :version "28.1") (provide 'windmove) -- 2.20.1 --=-=-= Content-Type: text/plain; format=flowed -- --=-=-=--