From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49033: 28.0.50; [PATCH] Feature suggestion, url-cache-expiry-alist to override expire time for cache pruning Date: Tue, 15 Jun 2021 16:11:23 +0200 Message-ID: <87r1h3tdys.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4040"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49033@debbugs.gnu.org To: Alex Bochannek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 15 16:19:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lt9uO-0000ml-Cg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Jun 2021 16:19:16 +0200 Original-Received: from localhost ([::1]:37878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lt9uN-0000Sj-0o for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Jun 2021 10:19:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lt9nO-0004sj-O1 for bug-gnu-emacs@gnu.org; Tue, 15 Jun 2021 10:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38818) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lt9nN-0005Je-UY for bug-gnu-emacs@gnu.org; Tue, 15 Jun 2021 10:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lt9nN-0005AM-R9 for bug-gnu-emacs@gnu.org; Tue, 15 Jun 2021 10:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Jun 2021 14:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49033 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49033-submit@debbugs.gnu.org id=B49033.162376629519821 (code B ref 49033); Tue, 15 Jun 2021 14:12:01 +0000 Original-Received: (at 49033) by debbugs.gnu.org; 15 Jun 2021 14:11:35 +0000 Original-Received: from localhost ([127.0.0.1]:50364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lt9mx-00059c-JD for submit@debbugs.gnu.org; Tue, 15 Jun 2021 10:11:35 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:50580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lt9mw-00059N-47 for 49033@debbugs.gnu.org; Tue, 15 Jun 2021 10:11:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5S1piCKEZKsEpq3Yf6CR6V7r9LDCff7kxFWPjIIADas=; b=Xe29dTRf6CKHWt94JeChpSH1MV L6s2D+Dlbk/aJeRjHkdpgRfJtrFzfOl3sQzoCDKPr5VDmDKURuvGKJ0xMxa215blNxntDP/590bCr Ka18PrNxS7zhiQAA9xejD+Cbt9SirIfzEeFp1B6oOPuJtpGRRKFMQA6K/o2QRZvvwI+k=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lt9mm-0007b8-JO; Tue, 15 Jun 2021 16:11:27 +0200 X-Now-Playing: Bobbi Humphrey's _Blacks and Blues_: "Harlem River Drive" In-Reply-To: (Alex Bochannek's message of "Mon, 14 Jun 2021 22:40:29 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208550 Archived-At: Alex Bochannek writes: > +(defcustom url-cache-expiry-alist nil > + "Alist of URL regular expressions to override the `url-cache-expire-time'." > + :version "28.1" > + :type 'alist > + :group 'url-cache) Sure, adding this makes sense to me. > +(defun url-cache-create-url-from-file (file) I thought this existed, but I guess not... > + (let ((expire-time > + (remove > + nil > + (mapcar > + (lambda (alist) > + (let ((key (car alist)) > + (value (cdr alist))) > + (if > + (string-match > + key > + (url-cache-create-url-from-file file)) > + value))) > + url-cache-expiry-alist)))) > + (if (consp expire-time) (apply 'min expire-time) nil)) > + url-cache-expire-time)) > now) > (delete-file file) > (setq deleted-files (1+ deleted-files)))))) > > I also didn't really like the way the code ended up being formatted. Is > there some guidance around splitting functions and their arguments > across multiple lines? Well, we never do: > + (if > + (string-match But in general, we just try to keep it readable, which means not going too far in either horizontal nor vertical directions. (So there's really no rules for formatting beyond that.) Your code in this patch generally seems to be way too vertical. > - ;; Twelve hours. > - (* 12 60 60)))) > + gravatar-cache-ttl))) I don't mind that -- but is this really something that somebody would want to control? It just seemed unlikely to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no