From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30978: 25.3; Suggestion: define-minor-mode should define mode-lighter variable Date: Sun, 25 Jul 2021 09:59:34 +0200 Message-ID: <87r1fmx1qx.fsf@gnus.org> References: <874l3ou42z.fsf@mouse.gnus.org> <87sgcdft5w.fsf@gnus.org> <87pmwadno8.fsf@gnus.org> <97892e0eebeeff0413287058d68ad86b@webmail.orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22098"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 30978@debbugs.gnu.org, Stefan Kangas , Stefan Monnier To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 25 10:00:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7Z3d-0005bC-M4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 10:00:21 +0200 Original-Received: from localhost ([::1]:47804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Z3b-00038c-T3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 04:00:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Z3P-00037E-AY for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 04:00:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35986) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7Z3O-0002lY-Sd for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 04:00:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7Z3K-0008Gp-Tt for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 04:00:06 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jul 2021 08:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30978 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 30978-submit@debbugs.gnu.org id=B30978.162719999131740 (code B ref 30978); Sun, 25 Jul 2021 08:00:02 +0000 Original-Received: (at 30978) by debbugs.gnu.org; 25 Jul 2021 07:59:51 +0000 Original-Received: from localhost ([127.0.0.1]:47530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Z38-0008Fq-VZ for submit@debbugs.gnu.org; Sun, 25 Jul 2021 03:59:51 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Z36-0008FT-75 for 30978@debbugs.gnu.org; Sun, 25 Jul 2021 03:59:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YEfPFEvJm4zUkmQcYcbEzP8bl/CrQXJYpQYqAzoFaoc=; b=rOXUJEJejLdIVfdcIqlNT3h+tJ /uveyL3WA6uFLDZrIdlSod6ALcV+g3zYMVcuPIRWbVpPYB6SaRi7Z1fUQYGY+8pemmnuIOZw2Wem7 vL33B4OJrEQVKyl4kzfiJxMfyhZH43k5D3ENexhjVG7/EYKWq/wN6iJb/UpfFI7RQl8Q=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7Z2t-0006ob-CC; Sun, 25 Jul 2021 09:59:39 +0200 X-Now-Playing: Bobbie Gentry's _The Girl From Chickasaw County (6): Fancy_: "Wedding Bell Blues (Alternate Take)" In-Reply-To: <97892e0eebeeff0413287058d68ad86b@webmail.orcon.net.nz> (Phil Sainty's message of "Sat, 26 Jun 2021 10:57:13 +1200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210694 Archived-At: Phil Sainty writes: >> Does anybody else have an opinion here? The suggestion is to make >> define-minor-mode define a `foo-mode-lighter' variable that users can >> then change to easily change the lighters. > > It sounds like a good change. I just can't make up my mind here. On the one hand, a `foo-mode-lighter' variable would make things easy and regular. On the other hand, it means creating a new user option for each minor mode (i.e., a defcustom), and it means having these in `minor-mode-alist', which means one additional variable lookup (per minor mode) when creating the mode line. >> Or do we have a separate mechanism for this somewhere? > > We do in GNU ELPA (see https://www.emacswiki.org/emacs/DelightedModes > regarding the one I wrote, delight.el), but that and similar libraries > mostly exist because there wasn't something as trivial as a variable > to set. > > Delight also takes care of synchronising the label in `mode-line-menu' > (down-mouse-3 on `mode-line-modes'), as well as allowing custom names > for major modes via the same UI -- but providing an easy way to set > minor mode lighters was the actual reason for writing it. It sounds like delight is the right solution here -- it's a more complete solution, and people who want this can just install your package... So... on the whole... I think we shouldn't add the -lighter variables. So I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no