From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#42424: 27.0.90; replace-match: point is NOT left at the end of replacement Date: Sat, 31 Jul 2021 16:03:44 +0200 Message-ID: <87r1fefum7.fsf@gnus.org> References: <87zh4ltc5l.fsf@gnus.org> <83tuussr1v.fsf@gnu.org> <87tuusj618.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6677"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42424@debbugs.gnu.org, victorhge@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 31 16:04:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9pb6-0001Vr-Pk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Jul 2021 16:04:16 +0200 Original-Received: from localhost ([::1]:34290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9pb4-0003F4-Ua for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Jul 2021 10:04:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9pas-0003DD-QW for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 10:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51210) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m9pas-0003Tx-IT for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 10:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m9pas-0007Sx-Eh for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 10:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Jul 2021 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42424 X-GNU-PR-Package: emacs Original-Received: via spool by 42424-submit@debbugs.gnu.org id=B42424.162774023828689 (code B ref 42424); Sat, 31 Jul 2021 14:04:02 +0000 Original-Received: (at 42424) by debbugs.gnu.org; 31 Jul 2021 14:03:58 +0000 Original-Received: from localhost ([127.0.0.1]:34523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9pao-0007Sf-9W for submit@debbugs.gnu.org; Sat, 31 Jul 2021 10:03:58 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9pal-0007SQ-MA for 42424@debbugs.gnu.org; Sat, 31 Jul 2021 10:03:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XblT+Soe331M2p4afgX8F8VZ5pL16tESb/yBiu8Ayy8=; b=JcUEjmePV/ZQSX9JsXCFvHREOG m1HbG7638FSmL2bu7FVs+ikBM8QCx0Rz2oIYnt+saop3GUQbHqHeo5NvUzxuqD4ovwCNkHo1RQulS +ufSf71mo1GGvAdqG94MZIq7iBXKl0uWWaI4k4XfpAMnRugchbSJczx974S3I8MIdH+c=; Original-Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9pac-0004Je-99; Sat, 31 Jul 2021 16:03:49 +0200 In-Reply-To: <87tuusj618.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 18 Oct 2020 10:24:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210986 Archived-At: Lars Ingebrigtsen writes: >> Other types of modification (insert or delete) do not have this issue. >> `point' is adjusted before running modification hooks. > > So I think the suggestion is to move point to the end of the replacement > before running the modification hooks, i.e., move the point logic to > replace_range. No, that was wrong -- the suggestion was to not move point to the end of the replacement text (numerically speaking). But we can't do that -- the `replace-match' interface guarantees that it will do that, and changing this will break stuff. The modification hooks may do all kinda of oddball stuff that changes the buffer before moving to that point, so to make that work more reliably, we'd have to make a marker, I think? But `replace-match' is used so heavily that I'm not sure the performance impact won't be noticeable. One possible idea is to postpone the modification hooks until the end of replace_match (instead of doing it in replace_range -- that should have no performance impact, and not change behaviour in most cases. But I'm having problems making that work. The hook is called from update_compositions, isn't it? Are there any caveats to using that? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no