From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#45763: 27.1; fido-mode does not work with icomplete-in-buffer completion Date: Tue, 17 Aug 2021 11:47:02 +0100 Message-ID: <87r1eswdp5.fsf@gmail.com> References: <556652585.117858.1610281874781@office.mailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9588"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: simon254@mailbox.org, monnier@iro.umontreal.ca To: 45763@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 17 12:48:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFwdg-0002GR-2q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Aug 2021 12:48:12 +0200 Original-Received: from localhost ([::1]:40826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFwdf-0003jj-0u for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Aug 2021 06:48:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFwdW-0003dU-CN for bug-gnu-emacs@gnu.org; Tue, 17 Aug 2021 06:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40393) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFwdW-0001DC-5h for bug-gnu-emacs@gnu.org; Tue, 17 Aug 2021 06:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mFwdW-0007AC-4c for bug-gnu-emacs@gnu.org; Tue, 17 Aug 2021 06:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Aug 2021 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45763 X-GNU-PR-Package: emacs X-Debbugs-Original-To: simon254--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: 45763@debbugs.gnu.org, simon254@mailbox.org, monnier@iro.umontreal.ca Original-Received: via spool by 45763-submit@debbugs.gnu.org id=B45763.162919723426310 (code B ref 45763); Tue, 17 Aug 2021 10:48:02 +0000 Original-Received: (at 45763) by debbugs.gnu.org; 17 Aug 2021 10:47:14 +0000 Original-Received: from localhost ([127.0.0.1]:51936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFwck-0006pj-0f for submit@debbugs.gnu.org; Tue, 17 Aug 2021 06:47:14 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:46646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFwcg-0006if-1G for 45763@debbugs.gnu.org; Tue, 17 Aug 2021 06:47:12 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id f5so27846109wrm.13 for <45763@debbugs.gnu.org>; Tue, 17 Aug 2021 03:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=qo2UHDBVvZyiC1YyB+aWOJcu2cMVO8rE/+77aPlE/CA=; b=poc5DsfJ28A49BnYD6c2sr4eLHwwOmOPKFDq3CHBMkfUi8PhWzGAZxcMjIpA2853o3 c8arBu6oWsp0SzoGrWBjMZhoyrOmPhnuMni6pWBSajY4oWCwHUrSGgMynNDgXIYDHeRE QRhBGh7esBC+GI2TYDJMmi+UBQJe8Rhg7zMyGxjbMBGgbuoZnZZPBZQ3oxCPLtYtv+zw WSlbWI4n0jKv6QSJDorcQedmXrYxOOOkbJjmKQbBkpqddFt4hTarIiwsCVbsaJoLd/uM gQJ/GKneBB42Q2L0OJYPXcO9z2W8B9p3D93lHeyrm+aPCCv/o3A2CMx0NuaUJ4K6yYHl fEvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=qo2UHDBVvZyiC1YyB+aWOJcu2cMVO8rE/+77aPlE/CA=; b=X7Fb/5OCtFv6FZ1dwAggDIrSGPFty7te8Y+OgldZt8iwpNe5/YIfgmoCgyWIlT0jUp UO1pTNZTY6TKSy3eZSpEAsJEWU+jDEdF5VUItC4yFXtlMC5OjgB+WoxuDDi7v+jU7Ika qtIqMj1HGaL2ni/RNfwLqJXKOIH0hiLr8u+PtJlbeMO6Ej6+hZQFgRfF1BuMhHSa4gVa dmJRA1jJ28DJt2XITX4nuMUjCCWQ43rhIYc9PL385cQeQVAi0ecQHHzvzpZU1RpSZEhA ARaKzvAn7Zmn0kAEjGRhTiWJazQ8xfphbaPlUzR7UbH+S+1P9P1RlzaEDmcdgtFpHU/W 8ORA== X-Gm-Message-State: AOAM5325t8UBmdEBW8hW6OgaXXRpZBUFfSchcq5i8FRfV01DLWaW/Jcw VupNDyvex8e8u0Czbx67Gl4= X-Google-Smtp-Source: ABdhPJwvWqzh5Z4zIqcQsD2nPZd1SFV/bsGxsFyRgQI0CcMBFXId3Pm6Rt3M6ztehMNmDmmGgKWqGg== X-Received: by 2002:a5d:6e0c:: with SMTP id h12mr3278044wrz.334.1629197224068; Tue, 17 Aug 2021 03:47:04 -0700 (PDT) Original-Received: from krug (a94-133-27-132.cpe.netcabo.pt. [94.133.27.132]) by smtp.gmail.com with ESMTPSA id r4sm1655027wmq.34.2021.08.17.03.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Aug 2021 03:47:03 -0700 (PDT) In-Reply-To: <556652585.117858.1610281874781@office.mailbox.org> (simon's message of "Sun, 10 Jan 2021 12:31:14 +0000 (GMT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212076 Archived-At: simon254--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > in *sratch* evaluate > (setq icomplete-in-buffer t) > (fido-mode t) > type: > "(icompl" followed by C-M-i (completion-at-point)=20 > -> default completion is invoked, not fido-mode It's true, it doesn't. And either does icomplete-mode. It's completely broken. Even if I do this to fido-mode, it's still broken, quite broken, I don't know how to fix it. But I would like to fix it, maybe by letting the choice still happen from the minibuffer while. Let's keep this bug open to track this development. Jo=C3=A3o diff --git a/lisp/icomplete.el b/lisp/icomplete.el index e06b33e43b..89ace7e434 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -411,9 +411,12 @@ fido-mode :global t :group 'icomplete (remove-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup) (remove-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup) + (remove-hook 'completion-in-region-mode-hook #'icomplete--in-region-setu= p) (when fido-mode (icomplete-mode -1) (setq icomplete-mode t) + (when icomplete-in-buffer + (add-hook 'completion-in-region-mode-hook #'icomplete--in-region-set= up)) (add-hook 'minibuffer-setup-hook #'icomplete-minibuffer-setup) (add-hook 'minibuffer-setup-hook #'icomplete--fido-mode-setup))) =20 > > same happens for shell completion: > > M-x shell > ls xxx followed by tab -> default completion is invoked, not fido-mode > > In GNU Emacs 27.1 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 = Version 10.14.6 (Build 18G95)) > of 2020-08-12 built on builder10-14.porkrind.org > Windowing system distributor 'Apple', version 10.3.1894 > System Description: Mac OS X 10.15.7 > > Recent messages: > For information about GNU Emacs and the GNU system, type C-h C-a. > > Configured using: > 'configure --with-ns '--enable-locallisppath=3D/Library/Application > Support/Emacs/${version}/site-lisp:/Library/Application > Support/Emacs/site-lisp' --with-modules' > > Configured features: > NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES > THREADS JSON PDUMPER > > Important settings: > value of $LANG: en_GB.UTF-8 > locale-coding-system: utf-8-unix > > Major mode: Lisp Interaction > > Minor modes in effect: > tooltip-mode: t > global-eldoc-mode: t > eldoc-mode: t > electric-indent-mode: t > mouse-wheel-mode: t > tool-bar-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > line-number-mode: t > transient-mark-mode: t > > Load-path shadows: > None found. > > Features: > (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs > format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg > epg-config gnus-util rmail rmail-loaddefs text-property-search time-date > subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies > mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs > cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils > tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type > mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win > tool-bar dnd fontset image regexp-opt fringe tabulated-list replace > newcomment text-mode elisp-mode lisp-mode prog-mode register page > tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse > jit-lock font-lock syntax facemenu font-core term/tty-colors frame > minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese > tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek > romanian slovak czech european ethiopic indian cyrillic chinese > composite charscript charprop case-table epa-hook jka-cmpr-hook help > simple abbrev obarray cl-preloaded nadvice loaddefs button faces > cus-face macroexp files text-properties overlay sha1 md5 base64 format > env code-pages mule custom widget hashtable-print-readable backquote > threads kqueue cocoa ns multi-tty make-network-process emacs) > > Memory information: > ((conses 16 44811 6704) > (symbols 48 5927 1) > (strings 32 15254 1703) > (string-bytes 1 504784) > (vectors 16 10174) > (vector-slots 8 126879 9518) > (floats 8 19 39) > (intervals 56 189 0) > (buffers 1000 11))