From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Hauke Rehfeld Newsgroups: gmane.emacs.bugs Subject: bug#46374: Regression: erronous calls to PRED switch major-mode of unrelated modified buffers Date: Sat, 28 Aug 2021 18:25:23 +0200 Message-ID: <87r1ecilqn.fsf@haukerehfeld.de> References: <878s7z4ihk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31389"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.3; emacs 28.0.50 To: 46374@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 29 14:52:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKKID-0007rK-RB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Aug 2021 14:52:09 +0200 Original-Received: from localhost ([::1]:35800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKKIC-0000y0-Ow for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Aug 2021 08:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKKI6-0000xa-Dg for bug-gnu-emacs@gnu.org; Sun, 29 Aug 2021 08:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKKI6-0005Et-1v for bug-gnu-emacs@gnu.org; Sun, 29 Aug 2021 08:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKKI5-0001RO-Ux for bug-gnu-emacs@gnu.org; Sun, 29 Aug 2021 08:52:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <878s7z4ihk.fsf@gmail.com> Resent-From: Hauke Rehfeld Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Aug 2021 12:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46374 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 46374-submit@debbugs.gnu.org id=B46374.16302414965505 (code B ref 46374); Sun, 29 Aug 2021 12:52:01 +0000 Original-Received: (at 46374) by debbugs.gnu.org; 29 Aug 2021 12:51:36 +0000 Original-Received: from localhost ([127.0.0.1]:55734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKKHf-0001Qj-FC for submit@debbugs.gnu.org; Sun, 29 Aug 2021 08:51:36 -0400 Original-Received: from helin.uberspace.de ([185.26.156.195]:60968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKI7x-0008Ip-Bw for 46374@debbugs.gnu.org; Sun, 29 Aug 2021 06:33:26 -0400 Original-Received: (qmail 26605 invoked from network); 29 Aug 2021 10:33:23 -0000 Original-Received: from localhost (HELO localhost) (127.0.0.1) by helin.uberspace.de with SMTP; 29 Aug 2021 10:33:23 -0000 X-Mailman-Approved-At: Sun, 29 Aug 2021 08:51:34 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212930 Archived-At: Hmmm, I'm pretty sure the changes to `save-some-buffers` here regarding the predicate indirection caused a regression and/or very unexpected behavior that causes bugs in previously working code. Consider `(save-some-buffers t (lambda () (derived-mode-p 'org-mode)))' called from an org-mode buffer. It runs through the part of `save-some-buffers' that is trying to resolve the PRED indirection: https://github.com/emacs-mirror/emacs/blob/692da8c6a82f8de376a2eec9304773b3e85205f3/lisp/files.el#L5792 ``` emacs-lisp ;; Allow `pred' to be a function that returns a predicate ;; with lexical bindings in its original environment (bug#46374). (let ((pred-fun (and (functionp pred) (funcall pred)))) (when (functionp pred-fun) (setq pred pred-fun))) ``` which evaluates the predicate to check if it returns a function -- which `(derived-mode-p)' does, as it simply returns the major-mode symbol on success! In this case, it would be `#'org-mode'. So then `org-mode' is called on any unsaved buffers as a PREDICATE, switching those buffers to org-mode. Compare this usage in org-mode, org.el:15357: ``` emacs-lisp (defun org-save-all-org-buffers () "Save all Org buffers without user confirmation." (interactive) (message "Saving all Org buffers...") (save-some-buffers t (lambda () (derived-mode-p 'org-mode))) (when (featurep 'org-id) (org-id-locations-save)) (message "Saving all Org buffers... done")) ```