From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 9923@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#9923: 24.0.91; `where-is' does not find recentf menu items (cmds, not files)
Date: Mon, 30 Aug 2021 10:33:47 +0300 [thread overview]
Message-ID: <87r1ebz98c.fsf@mail.linkov.net> (raw)
In-Reply-To: <87y28kf5sn.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 29 Aug 2021 20:46:00 +0200")
>> Another question: is it possible not to evaluate :filter in where-is as all?
>
> Then it'd find even less commands, I think?
I thought that maybe it's possible somehow to avoid :filter evaluation
for menus.
>> Yesterday I added to context-menu-map such lines:
>>
>> (let ((fun (mouse-posn-property (event-start last-input-event)
>> 'context-menu-function)))
>>
>> but now noticed that after typing 'C-h m' it fails with:
>>
>> Debugger entered--Lisp error: (args-out-of-range 1786)
>> mouse-posn-property((#<window 178 on *scratch*> 1786 (0 . 0) 0) context-menu-function)
>> context-menu-map()
>
> Well, you could just check that last-input-event is a mouse event before
> calling that function?
This patch fixes the error, but still e.g. in Info buffer
typing 'C-h m q' moves point in the Info buffer to some fixed position
(maybe related to a position in *Help* buffer), i.e. still something is wrong.
diff --git a/lisp/mouse.el b/lisp/mouse.el
index 7d3ed9a0e4..f4d7d86c28 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -307,15 +307,19 @@ context-menu-filter-function
(defun context-menu-map ()
"Return composite menu map."
(let ((menu (make-sparse-keymap (propertize "Context Menu" 'hide t))))
- (let ((fun (mouse-posn-property (event-start last-input-event)
- 'context-menu-function)))
+ (let ((fun
+ ;; Check if `where-is-internal' calls this in wrong buffer.
+ (when (eq (window-buffer (posn-window (event-start last-input-event)))
+ (current-buffer))
+ (mouse-posn-property (event-start last-input-event)
+ 'context-menu-function))))
(if (functionp fun)
(setq menu (funcall fun menu))
(run-hook-wrapped 'context-menu-functions
next prev parent reply other threads:[~2021-08-30 7:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 20:26 bug#9923: 24.0.91; `where-is' does not find recentf menu items (cmds, not files) Drew Adams
2011-11-01 16:05 ` Stefan Monnier
2012-09-17 0:25 ` Drew Adams
2021-08-25 12:18 ` Lars Ingebrigtsen
2021-08-25 14:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-26 13:42 ` Lars Ingebrigtsen
2021-08-26 17:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-29 16:48 ` Juri Linkov
2021-08-29 18:46 ` Lars Ingebrigtsen
2021-08-30 7:33 ` Juri Linkov [this message]
2021-08-31 0:03 ` Lars Ingebrigtsen
2021-08-31 6:41 ` Juri Linkov
2021-08-31 8:36 ` Lars Ingebrigtsen
2021-08-31 18:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-30 6:55 ` Juri Linkov
2021-09-30 12:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-03 17:54 ` Juri Linkov
2021-10-03 18:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-03 18:53 ` Juri Linkov
2021-10-03 19:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-05 18:04 ` Juri Linkov
2021-12-05 20:48 ` Lars Ingebrigtsen
2021-12-05 23:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-06 9:28 ` Juri Linkov
2021-12-06 13:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-06 17:24 ` Juri Linkov
2021-12-06 19:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-08 20:32 ` Juri Linkov
2022-12-15 18:28 ` Juri Linkov
2022-12-15 18:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-15 18:51 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1ebz98c.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=9923@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).