From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50667: Update ecomplete when used via standard UI Date: Sat, 18 Sep 2021 23:06:58 +0200 Message-ID: <87r1dlpp8t.fsf@gnus.org> References: <871r5l1tud.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26407"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50667@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 18 23:08:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRhZE-0006in-MM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 23:08:12 +0200 Original-Received: from localhost ([::1]:35370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRhZD-0004ie-0y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 17:08:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRhZ4-0004iW-Fp for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53765) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRhZ4-0003OB-5B for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRhZ3-0003hd-SD for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 21:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50667 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50667-submit@debbugs.gnu.org id=B50667.163199923214176 (code B ref 50667); Sat, 18 Sep 2021 21:08:01 +0000 Original-Received: (at 50667) by debbugs.gnu.org; 18 Sep 2021 21:07:12 +0000 Original-Received: from localhost ([127.0.0.1]:37078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRhYG-0003ga-7u for submit@debbugs.gnu.org; Sat, 18 Sep 2021 17:07:12 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRhYE-0003gM-8M for 50667@debbugs.gnu.org; Sat, 18 Sep 2021 17:07:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OCBU5iCAZS/tdC0rDV2Rv01EA72mwRanxFzHkHzzdxE=; b=qprj/sIvnnoJInGqYYkFWXvhpv sz+M52fp+iLmV2i7CcPaYXt4ciRLNhMsWFQAQibyOJ7thm0KySuNNxNsQugkh3guTfKzfmJ7skNZy M0p+x+z8wwCcwD0/lsi+PSpoFEwsdH1pYZQrRokhhaCEfoKKcks7VGymG0xHb85mGdUU=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRhY3-00088N-Uv; Sat, 18 Sep 2021 23:07:02 +0200 In-Reply-To: <871r5l1tud.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 18 Sep 2021 23:01:30 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214662 Archived-At: Augusto Stoffel writes: > If one keeps sets > > (setq message-mail-alias-type nil ;; or keep the default 'abbrev > message-expand-name-standard-ui t) > > and an ecomplete database file, then everything works OOTB, Works in what way? > except that the ecomplete database doesn't get updated with new > addresses. > > Is the following change a reasonable fix for this? [...] > - (when (and (message-mail-alias-type-p 'ecomplete) > + (when (and (bound-and-true-p ecomplete-database) I think this would be highly surprising behaviour -- just loading a library shouldn't have such side effects. What's your use case here? You don't want to use ecomplete for alias expansions, but you still want to update the ecomplete database? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no