From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50690: Avoid double argument evaluation in vc-call Date: Tue, 21 Sep 2021 07:18:48 +0200 Message-ID: <87r1diecav.fsf@gnus.org> References: <87pmt49lfe.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23449"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50690@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 21 07:19:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSYBS-0005vB-PD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Sep 2021 07:19:10 +0200 Original-Received: from localhost ([::1]:50632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSYBR-0004yk-P6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Sep 2021 01:19:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSYBL-0004xL-62 for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 01:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSYBK-0007vK-PN for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 01:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSYBK-0005Lu-Gv for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 01:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Sep 2021 05:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50690 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50690-submit@debbugs.gnu.org id=B50690.163220154120567 (code B ref 50690); Tue, 21 Sep 2021 05:19:02 +0000 Original-Received: (at 50690) by debbugs.gnu.org; 21 Sep 2021 05:19:01 +0000 Original-Received: from localhost ([127.0.0.1]:44550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSYBJ-0005Lf-4v for submit@debbugs.gnu.org; Tue, 21 Sep 2021 01:19:01 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSYBG-0005LQ-1b for 50690@debbugs.gnu.org; Tue, 21 Sep 2021 01:18:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=D2NL55lU4ozAJviqQvwol0PYtVm6EK6ttNclEqyEzw4=; b=TKbza64jjnFvYiu2+ajQWIPSrD h2IEO2zCaP4bWo0t5IwxcLsYk2RdZcAiuZ0cQZC4Qrsar3oGPsvV3URP2cdQrPVdhQm9Ux3aQHxCB jFC4gNTC1AP5pCIg4j+VSsK3slIizgMR+9BcF9+JxSxtcWjOx+u7+zgwmpkf6IEa3OJc=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSYB7-0001D3-Dv; Tue, 21 Sep 2021 07:18:52 +0200 X-Now-Playing: Jana Rush's _Pariah_: "Frenetic Snare" In-Reply-To: <87pmt49lfe.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 20 Sep 2021 00:48:21 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214907 Archived-At: "Basil L. Contovounesios" writes: > Is there any reason why the macro vc-call should continue to evaluate > its second argument twice? Both 'make bootstrap' and 'make check' pass > with the attached patch: Your patch seems "obviously correct" to me (but it's an incompatible change since the previous wonky behaviour was actually documented, so it should be mentioned in NEWS). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no