From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51173: 28.0.60; gnus-article-describe-key doesn't work Date: Thu, 14 Oct 2021 19:16:40 +0300 Organization: LINKOV.NET Message-ID: <87r1cnio3j.fsf@mail.linkov.net> References: <87h7dl6spg.fsf@gnus.org> <87r1cox4th.fsf@mail.linkov.net> <87h7dkx2g5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12391"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , Katsumi Yamaoka , 51173@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 14 18:18:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mb3Qt-00030v-Ke for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Oct 2021 18:18:15 +0200 Original-Received: from localhost ([::1]:60012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mb3Qs-0008IU-IS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Oct 2021 12:18:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mb3Qh-0008AR-J3 for bug-gnu-emacs@gnu.org; Thu, 14 Oct 2021 12:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mb3Qh-0006eu-8x for bug-gnu-emacs@gnu.org; Thu, 14 Oct 2021 12:18:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mb3Qh-0004yg-2n; Thu, 14 Oct 2021 12:18:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 14 Oct 2021 16:18:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51173 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 51173-submit@debbugs.gnu.org id=B51173.163422826319088 (code B ref 51173); Thu, 14 Oct 2021 16:18:03 +0000 Original-Received: (at 51173) by debbugs.gnu.org; 14 Oct 2021 16:17:43 +0000 Original-Received: from localhost ([127.0.0.1]:36936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb3QN-0004xo-9l for submit@debbugs.gnu.org; Thu, 14 Oct 2021 12:17:43 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:40295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mb3QM-0004xa-71 for 51173@debbugs.gnu.org; Thu, 14 Oct 2021 12:17:42 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id E47511BF205; Thu, 14 Oct 2021 16:17:33 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Wed, 13 Oct 2021 16:01:51 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217231 Archived-At: >> + (defn (if (consp event) >> + (save-excursion >> + (mouse-set-point event) (key-binding key t)) >> + (key-binding key t)))) >> ;; Handle the case where we faked an entry in "Select and Paste" menu. >> (when (and (eq defn nil) >> (stringp (aref key (1- (length key)))) > > But this will still use "the wrong buffer" for mouse clicks, no? It seems all mouse clicks expect the buffer where they were clicked to be displayed in a window. I can't imagine how a mouse click could originate from a hidden buffer. > BTW, maybe a cleaner fix would be as follows: > - Add a `buffer` argument to `describe-key(-briefly)`. > - Pass that argument from `gnus-article-describe-key`. > And to get the behavior that Juri just pushed that `buffer` argument > would default to (if (consp event) (window-buffer (posn-window > (event-start event))) (current-buffere)). I don't know. All reported cases work now after Eli fixed mouse-minibuffer-check not to raise an error when called from mouse-set-point, so now it's safe to use it in help--analyze-key.