From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Tue, 19 Oct 2021 05:52:15 +0200 Message-ID: <87r1chfz80.fsf@gnus.org> References: <87bl4jvudm.fsf@gnus.org> <837dehp248.fsf@gnu.org> <87czo96shw.fsf@gnus.org> <87wnmh5bes.fsf@gnus.org> <87wnmh3p9k.fsf@gnus.org> <87v91tfzrw.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37653"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Shuguang Sun , 50752@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 05:53:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcgBb-0009Yq-BJ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 05:53:11 +0200 Original-Received: from localhost ([::1]:58956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcgBZ-0004Vb-JI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Oct 2021 23:53:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcgBT-0004VM-HP for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 23:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcgBS-0001r0-3T for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 23:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcgBR-0001h8-Ur for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 23:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 03:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.16346155476471 (code B ref 50752); Tue, 19 Oct 2021 03:53:01 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 19 Oct 2021 03:52:27 +0000 Original-Received: from localhost ([127.0.0.1]:49046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcgAt-0001gJ-7g for submit@debbugs.gnu.org; Mon, 18 Oct 2021 23:52:27 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:59024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcgAr-0001g4-EG for 50752@debbugs.gnu.org; Mon, 18 Oct 2021 23:52:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+spkRJo0tp53hxtpw76dW444qA0I05pRDXR87gxO1fI=; b=GHdXU1ArKQaN4iF5UMaVPOU6LP JtolLIZfV93RuHG4gfRw4odbBl8D/3xkpamb4k1aCt1K4sRnGEf0/FsxLsbmxWO/ur3TpUk90DR7y 6/0V6kuPFzEt+jdc7YLp4nxpwQX8PGLn6VWhUSkl6baALIAKdwtCGyDJ/1b0tBPRgGRQ=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcgAh-0002Wv-Se; Tue, 19 Oct 2021 05:52:18 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAAAAAByaaZbAAAAAXNSR0IArs4c6QAAAAJiS0dE AP+Hj8y/AAAACXBIWXMAAAsSAAALEgHS3X78AAAAB3RJTUUH5QoTAyE1Wiuv2AAAAJhJREFUSMft k9ENgCAMRIGwkqPclF3KUfzBQC3aw/ihwX4R0tdryxHXMBZpMH9OIAeUk3BAXOqZQlqgIXBaQQF7 BjolyKFhLrRCCGKSRPNDa0WnJSgBsV2lXpWrgZyWrETml4R+Sx7Gb6lgiTEQGo3jw7nxwh9344tS UU3MKTSmJxXqQzw/tGgBFzDOcRUwChxjSvP9wEeBDeQcFNLrTcmuAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIxLTEwLTE5VDAzOjMzOjUzKzAwOjAwkhlZ3AAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0x MC0xOVQwMzozMzo1MyswMDowMONE4WAAAAA4dEVYdGljYzpjb3B5cmlnaHQAQ29weXJpZ2h0IChj KSAxOTk4IEhld2xldHQtUGFja2FyZCBDb21wYW55+Vd5NwAAACF0RVh0aWNjOmRlc2NyaXB0aW9u AHNSR0IgSUVDNjE5NjYtMi4xV63aRwAAACZ0RVh0aWNjOm1hbnVmYWN0dXJlcgBJRUMgaHR0cDov L3d3dy5pZWMuY2gcfwBMAAAAN3RFWHRpY2M6bW9kZWwASUVDIDYxOTY2LTIuMSBEZWZhdWx0IFJH QiBjb2xvdXIgc3BhY2UgLSBzUkdCRFNIqQAAAABJRU5ErkJggg== X-Now-Playing: Lost Girls's _Menneskekollektivet_: "Love, Lovers" In-Reply-To: <87v91tfzrw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 19 Oct 2021 05:40:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217540 Archived-At: Lars Ingebrigtsen writes: > So if the string is multibyte, it downcases correctly, but if not, it... > turns a capital I into the digit 1? > > (downcase "ABCDEFGHIJKLMNOPQRSTUVWXYZ") > => "abcdefgh1jklmnopqrstuvwxyz" I guess it's from this: static Lisp_Object do_casify_unibyte_string (struct casing_context *ctx, Lisp_Object obj) { ptrdiff_t i, size = SCHARS (obj); int ch, cased; obj = Fcopy_sequence (obj); for (i = 0; i < size; i++) { ch = make_char_multibyte (SREF (obj, i)); cased = case_single_character (ctx, ch); if (ch == cased) continue; cased = make_char_unibyte (cased); /* If the char can't be converted to a valid byte, just don't change it. */ if (SINGLE_BYTE_CHAR_P (cased)) SSET (obj, i, cased); } return obj; } Which just looks wrong to me. The logic in Fdowncase seems to assume that a unibyte string can never be downcased to a multibyte one, but that make_char_unibyte is picking out the lowest eight bits of the char we've downcased to and puts that into the downcased string. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no