From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#51620: add-hook repeatedly adds same function into hook--depth-alist Date: Sat, 06 Nov 2021 01:13:02 +0100 Message-ID: <87r1buf8fl.fsf@web.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30884"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51620@debbugs.gnu.org, Stefan Monnier To: Filipp Gunbin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 06 01:14:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mj9La-0007rW-Tv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Nov 2021 01:14:14 +0100 Original-Received: from localhost ([::1]:55932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mj9LZ-00070z-FC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 20:14:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mj9LO-0006yS-Ik for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 20:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mj9LO-0003cN-AF for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 20:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mj9LO-0002DV-11 for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 20:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Nov 2021 00:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51620 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51620-submit@debbugs.gnu.org id=B51620.16361576008464 (code B ref 51620); Sat, 06 Nov 2021 00:14:01 +0000 Original-Received: (at 51620) by debbugs.gnu.org; 6 Nov 2021 00:13:20 +0000 Original-Received: from localhost ([127.0.0.1]:47679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mj9Ki-0002CR-BR for submit@debbugs.gnu.org; Fri, 05 Nov 2021 20:13:20 -0400 Original-Received: from mout.web.de ([212.227.15.14]:36587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mj9Kf-0002CD-ST for 51620@debbugs.gnu.org; Fri, 05 Nov 2021 20:13:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1636157584; bh=a0R4WYEO9ABnqnLGwNBI7Zc+q2KKvBmUAA3EPcMWbnE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Lb1eBHyRHRbECdCDtQns5w1U92RN1QFFvlOv3zsV3x16kxX7XqHAtwU+Fdub9mFkB auqXrNvx7Hx0r/nOtiuqAB0TszzuaQolxHn31Wlhw/1wnh92syFFipwbJzhNC/q7IE Cp9d8w+b1epPfdZFgJ1pjjgZV5VczKc6nkcgm5LM= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([92.208.225.87]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M8C07-1mnqQF0Gqx-005PTS; Sat, 06 Nov 2021 01:13:04 +0100 In-Reply-To: (Filipp Gunbin's message of "Sat, 06 Nov 2021 02:26:32 +0300") X-Provags-ID: V03:K1:zayhWX4DuSAHrPRz3gO9eyyRWWL07oLatuDeQQvKGXbme1icfw3 wfgh5TBIoe9dQ+7KhCeXHCHb9wuYXOtjOypnODnjA8rapjS2LZlHBIHTedGHWaPj/B/dSUo j97Gc6gtQq1JaA3vAJHt7AA7kLV5lqTEmAK83PEZgXPXI4fU38amjCw2nBOtzTbes5uMnnz RDGws++d2n4fvxXtnYKlQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:XQbggXB0z4w=:6EZk9HuzXiR9NKAyNrCe6M 1mJxXlE7Rt6r8KzDDDkQ9BpSul9mNBw6UzChSLgEb4rWSjW0gTv4PNirJgqHSw352J1+/XwbO XkvKPz3V7RiS9e8YFrSZ0EmrbbvXJ5tnPJuVqrztTjmGb8GvMNBTvSndDDSoLmbo9W0UmK4xG WR0m9WEVieWJc9K2tJcTVkJh/wOuJdRsyS9zo6OQPDFdX+veA6npyzlLipGdWh7qvfRrmj+cb iDsWziBHEWaROu7NgOmz0OpqoYupV5q/SLUCucxZMta5eFgQZkfi+A2kDJDQHs7BUNmAv7idl C/zr+P24Cfu89wb9uIgr8FtymFvmR2dLkazvmtaZbvBhFBlxnJxehJNHfAGvwEBndQFSixaUH Tk4Zv9K1l3t1y22u48LWpTBkoDb8/b8INnbzXu2RBIKkdLFna06ijZG/2o6VWDOujj3ksVqBy bWBBOOnLzKOQhtA+nJTKN5p2UfcCl3yXt804he6sD55gIC16imTfj/WK58KM/g6MDyoZpJ2Hp wBW6wxnb/oOctPeZL+RfX/8lFUACMnVXGSJl7G+GhxYtQeDLVsb785r0b/JQO3fKJ1kB82grb hXP/hYy/hXQ6hdV6FPPL28TH+VEt6eYELAmInxwwd5JRoZvVH0xVxMKCUPhxVsDP+8vKHXm1A 8JQ/hTKGAgCddZxdOkcRCozkyrUR92cslvWDHM9/6O2DtCEnk215GkuXe91k+5ZM9Q4HSes3x 7CrCynX4bK94Y/qSgCM4Y/Zf39GmYCMGNGOYWklJ1pm6pGgqm9Th3kZjXC97G/i+ZFP1pO0E X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219039 Archived-At: Filipp Gunbin writes: > diff --git a/lisp/subr.el b/lisp/subr.el > index 8ff403e113..2b8b6deeb0 100644 > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -1868,7 +1868,7 @@ add-hook > (when (or (get hook 'hook--depth-alist) (not (zerop depth))) > ;; Note: The main purpose of the above `when' test is to avoid running > ;; this `setf' before `gv' is loaded during bootstrap. > - (push (cons function depth) (get hook 'hook--depth-alist))) > + (setf (alist-get function (get hook 'hook--depth-alist) 0) depth)) > (setq hook-value > (if (< 0 depth) > (append hook-value (list function)) So the function would still be compared using `eq' but we would avoid to add dups of equal conses? Looks reasonable to me -- Stefan? TIA, Michael.