From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus Date: Thu, 23 Dec 2021 14:42:04 -0800 Message-ID: <87r1a3ymdf.fsf@ericabrahamsen.net> References: <877dpddqo1.fsf@web.de> <8735zzhi4w.fsf@gnus.org> <87y2hrfxcs.fsf@web.de> <877dpb6suo.fsf@ericabrahamsen.net> <87tusd3i70.fsf@ericabrahamsen.net> <87sg7xrt82.fsf@web.de> <87tuscz974.fsf@ericabrahamsen.net> <87y250vu1f.fsf@gnus.org> <87czmbj3w4.fsf@web.de> <87o85urfxg.fsf@gnus.org> <87mtlelmpz.fsf@ericabrahamsen.net> <87tufezgk6.fsf@web.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14194"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 45330@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 23 23:43:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n0Wo0-0003Wt-II for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Dec 2021 23:43:24 +0100 Original-Received: from localhost ([::1]:57482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0Wny-0002z2-Sf for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Dec 2021 17:43:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0Wnd-0002xT-Un for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2021 17:43:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n0Wnd-0007Tz-Kq for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2021 17:43:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n0Wnd-0002u9-JW for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2021 17:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Dec 2021 22:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45330 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45330-submit@debbugs.gnu.org id=B45330.164029933511108 (code B ref 45330); Thu, 23 Dec 2021 22:43:01 +0000 Original-Received: (at 45330) by debbugs.gnu.org; 23 Dec 2021 22:42:15 +0000 Original-Received: from localhost ([127.0.0.1]:35137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0Wms-0002t6-M5 for submit@debbugs.gnu.org; Thu, 23 Dec 2021 17:42:14 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:47114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0Wmr-0002se-6P for 45330@debbugs.gnu.org; Thu, 23 Dec 2021 17:42:13 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 2B1AFFA02D; Thu, 23 Dec 2021 22:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1640299326; bh=t8np7GZ/DlPLX4+u7kRJ0pBN8bwx3ia0b+Z5SsMAYXM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YGwomvCu7PL444Gb9gvVj1kYV7KBPyI7J8yeJ4DVNZpXja2ElogWYeFD79wo6qR6W Z8MA1XQPHr+OOZ40izlygupNefS9Sr9KhMl5laApv3PXkvy3dcHBxLzjJvUmcH5hWn 4EYSEz6BAbtP9QJ++MOjqD9DmLILrzbVSo5NCqzY= In-Reply-To: <87tufezgk6.fsf@web.de> (Michael Heerdegen's message of "Sun, 12 Dec 2021 03:46:01 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223007 Archived-At: --=-=-= Content-Type: text/plain On 12/12/21 03:46 AM, Michael Heerdegen wrote: > Eric Abrahamsen writes: > >> I can switch the test to be something more explicit, but how about -- > > Please let's not forget about this again. > > What has yet to be done to fix this issue? Okay, dang it, here we go. Having thought about it, it seems like the solutions might be simpler than I thought. `gnus-registry-initialize' looks like this: (defun gnus-registry-initialize () "Initialize the Gnus registry." (interactive) (gnus-message 5 "Initializing the registry") (gnus-registry-install-hooks) => sets gnus-registry-enabled = t (gnus-registry-install-shortcuts) (if (gnus-alive-p) (gnus-registry-load) (add-hook 'gnus-read-newsrc-el-hook #'gnus-registry-load))) It makes no sense to set `gnus-registry-enabled' to t when we haven't fully loaded the registry. How about we move `gnus-registry-install-hooks' and `gnus-registry-install-shortcuts' into `gnus-registry-load', after the actual loading, a la the attached patch? Does this solve the problems you're seeing? Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=gnusregistryguard.diff diff --git a/lisp/gnus/gnus-registry.el b/lisp/gnus/gnus-registry.el index 163d543afd..feb39df925 100644 --- a/lisp/gnus/gnus-registry.el +++ b/lisp/gnus/gnus-registry.el @@ -356,7 +356,10 @@ gnus-registry-load (interactive) (let ((file gnus-registry-cache-file)) (condition-case nil - (gnus-registry-read file) + (progn + (gnus-registry-read file) + (gnus-registry-install-hooks) + (gnus-registry-install-shortcuts)) (file-error ;; Fix previous mis-naming of the registry file. (let ((old-file-name @@ -1184,8 +1187,6 @@ gnus-registry-initialize "Initialize the Gnus registry." (interactive) (gnus-message 5 "Initializing the registry") - (gnus-registry-install-hooks) - (gnus-registry-install-shortcuts) (if (gnus-alive-p) (gnus-registry-load) (add-hook 'gnus-read-newsrc-el-hook #'gnus-registry-load))) --=-=-=--