From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#53343: 29.0.50; assertion failure in diff--iterate-hunks Date: Fri, 21 Jan 2022 14:29:21 +0100 Message-ID: <87r191b4jy.fsf@rub.de> References: <87czkpl32e.fsf@gmx.net> <878rvdkzgd.fsf@gmx.net> <874k5xtkhm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27337"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53343@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 21 14:42:04 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAuB1-0006rI-Gk for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jan 2022 14:42:03 +0100 Original-Received: from localhost ([::1]:42618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAuB0-0005YP-4L for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jan 2022 08:42:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAtzP-0002VK-Ts for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 08:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39504) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAtzP-00047F-ET for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 08:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAtzP-0005HL-AG for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 08:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jan 2022 13:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53343 X-GNU-PR-Package: emacs Original-Received: via spool by 53343-submit@debbugs.gnu.org id=B53343.164277177120196 (code B ref 53343); Fri, 21 Jan 2022 13:30:03 +0000 Original-Received: (at 53343) by debbugs.gnu.org; 21 Jan 2022 13:29:31 +0000 Original-Received: from localhost ([127.0.0.1]:60638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAtyt-0005Fe-3Y for submit@debbugs.gnu.org; Fri, 21 Jan 2022 08:29:31 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:48087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAtyq-0005FO-Vu for 53343@debbugs.gnu.org; Fri, 21 Jan 2022 08:29:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1642771762; bh=gsTqNkquS0AOdg57i8iz/wBTbBiXPOnoiafMHCwwQPY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=jQwOE1W/Wx3Uz0rkIElKeleIQp3WuRTMPTCzkr8G6LTTF8a8AEA6oOgZGXnPm3/lj rn+knY1CJdcbWW+T1gxPOfZx1wZl6s0Otz3XKbOfnhWQb57E51k/aghBuu72a4d5LJ YCpy/wMDDPK9GdPuwR6dqQIoV9hldnfR8O3ghJl0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs2 ([89.246.36.97]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MnakX-1mU6R530uj-00jZEx; Fri, 21 Jan 2022 14:29:22 +0100 In-Reply-To: <874k5xtkhm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 21 Jan 2022 12:07:49 +0100") X-Provags-ID: V03:K1:wJePZl+k9+4ejDR95V8hG2qOUepkZbr5KdUOtK6se0qDrI3yyFr k5AfOtXIazX5MXfIaQPrrR6sa82vmIqCGyMXL5NKcAwnuzEPrO8faQm9Qpe85Fp/ckUHf0f PnZbqG0jxCbW32XdQh/wdoVt4wuNlUWg9rpgwMAjEYk985Z5ss7G2ohbXVswejDzyY4CDie gf+LYXJF8a6JHq2DejjUQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:zqYvEWyMYgk=:E2DMFK2s1ktPuBBAW8ae1v BCNtu7fjnjt9qDlm7n39A8oja2q5tDCkxJJLNuoZIeRP3X9IKpScBx6nWs31Pg8vBLPdz4GVh Bz4KQMFhyQW+mSa2fze+2WZADFP7UUjF2gKifHxa+oCTHC6c5kctKhkfXy64oRbqa0nTGievW kusb7kQx+sSFDSnO4rqW9WcFu70FeQq3/pms/PFgEL5qYym1yCsxC3NqbO9NTCrhwV7QP7rlT meRPYSOcjqgGde9VcbHS1RJVVcHR0xI96jXZHTRYN6a/0DQ1mlMJDHOePA/qsB4U8Maz4RWfr gIGYmYtPQgRjmHmpPTmivYITD/ezLKjl7fqUGKTPX5scxUizRhnvm2jP6LiytvVQKEGMssZli 7IncDWzv7cUAAjmQbt8KW6qYPT+X9NK9D8oYhgMQ4pKdOIafu6cIVvUzhqXTkc3cCNWGjGhfm dwu7XNJgPioZ1ZI43/f+tWdblGjYMoDZK/BB/CBO/jHRBKb7vA8suA27r8wQ8P2dTnInJ/FkE XvPjad8rfk0h4kMgTv4HJSAN5tcc4BGOvH82pmYILkU5q//sfxsk3oKF3syZtOzb5uRSstgrE IWgWdrWnRB2ZW1BiHrNDE7Oipw4FelLVPZil/4R3hYj+DhtZxtr1UCmyYFYSCDtAcNnlB2CLE Tt+Gve30zdv+g2Sqiyejw/68l01chQ/VsSDlYmfAT2Nv9NsfWpc9tEu19jX0kd677PUCgPaX2 TCk56A65Y+pdU/GF+xeKWNRvVYoc2KmstV0KPJLlILZaA80HKH6cwPU3B687jMZMGNCe31tc X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224767 Archived-At: On Fri, 21 Jan 2022 12:07:49 +0100 Lars Ingebrigtsen wrote: > Stephen Berman writes: > >> On the other hand, I get the assertion failure with the above recipe in >> emacs-28 and emacs-27, and it seems unlikely that such a bug in >> diff-mode would have gone unnoticed till now, so maybe the diff is >> malformed. (Though if so, why does the failure not happen when visiting >> the file containing the diff?) > > I tried > > (setq debug-on-error t) > > put the diff in a file, and got a backtrace when loading it. > > Debugger entered--Lisp error: (error "Unknown diff hunk type") > signal(error ("Unknown diff hunk type")) > error("Unknown diff hunk type") > diff-hunk-text("" nil nil) > diff-syntax-fontify-hunk(506 506 t) > etc Yes, I get this too. I must have mistested that before. > So I've now made that function less assertative, and that fixes this > issue. Thanks, and I confirm your fix avoids the error. However, you added this to the doc string of `diff-ignore-whitespace-hunk': "If INHIBIT-ERROR, ignore malformed hunks." But you didn't add an INHIBIT-ERROR argument. Steve Berman