From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#54245: 29.0.50; select usage in GNUstep Date: Fri, 04 Mar 2022 17:15:27 +0100 Message-ID: <87r17hhexs.fsf@gmail.com> References: <877d99g2g1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2585"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54245@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 04 17:16:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQAbe-0000Rs-Ep for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Mar 2022 17:16:38 +0100 Original-Received: from localhost ([::1]:51108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQAbc-0005xT-QO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Mar 2022 11:16:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQAb7-0005uT-8a for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 11:16:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQAb4-00047J-F0 for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 11:16:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nQAb4-00012o-AP for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 11:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Mar 2022 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 54245-submit@debbugs.gnu.org id=B54245.16464105362332 (code B ref 54245); Fri, 04 Mar 2022 16:16:02 +0000 Original-Received: (at 54245) by debbugs.gnu.org; 4 Mar 2022 16:15:36 +0000 Original-Received: from localhost ([127.0.0.1]:46702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQAae-0000bH-DJ for submit@debbugs.gnu.org; Fri, 04 Mar 2022 11:15:36 -0500 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:39559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQAad-0000TA-2F for 54245@debbugs.gnu.org; Fri, 04 Mar 2022 11:15:35 -0500 Original-Received: by mail-wr1-f53.google.com with SMTP id ay10so13432968wrb.6 for <54245@debbugs.gnu.org>; Fri, 04 Mar 2022 08:15:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=79PGbJFwh/o4p57Qqdz77ViOvu9dO4q7xbkkpHxEhQk=; b=q2aOXq93JoW2Pc5xoXgaXCqzdGag7IO9Mk5tJzNhW02Inl/4nokkS1ov5Gx4IM2XRs tshwvI5Mo7B9/0Zn2txrdgfADV5HGTl6++hFPPkW0LoVyhpElPRbMmDc5WJGHeHzx20X XUkVv4Q7NTzGnLkbCjHSdH6jdJ4FlroSNjK/k9F0kNleCLC6WRMaX/cmIl6usKfzQJtA X/r5UbO2YMQ87pBdbQgaPbqCWzOz0dXqwOTP38FZZoogSxUPVGNtsNDzmUOuH/POT1+d E56nIFVUo/igFkMTARWz7XpEk1rcK3WGa+ygnNBAmHDghxYXdHgdxQVDFRzfPNYe6Udf E90A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=79PGbJFwh/o4p57Qqdz77ViOvu9dO4q7xbkkpHxEhQk=; b=ZFDj0sqzvXphAJsgcDZoDjCymKTutb8kfHQ86ZAvEAFgeWWrqkiwByoFdgrBQqrKHF rt3W4x9g8ECuRFCq8c6QWGLiBNQ1awzMGKcmm+5L6kMYIO+YjNWfRkoOfLhqazIDeGXW PAMFJ+mW8IbuIC9q4l8FsG6/voByy8ad3atW9nbYQVqFcybgz7f4iFdJh7glZ7LSNoRB fJLXr9+BivGevW+IVsN80LwKi9xLWPgTFUx8HzhqjLpMXp9pzkvf38h1TNaURn14whly eaZVk5Oa9VQ7T9FZWORCfvKV8NQIHBMvaXG9QEsAN4atl3gKYUFkf2ePsCIbman72M9K gi0g== X-Gm-Message-State: AOAM531VJx8mcMojIn7ZviZPuSQki3M68Ym9twYuNu9e1MTID9Ej8aSI /8lQ8NrXcSobeNWaCVPDEidg6Ldoi7s= X-Google-Smtp-Source: ABdhPJxxub9Icm0oZYFMx+PCdZAh96QttKLLaZBjeF53+xWBLazzSWwbJJSHTECgDcQbCizbTxvbFg== X-Received: by 2002:a05:6000:1684:b0:1f0:6388:b006 with SMTP id y4-20020a056000168400b001f06388b006mr4802924wrd.445.1646410528724; Fri, 04 Mar 2022 08:15:28 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:ac53:3a05:3252:e55a]) by smtp.gmail.com with ESMTPSA id m26-20020a05600c3b1a00b003817ab146e9sm16157610wms.44.2022.03.04.08.15.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 08:15:28 -0800 (PST) In-Reply-To: <877d99g2g1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 04 Mar 2022 16:30:38 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228002 Archived-At: >>>>> On Fri, 04 Mar 2022 16:30:38 +0100, Lars Ingebrigtsen said: Lars> Paul noted in bug#32452 that: Lars> --- Lars> I notice that Emacs's GNUstep code calls 'select'. For completene= ss this=20 Lars> should be 'pselect' instead, so that Emacs never calls 'select'. Lars> --- Lars> So that should be fixed. (I open a new bug report, because that = bug Lars> report was already way too long.) I=CA=BCve been running with the following for a whole two days with no ill effects (and the resulting emacs binary does not contain any calls to 'select'). Last time I looked, emacs never seems to use the sigmask parameter to 'pselect' anyway, so it=CA=BCs kind of a moot point. diff --git a/src/nsterm.m b/src/nsterm.m index 670f8971df..4eb32de654 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -5830,7 +5830,7 @@ - (void)fd_handler:(id)unused fd_set fds; FD_ZERO (&fds); FD_SET (selfds[0], &fds); - result =3D select (selfds[0]+1, &fds, NULL, NULL, NULL); + result =3D pselect (selfds[0]+1, &fds, NULL, NULL, NULL, NULL); if (result > 0 && read (selfds[0], &c, 1) =3D=3D 1 && c =3D=3D '= g') waiting =3D 0; } Robert --=20