From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#50143: 28.0.50; Various issues with `tamil-itrans' input method Date: Sun, 13 Mar 2022 11:21:49 +0530 Message-ID: <87r176h022.fsf@gmail.com> References: <83fsv2x7jt.fsf@gnu.org> <874k509w4k.fsf@gmail.com> <83wnhu1zob.fsf@gnu.org> <87y229pxwt.fsf@gmail.com> <83czjl1jun.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7729"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 50143@debbugs.gnu.org, rameshnedunchezian@outlook.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 13 06:53:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTHAD-0001rf-OS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Mar 2022 06:53:09 +0100 Original-Received: from localhost ([::1]:45156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTHAC-0007cA-Oj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Mar 2022 00:53:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTHA6-0007bn-9Z for bug-gnu-emacs@gnu.org; Sun, 13 Mar 2022 00:53:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTHA6-0000Mz-03 for bug-gnu-emacs@gnu.org; Sun, 13 Mar 2022 00:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nTHA5-00087j-OL for bug-gnu-emacs@gnu.org; Sun, 13 Mar 2022 00:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Mar 2022 05:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50143 X-GNU-PR-Package: emacs Original-Received: via spool by 50143-submit@debbugs.gnu.org id=B50143.164715074431181 (code B ref 50143); Sun, 13 Mar 2022 05:53:01 +0000 Original-Received: (at 50143) by debbugs.gnu.org; 13 Mar 2022 05:52:24 +0000 Original-Received: from localhost ([127.0.0.1]:41440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTH9T-00086r-Qj for submit@debbugs.gnu.org; Sun, 13 Mar 2022 00:52:24 -0500 Original-Received: from mail-pj1-f65.google.com ([209.85.216.65]:34154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTH9R-00086a-7r for 50143@debbugs.gnu.org; Sun, 13 Mar 2022 00:52:21 -0500 Original-Received: by mail-pj1-f65.google.com with SMTP id d10-20020a17090a7bca00b001c5ed9a196bso703479pjl.1 for <50143@debbugs.gnu.org>; Sat, 12 Mar 2022 21:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=92cbc2AGL/DByeKux1WO4MrPwt8u6/Te1N0cNiUdp9E=; b=MNpJb0x/uAgfIeuDYFYp0qLbzZoThzS8cAx4OnvSfuiC4EykT9DTVshxcl+qmDAgRR 9I4W3sR2h6vZUWiQAwss5KGXUFIqAeosCHSm0OBl0T7zBiVsCjZTim7/7+feA8pRzfvo XbmByxZbd9sGBuPUd3XmoOWObrcXplwcXhxWSAzhLD3ZH2FN90IrE/UlfbOtlf/mi+8r pOdXGwzRjhK5SYAd7ClhCgaMj21gu3PzcWomOREGqhQy4l2G29RoqpAD5mRMDsxOHIAe 9CAdylso/tJ6giNXZhcM33h1GrymFyZ0DKhkNKwM94inbzM3yblqFii8Zvrolc3bp4K+ JUkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=92cbc2AGL/DByeKux1WO4MrPwt8u6/Te1N0cNiUdp9E=; b=iYd/XhIA31ircG/9jeL1hCfAd2imQEpjKMC3tCVEuFrVzPfaKBGobNOBWOr2T6U/Z3 55zvLqOFb2ghxckyad6FIlbhTOJOdBkZ2sDfwuu/8mNpv/pA+vjj4S5Y0DeOjXHOJ5pA A2Ka7SUc3bkI+X5Z2Kb3TH60PfTFQmoJGSPBtoD3GHC6SVEPjRwsy2osHaZh9gqg/WtG ak9RMOCiRGc32Ok1AcTW/upQL+YzjHLnNuc7N5ywUNclNGTUye6bw/JzaY1xZS4HFEeU bmx9VeVv8tMC+jglMoTp5FYGApTg1PLqycCQyjfzVBfG/gKT5kIPLBiGYpsTJYWZPNLf 1btg== X-Gm-Message-State: AOAM532ZPhMnD6kYuzJXKV2ahnGjW4c3XGuYGphElF6zu42cnD1hOt5P yuqwtAva+t9K8Rot981kUi0= X-Google-Smtp-Source: ABdhPJx6LImjaehoWuCqIOsYRVxYug7vXel2VulYkrfQbA4N961Os7ZJkg+Xv7BYoYrlKzoL7S9eRg== X-Received: by 2002:a17:90b:1b12:b0:1bf:1e5d:55e0 with SMTP id nu18-20020a17090b1b1200b001bf1e5d55e0mr18847259pjb.213.1647150735195; Sat, 12 Mar 2022 21:52:15 -0800 (PST) Original-Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id k11-20020a056a00134b00b004f7bc05c676sm1357916pfu.197.2022.03.12.21.52.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Mar 2022 21:52:14 -0800 (PST) In-Reply-To: <83czjl1jun.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 17 Feb 2022 19:30:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228278 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D, =E0=AE=AA= =E0=AE=BF=E0=AE=AA=E0=AF=8D=E0=AE=B0=E0=AE=B5=E0=AE=B0=E0=AE=BF 17 2022] El= i Zaretskii wrote: >> From: Visuwesh >> Cc: rameshnedunchezian@outlook.com, 50143@debbugs.gnu.org >> Date: Thu, 17 Feb 2022 16:23:06 +0530 >>=20 >> > 1. For your items 1 and 3, just copy indian-tml-base-table to a new >> > variable, modify it to include the two missing characters and >> > replace the digits with nil, add a new variable similar to >> > indian-tml-itrans-v5-hash, and compute its value like we do with >> > indian-tml-itrans-v5-hash, but using the new table instead of >> > indian-tml-base-table. Then make a new input method, called, say, >> > tamil-itrans-alt, which would use the new hash variable instead of >> > indian-tml-itrans-v5-hash. Submit these changes as patches to >> > lisp/language/ind-util.el and lisp/leim/quail/indian.el. >> > >>=20 >> Does the attached patch look okay to you? > > Yes, thanks. > >> The names of the new input methods are bad. IMO, tamil-itrans and >> tamil-inscript should ideally be renamed to tamil-itrans-digits and >> tamil-inscript-digits, and the new input methods should be tamil-itrans >> and tamil-inscript. But I guess such a backwards incompatible change >> won't fly? > > No, I think you can do the renaming. The change is already > incompatible, because we will be changing the default input method, so > it will need a NEWS entry to tell how to get back old behavior, and in > that NEWS entry we can also tell users to switch to another input > method. > >> > 2. For your item 2, submit a patch that fixes the docstring of the >> > relevant input methods. >>=20 >> About item 2: according to the docstring of `quail-define-package', >> constructs of the form "\" should be replaced by the VAR: >>=20 >> DOCSTRING is the documentation string of this package. The command >> =E2=80=98describe-input-method=E2=80=99 shows this string while repl= acing the form >> \ in the string by the value of VAR. That value should be a >> string. For instance, the form \ is >> replaced by a description about how to select a translation from a >> list of candidates. >>=20 >> but this is not the case, I checked the code but don't see a >> substitution like this happen. Maybe this should be fixed in >> `describe-input-method' instead? > > If you can find the problem and fix i there, fine. But fixing only a > small number of input methods with patches specific to those methods > is also fine. > I finally decided to procrastinate by working on this patch for once, please see updated patch below. I'm not really sure if the commit message's format is okay (C-c C-w barfs at me), so I tried to do it manually. Also, I think the NEWS entries can be improved but I'm not sure how. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-Follow-contemporary-practices-in-the-Tamil-IMs.patch Content-Transfer-Encoding: quoted-printable >From b3a7148d638008d6990693cd3d59972b329c3fac Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Sun, 13 Mar 2022 11:16:38 +0530 Subject: [PATCH] Follow contemporary practices in the Tamil IMs * lisp/language/ind-util.el (indian-tml-base-digits-table): New table to translates digits. (indian-tml-base-table): Don't translate digits. (indian-tml-itrans-digits-v5-hash): Hashtable that translates digits. * lisp/leim/quail/indian.el (tamil-itrans-digits) (tamil-inscript-digits): New input method that translates digits. (tamil-itrans, tamil-inscript): Fix table inclusion. * etc/NEWS: Announce the change. --- etc/NEWS | 14 ++++++++++++++ lisp/language/ind-util.el | 27 +++++++++++++++++++++++++++ lisp/leim/quail/indian.el | 38 ++++++++++++++++++++++++++++++++++---- 3 files changed, 75 insertions(+), 4 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index faac1fbc91..273fa77640 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -158,6 +158,13 @@ beginning. An autoload definition appears just as a '(defun . NAME)' and the '(t . NAME)' entries are not generated any more. =20 +--- +** The Tamil input methods do not insert Tamil digits anymore. +The input methods 'tamil-itrans' and 'tamil-inscript' no longer insert +the Tamil digit. To get back the previous behaviour, use the +'tamil-itrans-digits' and 'tamil-inscript-digits' input methods +instead. + * Changes in Emacs 29.1 =20 @@ -1656,6 +1663,13 @@ when used as part of a property list specification f= or the ** 'defalias' records a more precise history of definitions. This is recorded in the `function-history` symbol property. =20 +--- +** 'indian-tml-base-table' no longer translates digits. +Use 'indian-tml-base-digits-table' if you want digits translation. + +-- +** 'indian-tml-itrans-v5-hash' no longer translates digits. +Use 'indian-tml-itrans-digits-v5-hash' if you digits translation. * Changes in Emacs 29.1 on Non-Free Operating Systems =20 diff --git a/lisp/language/ind-util.el b/lisp/language/ind-util.el index 8b1c3d69ae..60ada03fa2 100644 --- a/lisp/language/ind-util.el +++ b/lisp/language/ind-util.el @@ -255,6 +255,29 @@ "=E0=B4=A3=E0=B5=8D" ?=E0=B5=BA "=E0=B4=A8=E0=B5=8D" ?=E0=B5=BB "=E0= =B4=B0=E0=B5=8D" ?=E0=B5=BC "=E0=B4=B2=E0=B5=8D" ?=E0=B5=BD "=E0=B4=B3=E0= =B5=8D" ?=E0=B5=BE))) =20 (defvar indian-tml-base-table + '( + (;; VOWELS + (?=E0=AE=85 nil) (?=E0=AE=86 ?=E0=AE=BE) (?=E0=AE=87 ?=E0=AE=BF) (?= =E0=AE=88 ?=E0=AF=80) (?=E0=AE=89 ?=E0=AF=81) (?=E0=AE=8A ?=E0=AF=82) + nil nil nil (?=E0=AE=8F ?=E0=AF=87) (?=E0=AE=8E ?=E0=AF=86) (?=E0=AE= =90 ?=E0=AF=88) + nil (?=E0=AE=93 ?=E0=AF=8B) (?=E0=AE=92 ?=E0=AF=8A) (?=E0=AE=94 ?=E0= =AF=8C) nil nil) + (;; CONSONANTS + ?=E0=AE=95 nil nil nil ?=E0=AE=99 ;; GUTTRULS + ?=E0=AE=9A nil ?=E0=AE=9C nil ?=E0=AE=9E ;; PALATALS + ?=E0=AE=9F nil nil nil ?=E0=AE=A3 ;; CEREBRALS + ?=E0=AE=A4 nil nil nil ?=E0=AE=A8 ?=E0=AE=A9 ;; DENTALS + ?=E0=AE=AA nil nil nil ?=E0=AE=AE ;; LABIALS + ?=E0=AE=AF ?=E0=AE=B0 ?=E0=AE=B1 ?=E0=AE=B2 ?=E0=AE=B3 ?=E0=AE=B4 ?= =E0=AE=B5 ;; SEMIVOWELS + nil ?=E0=AE=B7 ?=E0=AE=B8 ?=E0=AE=B9 ;; SIBILANTS + nil nil nil nil nil nil nil nil ;; NUKTAS + "=E0=AE=9C=E0=AF=8D=E0=AE=9E" "=E0=AE=95=E0=AF=8D=E0=AE=B7") + (;; Misc Symbols + nil ?=E0=AE=82 ?=E0=AE=83 nil ?=E0=AF=8D nil nil) + (;; Digits + nil nil nil nil nil nil nil nil nil nil) + (;; Inscript-extra (4) (#, $, ^, *, ]) + "=E0=AF=8D=E0=AE=B0" "=E0=AE=B0=E0=AF=8D" "=E0=AE=A4=E0=AF=8D=E0=AE= =B0" nil nil))) + +(defvar indian-tml-base-digits-table '( (;; VOWELS (?=E0=AE=85 nil) (?=E0=AE=86 ?=E0=AE=BE) (?=E0=AE=87 ?=E0=AE=BF) (?= =E0=AE=88 ?=E0=AF=80) (?=E0=AE=89 ?=E0=AF=81) (?=E0=AE=8A ?=E0=AF=82) @@ -557,6 +580,10 @@ (defvar indian-tml-itrans-v5-hash (indian-make-hash indian-tml-base-table indian-itrans-v5-table-for-tamil)) + +(defvar indian-tml-itrans-digits-v5-hash + (indian-make-hash indian-tml-base-digits-table + indian-itrans-v5-table-for-tamil)) ) =20 (defmacro indian-translate-region (from to hashtable encode-p) diff --git a/lisp/leim/quail/indian.el b/lisp/leim/quail/indian.el index 23204c0cd3..33ad79fce4 100644 --- a/lisp/leim/quail/indian.el +++ b/lisp/leim/quail/indian.el @@ -171,7 +171,7 @@ clm) (with-temp-buffer (insert "\n") - (insert " +") + (insert "----+") (insert-char ?- 74) (insert "\n |") (setq clm 6) @@ -293,16 +293,39 @@ You can input characters using the following mapping = tables. Example: To enter =E0=AE=B5=E0=AE=A3=E0=AE=95=E0=AF=8D=E0=AE=95=E0=AE= =AE=E0=AF=8D, type vaNakkam. =20 ### Basic syllables (consonants + vowels) ### -\\ +\\=3D\\ =20 ### Miscellaneous (various signs + digits) ### -\\ +\\=3D\\ =20 ### Others (numerics + symbols) ### =20 Characters below have no ITRANS method associated with them. Their descriptions are included for easy reference. -\\ +\\=3D\\ + +Full key sequences are listed below:") + +(if nil + (quail-define-package "tamil-itrans-digits" "Tamil" "TmlITD" t "Tamil = ITRANS with digits")) +(quail-define-indian-trans-package + indian-tml-itrans-digits-v5-hash "tamil-itrans-digits" "Tamil" "TmlITD" + "Tamil transliteration by ITRANS method with Tamil digits support. + +You can input characters using the following mapping tables. + Example: To enter =E0=AE=B5=E0=AE=A3=E0=AE=95=E0=AF=8D=E0=AE=95=E0=AE= =AE=E0=AF=8D, type vaNakkam. + +### Basic syllables (consonants + vowels) ### +\\=3D\\ + +### Miscellaneous (various signs + digits) ### +\\=3D\\ + +### Others (numerics + symbols) ### + +Characters below have no ITRANS method associated with them. +Their descriptions are included for easy reference. +\\=3D\\ =20 Full key sequences are listed below:") =20 @@ -479,6 +502,13 @@ Full key sequences are listed below:") "tamil-inscript" "Tamil" "TmlIS" "Tamil keyboard Inscript.") =20 +(if nil + (quail-define-package "tamil-inscript-digits" "Tamil" "TmlISD" t "Tami= l keyboard Inscript with digits.")) +(quail-define-inscript-package + indian-tml-base-digits-table inscript-tml-keytable + "tamil-inscript-digits" "Tamil" "TmlISD" + "Tamil keyboard Inscript with Tamil digits support.") + ;; Probhat Input Method (quail-define-package "bengali-probhat" "Bengali" "BngPB" t --=20 2.33.1 --=-=-= Content-Type: text/plain > Btw, the patch is already close to the limit of what we can accept > without copyright assignment, so would you like to start your legal > paperwork rolling at this time, so that we could in the future accept > more contributions from you? If yes, I will send you the form to fill > and the instructions to go with that. > BTW, I sent the mail to assign@gnu.org on 23rd Feb, and haven't heard from them yet. > Thanks. --=-=-=--