From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#54406: 28.0.91; rcirc text wrapping Date: Thu, 17 Mar 2022 11:33:16 +0000 Message-ID: <87r1703jb7.fsf@posteo.net> References: <87lexac44t.fsf@redhat.com> <87h77yc0rt.fsf_-_@redhat.com> <8735jgvo12.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="356"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ken Raeburn , 54406@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 17 12:34:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUoOT-000AQI-6v for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Mar 2022 12:34:13 +0100 Original-Received: from localhost ([::1]:56360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUoOR-0007gD-O0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Mar 2022 07:34:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUoOJ-0007eW-7M for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 07:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59330) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUoOI-0001aF-4M for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 07:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nUoOH-0005KV-Vm for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2022 07:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Mar 2022 11:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54406 X-GNU-PR-Package: emacs Original-Received: via spool by 54406-submit@debbugs.gnu.org id=B54406.164751680620439 (code B ref 54406); Thu, 17 Mar 2022 11:34:01 +0000 Original-Received: (at 54406) by debbugs.gnu.org; 17 Mar 2022 11:33:26 +0000 Original-Received: from localhost ([127.0.0.1]:53227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUoNh-0005Jb-M2 for submit@debbugs.gnu.org; Thu, 17 Mar 2022 07:33:25 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:57041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUoNg-0005JL-3d for 54406@debbugs.gnu.org; Thu, 17 Mar 2022 07:33:24 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B9A61240101 for <54406@debbugs.gnu.org>; Thu, 17 Mar 2022 12:33:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1647516797; bh=p4Jo5BRmqBcG1jU4k9CBrrC4mD1pYmnfC9qcCb9/Onw=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=rfSHd5wGlPy7vbiGBZxtqtwWU6bi6tZDz4C4LU6/h/dJ1yZVguCuLMlVObr7qy6mN Zm/ff5ErU7lTUcWxzFDpws+rddW2zpNRphxCZ/d686UpY6AkugWMRNyLgyqH0VY36K GQWJznz5O1khtr3P9MaZ8RNVsK0466w11yWkA9cb283vEjV8WtyseVH+lL9IEr+UDd AU2tr338ZW6+x64CtBBSG3umFpg2dQQwK5SMvVqsWgXR+OA68Wz4cECsocrQE5L9Ma s2+P0BJ6oYcXTl/0FG3fieP+WH0dRqMkJahZeXMT640vB113PtEOnboSqcGCsh9E6B h8tmjOmsmycUg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4KK4lK0fkrz9rxW; Thu, 17 Mar 2022 12:33:16 +0100 (CET) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <8735jgvo12.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 17 Mar 2022 12:03:53 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228476 Archived-At: Lars Ingebrigtsen writes: > Ken Raeburn writes: > >> The old version in 27.1 did: >> >> ;; squeeze spaces out of text before rcirc-text >> (fill-region fill-start >> (1- (or (next-single-property-change fill-start >> 'rcirc-text) >> rcirc-prompt-end-marker))) >> >> where fill-start is set to >> >> (marker-position rcirc-prompt-start-marker) >> >> evaluated before inserting the new text. The new version seems to be >> filling the entire narrowed region containing the just-inserted text. > > So I guess this was changed in: > > commit 849e71fd83fa8796198035464897bf2f28f6226c > Author: Philip Kaludercic > AuthorDate: Wed Jun 9 17:55:55 2021 +0200 > > I've added Philip to the CCs; perhaps he has some comments. It seems this was just a misunderstanding on what the "squeeze"-code does. The reason it had to be changed is so that messages with time-stamps could be received out-of-order. I am guessing (but would have to look into it in more detail) that the intention could be implemented more elegantly than by calling fill-region on a specific region. -- Philip Kaludercic