From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 54488@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#54488: 29.0.50; move-to-column/overlay-related regression in latest master, perhaps 28?
Date: Tue, 22 Mar 2022 14:54:13 +0000 [thread overview]
Message-ID: <87r16uavhm.fsf@gmail.com> (raw)
In-Reply-To: <834k3qf48k.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 22 Mar 2022 16:31:39 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> So I need your help with understanding what exactly fails in the
> original use case, due to this change. Specifically, how does the
> code involved in this use move-to-column/current-column when there are
> display strings with embedded newlines around?
I think I alluded to/explained this in the original bug report. I'll
try again: eglot needs just move-to-column that it runs in a narrowed
region containing only the line and obtain an upper bound of the
"LSP-abiding" column that the LSP server means (unfortunately the
LSP-abiding column may differ from Emacs's understanding of columns
because of different assumpting regarding length of character
encodings).
Eglot then gets (point) and tries "encode-coding-string" to measure
things.
In Emacs 29, before the fix, that (point) seems to -- very surprisingly
-- return something beyond the narrowed region and so
encode-coding-string will complain with args out of range.
In the example I gave you, that narrowed region, (point-max) is 176.
- that (point) form returns 179 in Emacs 29 -- error obviously.
- that (point) form returns 167 in Emacs 27 -- no error.
This is the code more or less in Eglot:
(defun eglot-move-to-lsp-abiding-column (column)
"Move to COLUMN abiding by the LSP spec."
(save-restriction
(cl-loop
with lbp = (line-beginning-position)
initially
(narrow-to-region lbp (line-end-position))
(move-to-column column)
for diff = (- column
(/ (- (length (encode-coding-region (or lbp (line-beginning-position))
(point) 'utf-16 t))
2)
2))
until (zerop diff)
do (condition-case eob-err
(forward-char (/ (if (> diff 0) (1+ diff) (1- diff)) 2))
(end-of-buffer (cl-return eob-err))))))
João
next prev parent reply other threads:[~2022-03-22 14:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 6:54 bug#54488: 29.0.50; move-to-column/overlay-related regression in latest master, perhaps 28? João Távora
2022-03-21 12:32 ` Eli Zaretskii
2022-03-21 16:37 ` João Távora
2022-03-21 17:05 ` Eli Zaretskii
2022-03-21 21:59 ` João Távora
2022-03-21 23:14 ` Dmitry Gutov
2022-03-22 9:48 ` João Távora
2022-03-22 12:16 ` Eli Zaretskii
2022-03-22 13:57 ` Eli Zaretskii
2022-03-22 14:31 ` Eli Zaretskii
2022-03-22 14:54 ` João Távora [this message]
2022-03-22 15:22 ` Eli Zaretskii
2022-03-22 16:06 ` João Távora
2022-03-22 16:53 ` Eli Zaretskii
2022-03-22 21:05 ` João Távora
2022-03-22 23:55 ` Dmitry Gutov
2022-03-23 1:11 ` João Távora
2022-03-23 3:39 ` Eli Zaretskii
2022-03-23 10:10 ` João Távora
2022-03-23 11:08 ` João Távora
2022-03-23 14:21 ` Eli Zaretskii
2022-03-24 15:01 ` João Távora
2022-03-24 15:29 ` Eli Zaretskii
2022-03-24 16:03 ` João Távora
2022-03-24 16:59 ` Eli Zaretskii
2022-03-23 3:34 ` Eli Zaretskii
2022-03-23 3:29 ` Eli Zaretskii
2022-03-23 10:04 ` João Távora
2022-03-23 13:23 ` Eli Zaretskii
2022-03-24 14:54 ` João Távora
2022-03-22 12:33 ` Dmitry Gutov
2022-03-22 13:50 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r16uavhm.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=54488@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).