From: Lars Ingebrigtsen <larsi@gnus.org>
To: handa <handa@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
gregory@heytings.org, 46933@debbugs.gnu.org
Subject: bug#46933: Possible bugs in filepos-to-bufferpos / bufferpos-to-filepos
Date: Mon, 20 Jun 2022 02:59:52 +0200 [thread overview]
Message-ID: <87r13kqhdj.fsf@gnus.org> (raw)
In-Reply-To: <87im53ny95.fsf@gnu.org> (handa@gnu.org's message of "Sun, 04 Apr 2021 01:12:06 +0900")
handa <handa@gnu.org> writes:
> But it seems that the usage in Info-find-node-2 is:
> a byte position in an existing file that may not be created by Emacs
>
> There's a case that they are different. The method I wrote in the
> previous mail works only in the former case. And it seems that the
> current implementation of filepos-to-bufferpos is the same because it
> tries to get byte sequence by encode-coding-region.
>
> For the latter case, perhaps something like the following code works.
>
> ;; Return the buffer position correspoinding to the byte position
> ;; FILEPOS in FILE provided that FILE is decoded by CODING-SYSTEM.
> (defun temp (file filepos coding-system)
> (with-temp-buffer
> (set-buffer-multibyte nil)
> (insert-file-contents-literally file)
> (let ((full (decode-coding-region 1 (point-max) coding-system t))
> partial)
> (while (and (setq partial (decode-coding-region 1 (1+ filepos)
> coding-system t))
> (not (eq (compare-strings full 0 (length partial)
> partial 0 (length partial))
> t)))
> (setq filepos (1+ filepos)))
> (1+ (length partial)))))
>
> If it is too slow, there are a few ways to make it faster.
(I'm going through old bug reports that unfortunately weren't resolved
at the time.)
If I understand correctly, the suggestion here is to use this function
in Info-find-node-2 instead of `filepos-to-bufferpos'?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-06-20 0:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 21:21 bug#46933: Possible bugs in filepos-to-bufferpos / bufferpos-to-filepos Gregory Heytings
2021-03-21 15:27 ` Eli Zaretskii
2021-03-27 5:38 ` handa
2021-03-27 7:54 ` Eli Zaretskii
2021-03-27 13:23 ` handa
2021-03-27 13:54 ` Eli Zaretskii
2021-03-28 14:29 ` handa
2021-03-28 14:51 ` Eli Zaretskii
2021-04-01 15:14 ` handa
2021-04-01 15:25 ` Eli Zaretskii
2021-04-01 15:32 ` Eli Zaretskii
2021-04-03 16:12 ` handa
2022-06-20 0:59 ` Lars Ingebrigtsen [this message]
2022-06-20 11:52 ` Eli Zaretskii
2022-06-21 10:40 ` Lars Ingebrigtsen
2022-06-21 12:14 ` Eli Zaretskii
2022-06-22 4:17 ` Lars Ingebrigtsen
2022-06-22 13:11 ` Eli Zaretskii
2021-03-27 14:24 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r13kqhdj.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=46933@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
--cc=handa@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).