From: Ihor Radchenko <yantar92@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 51766@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#51766: string-pixel-width limitations (was: bug#51766: 29.0.50; Return value of buffer-chars-modified-tick changes when buffer text is not yet changed before inserting a character for non-latin input methods)
Date: Tue, 21 Jun 2022 19:00:34 +0800 [thread overview]
Message-ID: <87r13iqo19.fsf@localhost> (raw)
In-Reply-To: <83fsjyl3sz.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> > That discussion is very short and lacking in detail, but up front, why
>> > doesn't valign use the primitives we provide for determining the pixel
>> > width of a string?
>>
>> Because string width in different buffers may be different depending on
>> the fontification, frame font size, face remapping,
>> wrap-prefix/line-prefix string properties (AFAIK, the built-in
>> string-pixel-width will return incorrect value on string with such
>> properties), invisibility specs in the buffer, line numbers mode, etc
>> We have implemented a number of workarounds in org-string-width on main,
>> but I am not 100% sure that I covered all the edge cases.
>
> If you need such high accuracy, may I suggest window-text-pixel-size?
window-text-pixel-size suffers from the same issues with
wrap-prefix/line-prefix and line numbers mode.
Also, in order to use it in current buffer on not-yet-inserted string,
you need to insert it. That where the issue in valign originated from.
Best,
Ihor
next prev parent reply other threads:[~2022-06-21 11:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 13:56 bug#51766: 29.0.50; Return value of buffer-chars-modified-tick changes when buffer text is not yet changed before inserting a character for non-latin input methods Ihor Radchenko
2021-11-11 15:19 ` Eli Zaretskii
2021-11-11 15:50 ` Ihor Radchenko
2021-11-11 17:35 ` Eli Zaretskii
2021-11-12 12:06 ` Ihor Radchenko
2021-11-12 12:15 ` Eli Zaretskii
2021-11-12 12:53 ` Ihor Radchenko
2021-11-12 13:09 ` Eli Zaretskii
2021-11-12 13:39 ` Ihor Radchenko
2021-11-12 15:17 ` Eli Zaretskii
2021-11-13 9:10 ` Ihor Radchenko
2021-11-13 10:11 ` Eli Zaretskii
2021-11-13 11:29 ` Ihor Radchenko
2021-11-13 13:38 ` Eli Zaretskii
2021-11-13 14:43 ` Ihor Radchenko
2021-11-13 15:24 ` Eli Zaretskii
2022-06-17 2:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-17 5:36 ` Eli Zaretskii
2022-06-17 13:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-17 10:05 ` Ihor Radchenko
2022-06-17 10:50 ` Eli Zaretskii
2022-06-21 4:13 ` bug#51766: string-pixel-width limitations (was: bug#51766: 29.0.50; Return value of buffer-chars-modified-tick changes when buffer text is not yet changed before inserting a character for non-latin input methods) Ihor Radchenko
2022-06-21 10:16 ` Eli Zaretskii
2022-06-21 11:00 ` Ihor Radchenko [this message]
2022-06-21 12:17 ` Eli Zaretskii
2022-06-21 12:39 ` Ihor Radchenko
2022-06-21 12:47 ` Eli Zaretskii
2022-06-21 13:03 ` Ihor Radchenko
2022-06-22 23:49 ` bug#51766: string-pixel-width limitations Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-17 13:28 ` bug#51766: 29.0.50; Return value of buffer-chars-modified-tick changes when buffer text is not yet changed before inserting a character for non-latin input methods Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-21 4:14 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r13iqo19.fsf@localhost \
--to=yantar92@gmail.com \
--cc=51766@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).