From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: dick Newsgroups: gmane.emacs.bugs Subject: bug#56372: 29.0.50; [PATCH] Avoid BadMatch X11 error Date: Mon, 04 Jul 2022 08:12:48 -0400 Message-ID: <87r131m5z3.fsf@dick> References: <87czemtfv0.fsf@dick> <87r131fpmm.fsf@dick> <87r1319ojr.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2575"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/29.0.50 (gnu/linux) Cc: luangruo@yahoo.com, larsi@gnus.org To: 56372@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 04 17:36:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8O7e-0000Xy-Pu for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jul 2022 17:36:26 +0200 Original-Received: from localhost ([::1]:39786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8O7d-0004GX-EM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jul 2022 11:36:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8O7G-0004Ex-Hu for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 11:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54590) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8O7G-0004Yi-9V for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 11:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8O7G-0007SF-53 for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 11:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: dick Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2022 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56372 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo X-Debbugs-Original-To: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Po Lu , 56372@debbugs.gnu.org, Lars Ingebrigtsen Original-Received: via spool by submit@debbugs.gnu.org id=B.165694895228636 (code B ref -1); Mon, 04 Jul 2022 15:36:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Jul 2022 15:35:52 +0000 Original-Received: from localhost ([127.0.0.1]:48487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8O74-0007Rm-Jp for submit@debbugs.gnu.org; Mon, 04 Jul 2022 11:35:52 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:35310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8Kwg-0001aO-Fd for submit@debbugs.gnu.org; Mon, 04 Jul 2022 08:12:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Kwe-0006MR-Nd for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 08:12:52 -0400 Original-Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:47041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8Kwd-0007Mm-9q for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 08:12:52 -0400 Original-Received: by mail-qk1-x72f.google.com with SMTP id r138so6624907qke.13 for ; Mon, 04 Jul 2022 05:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :user-agent:mime-version; bh=IbJLWL9IXDjF+ORwWQpT6nbXJA7zLKrVbDPjkrDgVTI=; b=P1OHg8RJ+fybpr4I6JygmLRq0piRk8Fpq3h26MVlWKTz9aUgnPahvVdnsKui1fgZxA ZiRs9JyCon2XNWRR8tcxnAR6puTR010Wp0Wdk9OmnreCsD7nmyIQz0NCKRXTX6ZmQ3Rm 7J4vXwbInLmjqawWl46kakiz1Abt9lWrviVogSG2eRk30VLu6HaXDs4ylIh2uc/nsK0B ER0Y7jqfAnoXpelCg1JA82g2O8BLzRMYrJtnLHS9f04HzEXgw/wRzdJ4Di73w1qxgVpR YtC4W7rPCm50G+2Jyd4zLC+Czo7JhNRja4UiWd80nUJhONxEoBCmTm/JkIPS5jwp8j2y 11mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:user-agent:mime-version; bh=IbJLWL9IXDjF+ORwWQpT6nbXJA7zLKrVbDPjkrDgVTI=; b=BMN/tS/52TAn1iTiAjU9IhE8sFqJexg3nNMEx/L5Jka4S3IWSJ+Ucdeofrn60M7dP+ 8KI7JhFeMXSx0oSj5cIjsPisEfvjknmtyvMVj/gws6z/t+F04MhIPxLmnzv0p/Ip4M2G Dr0+428vIwidHZeJN9oMHapTYsVC4dHfFZ+6W7DzE/0EYe95Yj6lmA/+jKcmbKTqjHJ5 dGiV/gGLNieY0n0EbBbZiVqLlt1v5BYjasgxzSopUfh8ltM6WGkaxX83Ls/HMPLZf7Fr RejBokeqYCg+saDfW6xmEN8x7rbJzL4PGV6/V4O1Xi5NNJLylS4ijNsJet+hWURDc0jb EHwg== X-Gm-Message-State: AJIora9i6EX+DfHiV/ayUK3QDLfpdEsFu7jqGnJu+rwp38jaPWx4SMO3 tqFAvuPHQg4LgLz7tH+szrUibb0KAwY= X-Google-Smtp-Source: AGRyM1s4j0lu2BdfximR+wsxGLQj5WMG1/vs7sqoEdlX524X2TMzMwWNwRD3ibuHcx79rEvfNM003A== X-Received: by 2002:a05:620a:17a2:b0:6b2:4491:f7bd with SMTP id ay34-20020a05620a17a200b006b24491f7bdmr14361978qkb.570.1656936770230; Mon, 04 Jul 2022 05:12:50 -0700 (PDT) Original-Received: from localhost (ool-457830b3.dyn.optonline.net. [69.120.48.179]) by smtp.gmail.com with ESMTPSA id o15-20020ac8554f000000b0031801a52484sm18070642qtr.79.2022.07.04.05.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 05:12:49 -0700 (PDT) In-Reply-To: <87r1319ojr.fsf@yahoo.com> (Po Lu via's message of "Mon, 04 Jul 2022 18:10:00 +0800") Received-SPF: pass client-ip=2607:f8b0:4864:20::72f; envelope-from=dick.r.chiang@gmail.com; helo=mail-qk1-x72f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 04 Jul 2022 11:35:49 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236062 Archived-At: BrfGEtSakote> That piece of code is already inside "if (dpyinfo)" -- in BrfGEtSakote> fact, your patch misses a use-after-free, which has BrfGEtSakote> already been fixed on master. Sheesh, how about "Thanks, I fixed it in bd034b3," as opposed to implying there was never a bug, and that my patch fails to address an unrelated issue. I get it though. My own social and technical failings in the private sector have also led me to emacs, a halfway house for greybeards exiled from the labor market.