bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Visuwesh]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

Tags: patch

Yanking with the mouse (i.e., mouse-2) does not replace the selected
region if delete-selection-mode is turned on.  Attached patch makes the
mouse yank commands delete-selection-mode aware.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Make-mouse-3-respect-delete-selection-mode.patch --]
[-- Type: text/patch, Size: 983 bytes --]

From 699b0b80648cb4b3d926937bf259442ccc1612a5 Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Wed, 6 Jul 2022 20:27:16 +0530
Subject: [PATCH] Make mouse-2 respect delete-selection mode

* lisp/delsel.el: Make the mouse yank commands delete-selection-mode
aware.
---
 lisp/delsel.el | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lisp/delsel.el b/lisp/delsel.el
index 5310328e5f..723a52b17d 100644
--- a/lisp/delsel.el
+++ b/lisp/delsel.el
@@ -300,6 +300,9 @@ delete-selection-uses-region-p
 (put 'yank-pop 'delete-selection 'yank)
 (put 'yank-from-kill-ring 'delete-selection 'yank)
 (put 'clipboard-yank 'delete-selection 'yank)
+(put 'mouse-yank-primary 'delete-selection 'yank)
+(put 'mouse-yank-secondary 'delete-selection 'yank)
+(put 'mouse-yank-at-click 'delete-selection 'yank)
 (put 'insert-register 'delete-selection t)
 ;; delete-backward-char and delete-forward-char already delete the selection by
 ;; default, but not delete-char.
--
2.35.1

[-- Attachment #3: Type: text/plain, Size: 517 bytes --]


In GNU Emacs 29.0.50 (build 3, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2022-07-03 built on astatine
Repository revision: c4930e938b6f9f21b4a9c37912d2b6ce4796b9a2
Repository branch: tamil-phonetic2
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-modules --with-sound=alsa --with-x-toolkit=lucid
 --with-json --without-xaw3d --without-gconf --without-libsystemd
 --with-x --without-cairo'

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Stefan Kangas]

severity 56421 wishlist
thanks

Visuwesh <visuweshm@gmail.com> writes:

> Yanking with the mouse (i.e., mouse-2) does not replace the selected
> region if delete-selection-mode is turned on.  Attached patch makes the
> mouse yank commands delete-selection-mode aware.

What does other software in X do here?  From some light testing, it
seems to me like it does not replace the selection?

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Visuwesh]

[புதன் ஜூலை 06, 2022] Stefan Kangas wrote:

> Visuwesh <visuweshm@gmail.com> writes:
>
>> Yanking with the mouse (i.e., mouse-2) does not replace the selected
>> region if delete-selection-mode is turned on.  Attached patch makes the
>> mouse yank commands delete-selection-mode aware.
>
> What does other software in X do here?  From some light testing, it
> seems to me like it does not replace the selection?

Ah, I did not notice that it is done by Chrome either, and I don't have
any other X app handy to test.  I was surprised when mouse-2 did not
replace the region, and found it inconsistent.

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Stefan Kangas]

Visuwesh <visuweshm@gmail.com> writes:

> Ah, I did not notice that it is done by Chrome either, and I don't have
> any other X app handy to test.  I was surprised when mouse-2 did not
> replace the region, and found it inconsistent.

So I guess the new behaviour should be optional?

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Visuwesh]

[புதன் ஜூலை 06, 2022] Stefan Kangas wrote:

> Visuwesh <visuweshm@gmail.com> writes:
>
>> Ah, I did not notice that it is done by Chrome either, and I don't have
>> any other X app handy to test.  I was surprised when mouse-2 did not
>> replace the region, and found it inconsistent.
>
> So I guess the new behaviour should be optional?

If you think we should be consistent, then I'd rather drop the patch
than add yet another defcustom.  It isn't hard to copy those lines to my
config anyway.

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Stefan Kangas]

tags 56421 + moreinfo
thanks

Visuwesh <visuweshm@gmail.com> writes:

> If you think we should be consistent, then I'd rather drop the patch
> than add yet another defcustom.  It isn't hard to copy those lines to my
> config anyway.

Let's see if anyone else has an opinion here.

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Juri Linkov]

>> If you think we should be consistent, then I'd rather drop the patch
>> than add yet another defcustom.  It isn't hard to copy those lines to my
>> config anyway.
>
> Let's see if anyone else has an opinion here.

This should be the right thing to do, some time ago
we already discussed this because I had these uncommitted lines:

+(put 'mouse-yank-primary 'delete-selection 'yank)
+(put 'mouse-yank-at-click 'delete-selection 'yank)
+(put 'menu-bar-select-yank 'delete-selection 'yank)

BTW, I also had this line

+(put 'just-one-space 'delete-selection t)

but since M-SPC is bound to cycle-spacing now,
I'm not sure about M-SPC anymore.  How does
cycle-spacing handle regions?  Maybe it should
squeeze all consequent spaces to one space
everywhere in the region?

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Visuwesh <visuweshm@gmail.com> writes:

> Ah, I did not notice that it is done by Chrome either, and I don't have
> any other X app handy to test.  I was surprised when mouse-2 did not
> replace the region, and found it inconsistent.

Having Button2 replace the region is not the right thing on X, which is
actually to deactivate the mark upon losing ownership of the primary
selection.  So what you talk about cannot happen in other X programs
(Emacs is the odd one out here.)

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Stefan Kangas]

Po Lu <luangruo@yahoo.com> writes:

> Having Button2 replace the region is not the right thing on X, which is
> actually to deactivate the mark upon losing ownership of the primary
> selection.  So what you talk about cannot happen in other X programs
> (Emacs is the odd one out here.)

Are you saying that Emacs currently behaves differently from other
programs on X in this regard?

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefan@marxist.se> writes:

> Are you saying that Emacs currently behaves differently from other
> programs on X in this regard?

Yes, and it has been doing that for a very long time.

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Visuwesh]

[புதன் ஜூலை 06, 2022] Juri Linkov wrote:

>>> If you think we should be consistent, then I'd rather drop the patch
>>> than add yet another defcustom.  It isn't hard to copy those lines to my
>>> config anyway.
>>
>> Let's see if anyone else has an opinion here.
>
> This should be the right thing to do, some time ago
> we already discussed this because I had these uncommitted lines:

It is really convenient to follow up with a mouse-2 after a multi-click
mouse-1 to replace the region IMO.  No need to take your hands off the
mouse.

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Juri Linkov]

>>>> If you think we should be consistent, then I'd rather drop the patch
>>>> than add yet another defcustom.  It isn't hard to copy those lines to my
>>>> config anyway.
>>>
>>> Let's see if anyone else has an opinion here.
>>
>> This should be the right thing to do, some time ago
>> we already discussed this because I had these uncommitted lines:
>
> It is really convenient to follow up with a mouse-2 after a multi-click
> mouse-1 to replace the region IMO.  No need to take your hands off the
> mouse.

Do you have additional customization that allows you to achieve this
convenient behavior?  Such as setting select-active-regions to nil.

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Visuwesh]

[வியாழன் ஜூலை 07, 2022] Juri Linkov wrote:

>> It is really convenient to follow up with a mouse-2 after a multi-click
>> mouse-1 to replace the region IMO.  No need to take your hands off the
>> mouse.
>
> Do you have additional customization that allows you to achieve this
> convenient behavior?  Such as setting select-active-regions to nil.

I can't think of any that is particularly special about my
customisation, but I have delete-selection-temporary-region, and
mouse-yank-at-point set to t.  I also have select-enable-clipboard set
to nil since I like to separate Emacs' kill-ring and the Xorg clipboard
but I don't think that is relevant here.

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

>>> If you think we should be consistent, then I'd rather drop the patch
>>> than add yet another defcustom.  It isn't hard to copy those lines to my
>>> config anyway.
>>
>> Let's see if anyone else has an opinion here.
>
> This should be the right thing to do, some time ago
> we already discussed this because I had these uncommitted lines:
>
> +(put 'mouse-yank-primary 'delete-selection 'yank)
> +(put 'mouse-yank-at-click 'delete-selection 'yank)
> +(put 'menu-bar-select-yank 'delete-selection 'yank)

I agree, so I've applied Visuwesh's patch to Emacs 29.

> BTW, I also had this line
>
> +(put 'just-one-space 'delete-selection t)
>
> but since M-SPC is bound to cycle-spacing now,
> I'm not sure about M-SPC anymore.  How does
> cycle-spacing handle regions?  Maybe it should
> squeeze all consequent spaces to one space
> everywhere in the region?

Hm, not sure either.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I agree, so I've applied Visuwesh's patch to Emacs 29.

This should be announced in NEWS as an incompatible editing change,
along with instructions to disable it.

Though IMNSHO, the right solution is to enable `lost-selection-mode' and
to ignore middle-clicks on the region, so this situation cannot happen
in the first place.

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> This should be announced in NEWS as an incompatible editing change,
> along with instructions to disable it.

It doesn't really feel NEWS-worthy to me -- it's a pretty natural DWIM
tweak.

> Though IMNSHO, the right solution is to enable `lost-selection-mode' and
> to ignore middle-clicks on the region, so this situation cannot happen
> in the first place.

Well, if you have `lost-selection-mode' switched on, it's even less
NEWS-worthy.  😀

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> It doesn't really feel NEWS-worthy to me -- it's a pretty natural DWIM
> tweak.

I disagree, but how you or I feel isn't what should be guiding the
decision of whether or not to put something in NEWS.  It's a change to
very old behavior, and is thus newsworthy.

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> It doesn't really feel NEWS-worthy to me -- it's a pretty natural DWIM
> tweak.

But it is different from the convention on X, right?

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> But it is different from the convention on X, right?

Yes, but it only has an effect if Emacs doesn't heed the X convention
(i.e., lost-selection-mode isn't on).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefan@marxist.se> writes:

> But it is different from the convention on X, right?

Right.  That convention is what you would get with `lost-selection-mode'
(which I recently added) enabled, along with this change.

bug#56421: [PATCH] Make mouse-2 respect delete-selection mode

[Lars Ingebrigtsen]

I've now reopened this due to bug#56530 (and reverted the commit).


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no