From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#57082: 29.0.50; emacs-news-view-mode breakage Date: Wed, 10 Aug 2022 10:19:19 +0200 Message-ID: <87r11owlx4.fsf@gmx.net> References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <86bkssedll.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6816"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 10 10:20:52 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLgxP-0001We-To for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Aug 2022 10:20:51 +0200 Original-Received: from localhost ([::1]:44270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLgxO-0003AR-VB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Aug 2022 04:20:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLgwc-00039f-8d for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 04:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLgwb-0000c2-Mk for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 04:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLgwb-0007Ko-I3 for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 04:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Aug 2022 08:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57082 X-GNU-PR-Package: emacs Original-Received: via spool by 57082-submit@debbugs.gnu.org id=B57082.166011956928149 (code B ref 57082); Wed, 10 Aug 2022 08:20:01 +0000 Original-Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 08:19:29 +0000 Original-Received: from localhost ([127.0.0.1]:45972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgw5-0007Jx-5e for submit@debbugs.gnu.org; Wed, 10 Aug 2022 04:19:29 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:41285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgw3-0007Jk-ID for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 04:19:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660119561; bh=1CYhdf82ykrZChcd847ee9drcjzrdXzGtTDlega8MXY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=LiXUXfmlptRn5OPYCbiv21JwWkPKbL5nDeX+SsArZfOtM8LQkOgFXupp/2sm6LX1o L3Og9dqqtvWbJBFJa9pzLNIbXitjPR+BL+o1W8iKn8DG9TOab/d2iE1SznAH0rvl+X bHzfr/LPyDRbikC+A3JVEH4/W0qKm4SYaRhwvLeI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs2 ([89.246.36.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MtfNl-1nXQxj1vrT-00v5mY; Wed, 10 Aug 2022 10:19:20 +0200 In-Reply-To: <86bkssedll.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 10 Aug 2022 10:36:22 +0300") X-Provags-ID: V03:K1:1sAonxHFhHzPZaawwZsvibSV8f2bjo09QLWMx9mTTKYhB3guQGd OgGGnoLihWN3ogFApOZgijGkAGE84z+g7aLi7whE0EkJmBPcba9Ohh60y7QdXMmTsVzpDIb l2TBG7j7XXGgeMozxJ1kEDIX7OMqpeCJ9EarTGCY0xZDkGIt/9f5vwfn5klywYVX2iiERfb YsCELNCU9IQnEagDFmTXw== X-UI-Out-Filterresults: notjunk:1;V03:K0:XeKv5fiQPPc=:vBDow+4ZBj064VKAVyKPMz m+QUJvU4IMGm6OCr/FM7wWtq6Naf+YAL2XEENJ55clZe0Wo+QBwkvPOrAEm4/C7PMNwKrXtKp XsvdjaxZIpl53Jl3ZqIJr07S2iyLIJnt1DznRuTUMAoygmKzHTfdNQWloynAFHClzZkrrPPVu RAit6b519gsLomOh9Ba1uaW7WAfLi/dam1C3P/oCna94sXIUyS5wBDhM3nmAupGdOhBSxWzPX CU3ziOpNyR6TIOLyOyrsiArzI3fRJfZzuAo/T5r+f6HYyRn+sLna3J7ypg8f49NyEElTrPXSe lt3EipZ6Xc5KLzpsz5jULAR9WAfXPCXGCElDlv+sahPUNYgfoWLURlBTxD2cJ6bn0a3GOA/hn QtNm8FgxpUSwPeJA+cAOA6jP92grSOTPurT7sjfkSmcZEiAGXrM5MzHMloeE99PiogiUya9H4 8IwhQn+wl/Hakp0LToXo+QunJSADKc8cCF7OG+OYsuoz0qZ22q1M1kedLogUUfu7mIL2R9IYU NFIabUpqkXKCEw4bwwRdWp0+o7LjD2sCEVW5f0Omvvx2wLUJk03Pq5hpldWlQaV8B4UkTZZd2 8M5SuPD13ur2FJWJz5klDmm3feh4JzIY9SyY5+sUkuFmo69yVYWXHBRy9JupydA6xON3zq7W0 5oeyf8kPMUDmrh+xKc1M3MPHoNA0rnrXJCNS3GoLyXny/q8E2ZI6WDfW6DeDbKgLULdqIRX2o uGAECQyQyYJQRRWmnAkt6yszY+9i1khi/axSQey7YP5siaR/HDOPdstvK0Razksk1V6n8RNh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239251 Archived-At: On Wed, 10 Aug 2022 10:36:22 +0300 Juri Linkov wrote: >>> Also don't understand why is this change: >>> >>> (when outline-minor-mode-highlight >>> - (if (and global-font-lock-mode (font-lock-specified-p major-mode)) >>> - (progn >>> - (font-lock-add-keywords nil outline-font-lock-keywords t) >>> - (font-lock-flush)) >>> - (outline-minor-mode-highlight-buffer))) >>> + (when (and global-font-lock-mode (font-lock-specified-p major-mode)) >>> + (font-lock-add-keywords nil outline-font-lock-keywords t) >>> + (font-lock-flush)) >>> + (outline-minor-mode-highlight-buffer)) >>> >>> `outline-minor-mode-highlight-buffer' is intended only for buffers >>> that don't support font-lock highlighting. >> >> Yes, but with that change, arrows are displayed on first visiting the >> NEWS buffer; without it, they only appear when typing TAB on an outline >> heading. > > This change broke fontification e.g. in diff buffers that now > add outline faces on diff hunks. So we need another solution. Oh, dear (as I noted in my OP, I only checked NEWS and *Help* with describe-binding). But do you have a recipe to see this? When I create a diff with vc-diff I don't see outline faces on the hunks. Steve Berman